Skip to content

Commit a84a410

Browse files
authored
Merge pull request #325 from IgniteUI/dkamburov/fix-324-9.1
fix(combo): Don't override model if text value represents the same value
2 parents d9df85e + 6bc0949 commit a84a410

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

.travis.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
sudo: required
2-
dist: trusty
2+
dist: xenial
33
language: node_js
44
node_js:
55
- '10.13.0'
6+
addons:
7+
chrome: stable
8+
services:
9+
- xvfb
610
before_install:
7-
- export NG_CLI_ANALYTICS=false
8-
- export CHROME_BIN=/usr/bin/google-chrome
911
- export DISPLAY=:99.0
10-
- sh -e /etc/init.d/xvfb start
11-
- sudo apt-get -qq update
12-
- sudo apt-get install -y libappindicator1 fonts-liberation
13-
- wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
14-
- sudo dpkg -i google-chrome*.deb
1512
- sleep 3
1613

1714
script:

projects/igniteui-angular-wrappers/src/lib/igcombo/igcombo.component.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,12 @@ export class IgComboComponent extends IgControlBase<IgCombo> implements ControlV
4343
if (this._model) {
4444
if (this.options.allowCustomValue) {
4545
jQuery(this._el).on("input", function (evt) {
46-
that._model.viewToModelUpdate(evt.target.value);
46+
// D.K. #324 Do not override the model value if the text value is representing the same model value
47+
let item = jQuery(that._el).data("igCombo").itemsFromValue(that._model.model);
48+
if (!item ||
49+
item.data && item.data[that.options.textKey] !== evt.target.value) {
50+
that._model.viewToModelUpdate(evt.target.value);
51+
}
4752
});
4853

4954
jQuery(this._el).closest(".ui-igcombo-wrapper").find(".ui-igcombo-clear").on("click", function() {

0 commit comments

Comments
 (0)