Skip to content

Commit 05f074b

Browse files
committed
chore(*): fix lint warnings
1 parent 5b81741 commit 05f074b

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ All notable changes for each version of this project will be documented in this
1212
- `IgxCombo`
1313
- Added `groupSortingDirection` input, which allows you to set groups sorting order.
1414
- `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
15-
- Added new directives for re-templating header sorting indicators - `IgxSortHeaderIconDirective`, `igxSortAscendingHeaderIcon` and `igxSortDescendingHeaderIcon`.
15+
- Added new directives for re-templating header sorting indicators - `IgxSortHeaderIconDirective`, `IgxSortAscendingHeaderIconDirective` and `IgxSortDescendingHeaderIconDirective`.
1616

1717
### General
1818

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,9 @@ import { CharSeparatedValueData } from '../services/csv/char-separated-value-dat
9393
import { IgxColumnResizingService } from './resizing/resizing.service';
9494
import { IFilteringStrategy } from '../data-operations/filtering-strategy';
9595
import {
96-
IgxRowExpandedIndicatorDirective, IgxRowCollapsedIndicatorDirective, IgxHeaderExpandIndicatorDirective, IgxHeaderCollapseIndicatorDirective,
97-
IgxExcelStyleHeaderIconDirective, IgxSortAscendingHeaderIconDirective, IgxSortDescendingHeaderIconDirective, IgxSortHeaderIconDirective
96+
IgxRowExpandedIndicatorDirective, IgxRowCollapsedIndicatorDirective, IgxHeaderExpandIndicatorDirective,
97+
IgxHeaderCollapseIndicatorDirective, IgxExcelStyleHeaderIconDirective, IgxSortAscendingHeaderIconDirective,
98+
IgxSortDescendingHeaderIconDirective, IgxSortHeaderIconDirective
9899
} from './grid/grid.directives';
99100
import {
100101
GridKeydownTargetType,
@@ -1253,20 +1254,20 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
12531254
public excelStyleHeaderIconTemplate: TemplateRef<any> = null;
12541255

12551256
/**
1256-
* The custom template, if any, that should be used when rendering a header sorting indicator when the column is sorted in ascending order.
1257+
* The custom template, if any, that should be used when rendering a header sorting indicator when columns are sorted in asc order.
12571258
*/
12581259
@ContentChild(IgxSortAscendingHeaderIconDirective, { read: TemplateRef })
12591260
public sortAscendingHeaderIconTemplate: TemplateRef<any> = null;
12601261

12611262
/**
1262-
* The custom template, if any, that should be used when rendering a header sorting indicator when the column is sorted in descending order.
1263+
* The custom template, if any, that should be used when rendering a header sorting indicator when columns are sorted in desc order.
12631264
*/
12641265
@ContentChild(IgxSortDescendingHeaderIconDirective, { read: TemplateRef })
12651266
public sortDescendingHeaderIconTemplate: TemplateRef<any> = null;
12661267

12671268
/**
1268-
* The custom template, if any, that should be used when rendering a header sorting indicator when the column is not sorted.
1269-
*/
1269+
* The custom template, if any, that should be used when rendering a header sorting indicator when columns are not sorted.
1270+
*/
12701271
@ContentChild(IgxSortHeaderIconDirective, { read: TemplateRef })
12711272
public sortHeaderIconTemplate: TemplateRef<any> = null;
12721273

projects/igniteui-angular/src/lib/grids/grid/grid.sorting.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ describe('IgxGrid - Grid Sorting #grid', () => {
550550
expect(grid.sortingDone.emit).toHaveBeenCalledTimes(2);
551551
}));
552552

553-
it('Should allow setting custom templates for header sorting none/ascending/descending icons.', fakeAsync(/** Filtering showHideArrowButtons RAF */() => {
553+
fit('Should allow setting custom templates for header sorting none/ascending/descending icons.', () => {
554554
fixture = TestBed.createComponent(SortByParityComponent);
555555
fixture.detectChanges();
556556
grid = fixture.componentInstance.grid;
@@ -569,6 +569,6 @@ describe('IgxGrid - Grid Sorting #grid', () => {
569569
fixture.detectChanges();
570570
icon = GridFunctions.getHeaderSortIcon(header);
571571
expect(icon.nativeElement.textContent.toLowerCase().trim()).toBe('expand_more');
572-
}));
572+
});
573573
});
574574
});

0 commit comments

Comments
 (0)