refactor(query-builder): drag restriction when child in edit mode removed

Author: ivanvpetrov

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.html

@@ -140,10 +140,10 @@
             >
                 <igx-chip
                     #expressionChip
-                    [draggable]="canBeDragged()"
+                    [draggable]="true"
                     [hideBaseOnDrag]="false"
                     [animateOnRelease]="false"
-                    (moveStart)="canBeDragged() ? dragService.onMoveStart(dragRef, expressionItem, false): null"
+                    (moveStart)="dragService.onMoveStart(dragRef, expressionItem, false)"
                     (moveEnd)="dragService.onMoveEnd()"
                     (dragEnter)="dragService.onChipEnter(dragRef, expressionItem)"
                     (dragOver)="dragService.onChipOver(dragRef)"

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts

@@ -1030,11 +1030,6 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
 
     public dragService: IgxQueryBuilderDragService = new IgxQueryBuilderDragService(this, this.el, this.deleteItem, this.focusChipAfterDrag);
 
-    //Chip can be dragged if its tree is in edit mode and there is no inner query that's been edited
-    public canBeDragged(): boolean {
-        return this.isInEditMode && (!this.innerQueries || this.innerQueries.length == 0 || !this.innerQueries?.some(q => q.isInEditMode()))
-    }
-
     /**
      * @hidden @internal
      */

projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts

@@ -2873,15 +2873,15 @@ describe('IgxQueryBuilder', () => {
       expect(QueryBuilderFunctions.getChipContent(chipComponents[2].nativeElement)).toBe("OrderDate  Today");
     }));
 
-    it('should prevent dragging a top-level condition while a sub-query is expanded.', () => {
+    it('should be able to drag a top-level condition while a sub-query is expanded.', () => {
       chipComponents[1].nativeElement.click();
 
       const draggedChip = chipComponents[0].componentInstance;
       const draggedChipElem = draggedChip.nativeElement;
 
-      expect(draggedChip.draggable).toBeFalse();
+      expect(draggedChip.draggable).toBeTrue();
       UIInteractions.moveDragDirective(fix, draggedChip.dragDirective, 0, draggedChipElem.offsetHeight, false);
-      expect(QueryBuilderFunctions.getDropGhost(fix)).toBe(null);
+      expect(QueryBuilderFunctions.getDropGhost(fix)).not.toBe(null);
     });
 
     it('should allow dragging a sub-query condition while a sub-query is expanded.', () => {