Merge pull request #9299 from IgniteUI/some-lint-fixes

Some lint fixes

Author: zdrawku

projects/igniteui-angular/src/lib/checkbox/checkbox.component.spec.ts

@@ -381,15 +381,15 @@ class CheckboxReadonlyComponent {
 })
 class CheckboxExternalLabelComponent {
     @ViewChild('cb', { static: true }) public cb: IgxCheckboxComponent;
-    label = 'My Label';
+    public label = 'My Label';
 }
 
 @Component({
     template: `<igx-checkbox #cb [aria-label]="label"></igx-checkbox>`
 })
 class CheckboxInvisibleLabelComponent {
     @ViewChild('cb', { static: true }) public cb: IgxCheckboxComponent;
-    label = 'Invisible Label';
+    public label = 'Invisible Label';
 }
 
 @Component({

projects/igniteui-angular/src/lib/expansion-panel/expansion-panel.component.ts

@@ -168,7 +168,7 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
     constructor(private cdr: ChangeDetectorRef, private builder: AnimationBuilder) { }
 
     /** @hidden */
-    ngAfterContentInit(): void {
+    public ngAfterContentInit(): void {
         if (this.body && this.header) {
             // schedule at end of turn:
             Promise.resolve().then(() => {
@@ -188,7 +188,7 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
      *  <button (click)="myPanel.collapse($event)">Collpase Panel</button>
      * ```
      */
-    collapse(evt?: Event) {
+    public collapse(evt?: Event) {
         if (this.collapsed) { // If expansion panel is already collapsed, do nothing
             return;
         }
@@ -211,7 +211,7 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
      *  <button (click)="myPanel.expand($event)">Expand Panel</button>
      * ```
      */
-    expand(evt?: Event) {
+    public expand(evt?: Event) {
         if (!this.collapsed) { // If the panel is already opened, do nothing
             return;
         }
@@ -234,18 +234,18 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
      *  <button (click)="myPanel.toggle($event)">Expand Panel</button>
      * ```
      */
-    toggle(evt?: Event) {
+    public toggle(evt?: Event) {
         if (this.collapsed) {
             this.open(evt);
         } else {
             this.close(evt);
         }
     }
 
-    open(evt?: Event) {
+    public open(evt?: Event) {
         this.expand(evt);
     }
-    close(evt?: Event) {
+    public close(evt?: Event) {
         this.collapse(evt);
     }
 

projects/igniteui-angular/src/lib/input-group/input-group.common.ts

@@ -1,7 +1,7 @@
 /** @hidden */
 export abstract class IgxInputGroupBase {
-    disabled: boolean;
-    isFocused: boolean;
-    isRequired: boolean;
-    hasPlaceholder: boolean;
+    public disabled: boolean;
+    public isFocused: boolean;
+    public isRequired: boolean;
+    public hasPlaceholder: boolean;
 }

projects/igniteui-angular/src/lib/services/excel/excel-exporter-grid.spec.ts

@@ -413,10 +413,10 @@ describe('Excel Exporter', () => {
             const sortField = grid.sortingExpressions[0].fieldName;
             fix.detectChanges();
 
-            let wrapper = await getExportedData(grid, options);
+            await getExportedData(grid, options);
             fix.detectChanges();
 
-            wrapper = await getExportedData(grid, options);
+            await getExportedData(grid, options);
             const sortFieldAfterExport = grid.sortingExpressions[0].fieldName;
             expect(sortField).toBe(sortFieldAfterExport);
         });

projects/igniteui-angular/src/lib/services/transaction/base-transaction.ts

@@ -47,24 +47,24 @@ export class IgxBaseTransactionService<T extends Transaction, S extends State> i
     /**
      * @inheritdoc
      */
-    getTransactionLog(id?: any): T[] {
- return [];
-}
+    public getTransactionLog(_id?: any): T[] {
+        return [];
+    }
 
     /**
      * @inheritdoc
      */
-    undo(): void { }
+    public undo(): void { }
 
     /**
      * @inheritdoc
      */
-    redo(): void { }
+    public redo(): void { }
 
     /**
      * @inheritdoc
      */
-    getAggregatedChanges(mergeChanges: boolean): T[] {
+    public getAggregatedChanges(mergeChanges: boolean): T[] {
         const result: T[] = [];
         this._pendingStates.forEach((state: S, key: any) => {
             const value = mergeChanges ? this.getAggregatedValue(key, mergeChanges) : state.value;
@@ -97,12 +97,12 @@ export class IgxBaseTransactionService<T extends Transaction, S extends State> i
     /**
      * @inheritdoc
      */
-    commit(data: any[], id?: any): void { }
+    public commit(_data: any[], _id?: any): void { }
 
     /**
      * @inheritdoc
      */
-    clear(id?: any): void {
+    public clear(_id?: any): void {
         this._pendingStates.clear();
         this._pendingTransactions = [];
     }
@@ -117,7 +117,7 @@ export class IgxBaseTransactionService<T extends Transaction, S extends State> i
     /**
      * @inheritdoc
      */
-    public endPending(commit: boolean): void {
+    public endPending(_commit: boolean): void {
         this._isPending = false;
         this._pendingStates.clear();
         this._pendingTransactions = [];

projects/igniteui-angular/src/lib/services/transaction/igx-transaction.spec.ts

@@ -480,7 +480,6 @@ describe('IgxTransaction', () => {
         });
 
         it('Should properly confirm the length of the undo/redo stacks', () => {
-            const originalData = SampleTestData.generateProductData(11);
             const transaction = new IgxTransactionService();
             expect(transaction).toBeDefined();
 

projects/igniteui-angular/src/lib/services/transaction/igx-transaction.ts

@@ -18,14 +18,14 @@ export class IgxTransactionService<T extends Transaction, S extends State> exten
     /**
      * @inheritdoc
      */
-    get canUndo(): boolean {
+    public get canUndo(): boolean {
         return this._undoStack.length > 0;
     }
 
     /**
      * @inheritdoc
      */
-    get canRedo(): boolean {
+    public get canRedo(): boolean {
         return this._redoStack.length > 0;
     }
 

projects/igniteui-angular/src/lib/snackbar/snackbar.component.spec.ts

@@ -104,12 +104,11 @@ describe('IgxSnackbar with custom content', () => {
         }).compileComponents();
     }));
 
-    let fixture; let domSnackbar; let snackbar;
+    let fixture; let snackbar;
     beforeEach(waitForAsync(() => {
         fixture = TestBed.createComponent(SnackbarCustomContentComponent);
         fixture.detectChanges();
         snackbar = fixture.componentInstance.snackbar;
-        domSnackbar = fixture.debugElement.query(By.css('igx-snackbar')).nativeElement;
     }));
 
     it('should display a message, a custom content element and a button', () => {

projects/igniteui-angular/src/lib/splitter/splitter-pane/splitter-pane.component.ts

@@ -1,5 +1,4 @@
 import { Component, HostBinding, Input, ElementRef, Output, EventEmitter } from '@angular/core';
-import { DeprecateProperty } from '../../core/deprecateDecorators';
 
 /**
  * Represents individual resizable/collapsible panes.