Skip to content

Commit 0d7e03a

Browse files
wnvkoLipata
authored andcommitted
fix(grid): call notifyChanges in updateRow instead of detectChanges #5934 (#6018)
1 parent b9ad6fc commit 0d7e03a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.component.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3940,7 +3940,13 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
39403940
}
39413941
const row = new IgxRow(rowSelector, -1, this.gridAPI.getRowData(rowSelector));
39423942
this.gridAPI.update_row(row, value);
3943-
this.cdr.detectChanges();
3943+
3944+
// TODO: fix for #5934 and probably break for #5763
3945+
// consider adding of third optional boolean parameter in updateRow.
3946+
// If developer set this parameter to true we should call notifyChanges(true), and
3947+
// vise-versa if developer set it to false we should call notifyChanges(false).
3948+
// The parameter should default to false
3949+
this.notifyChanges();
39443950
}
39453951
}
39463952

0 commit comments

Comments
 (0)