Merge pull request #7193 from IgniteUI/mdragnev/remove-deprecated-props

fix(*): Remove deprecated properties #7053

Author: ChronosSF

projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts

@@ -543,58 +543,12 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
     @Input()
     public outlet: IgxOverlayOutletDirective | ElementRef;
 
-    /**
-     * @deprecated Use 'onOpened' instead.
-     * An event that is emitted when the `IgxDatePickerComponent` calendar is opened.
-     *  @example
-     * ```typescript
-     * public open(event){
-     *     alert("The date-picker calendar has been opened!");
-     * }
-     * ```
-     * ```html
-     * <igx-date-picker (onOpen)="open($event)" cancelButtonLabel="cancel" todayButtonLabel="today"></igx-date-picker>
-     * ```
-     */
-    @DeprecateProperty(`'onOpen' @Output property is deprecated. Use 'onOpened' instead.`)
-    @Output()
-    public get onOpen(): EventEmitter<IgxDatePickerComponent> {
-        return this._onOpen;
-    }
-
-    public set onOpen(val: EventEmitter<IgxDatePickerComponent>) {
-        this._onOpen = val;
-    }
-
     /**
      * Emitted when the `IgxDatePickerComponent` calendar is opened.
      */
     @Output()
     public onOpened = new EventEmitter<IgxDatePickerComponent>();
 
-    /**
-     * @deprecated Use 'onClosed' instead.
-     * "An event that is emitted when the `IgxDatePickerComponent` is closed.
-     *  @example
-     * ```typescript
-     * public close(event){
-     *     alert("The date-picker has been closed!");
-     * }
-     * ```
-     * ```html
-     * <igx-date-picker (onClose)="close($event)" cancelButtonLabel="cancel" todayButtonLabel="today"></igx-date-picker>
-     * ```
-     */
-    @DeprecateProperty(`'onClose' @Output property is deprecated. Use 'onClosed' instead.`)
-    @Output()
-    public get onClose(): EventEmitter<IgxDatePickerComponent> {
-        return this._onClose;
-    }
-
-    public set onClose(val: EventEmitter<IgxDatePickerComponent>) {
-        this._onClose = val;
-    }
-
     /**
      * Emitted after the `IgxDatePickerComponent` is closed.
      */
@@ -1238,9 +1192,6 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
     private _onOpened(): void {
         this.onOpened.emit(this);
 
-        // TODO: remove this line after deprecating 'onOpen'
-        this._onOpen.emit(this);
-
         if (this.calendar) {
             this._focusCalendarDate();
         }
@@ -1250,9 +1201,6 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
         this.collapsed = true;
         this._componentID = null;
         this.onClosed.emit(this);
-
-        // TODO: remove this line after deprecating 'onClose'
-        this.onClose.emit(this);
     }
 
     private _initializeCalendarContainer(componentInstance: IgxCalendarContainerComponent) {

projects/igniteui-angular/src/lib/directives/text-highlight/text-highlight.directive.ts

@@ -27,18 +27,6 @@ interface ISearchInfo {
  * An interface describing information for the active highlight.
  */
 export interface IActiveHighlightInfo {
-    /**
-     * The row index of the highlight. This property is deprecated, use `row` instead.
-     */
-    rowIndex?: number;
-    /**
-     * The column index of the highlight. This property is deprecated, use `column` instead.
-     */
-    columnIndex?: number;
-    /**
-     * The page index of the highlight. This property is deprecated.
-     */
-    page?: number;
     /**
      * The row of the highlight.
      */
@@ -175,10 +163,6 @@ export class IgxTextHighlightDirective implements AfterViewInit, AfterViewChecke
     @Input('column')
     public column: any;
 
-    @Input('page')
-    @DeprecateProperty(`IgxTextHighlightDirective 'page' input property is deprecated.`)
-    public page: number;
-
     /**
      * @hidden
      */
@@ -328,14 +312,12 @@ export class IgxTextHighlightDirective implements AfterViewInit, AfterViewChecke
     }
 
     /**
-     * Activates the highlight if it is on the currently active row, column and page.
+     * Activates the highlight if it is on the currently active row and column.
      */
     public activateIfNecessary(): void {
         const group = IgxTextHighlightDirective.highlightGroupsMap.get(this.groupName);
-        const column = group.columnIndex === undefined ? group.column : group.columnIndex;
-        const row = group.rowIndex === undefined ? group.row : group.rowIndex;
 
-        if (column === this.column && row === this.row && group.page === this.page) {
+        if (group.column === this.column && group.row === this.row) {
             this.activate(group.index);
         }
     }

projects/igniteui-angular/src/lib/drop-down/drop-down-item.base.ts

@@ -152,23 +152,6 @@ export class IgxDropDownItemBaseDirective implements DoCheck {
     @Output()
     public selectedChange = new EventEmitter<boolean>();
 
-    /**
-     * @hidden @internal
-     */
-    @Input()
-    @DeprecateProperty(`IgxDropDownItemBaseDirective \`isSelected\` property is deprecated.\n` +
-        `Use \`selected\` instead.`)
-    get isSelected(): boolean {
-        return this.selected;
-    }
-
-    /**
-     * @hidden @internal
-     */
-    set isSelected(value: boolean) {
-        this.selected = value;
-    }
-
     /**
      * Sets/gets if the given item is focused
      * ```typescript
@@ -194,21 +177,6 @@ export class IgxDropDownItemBaseDirective implements DoCheck {
         this._focused = value;
     }
 
-    /**
-     * @hidden @internal
-     */
-    @DeprecateProperty(`IgxDropDownItemBaseDirective \`isFocused\` property is depracated.\n` +
-        `Use \`focused\` instead.`)
-    get isFocused(): boolean {
-        return this.focused;
-    }
-    /**
-     * @hidden @internal
-     */
-    set isFocused(value: boolean) {
-        this.focused = value;
-    }
-
     /**
      * Sets/gets if the given item is header
      * ```typescript

projects/igniteui-angular/src/lib/grids/cell.component.ts

@@ -296,26 +296,6 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {
         return this.element.nativeElement;
     }
 
-    /**
-     * @deprecated
-     * Use `cell.editMode` as a getter and
-     * `cell.setEditMode(true | false)` to start/exit edit mode.
-     *
-     * Gets/sets whether the cell is in edit mode.
-     * ```typescript
-     * let isCellInEditMode = this.cell.inEditMode;
-     * ```
-     * @memberof IgxGridCellComponent
-     */
-    @DeprecateProperty(`'inEditMode' is deprecated\nUse 'editMode' to get the current state and 'setEditMode(boolean)' as a setter`)
-    get inEditMode(): boolean {
-        return this.editMode;
-    }
-
-    set inEditMode(value: boolean) {
-        this.setEditMode(value);
-    }
-
     /**
      * @hidden
      * @internal

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

@@ -654,19 +654,6 @@ export class IgxColumnComponent implements AfterContentInit {
     @Output()
     public pinnedChange = new EventEmitter<boolean>();
 
-    /**
-     * @deprecated
-     * Gets/Sets the `id` of the `igx-grid`.
-     * ```typescript
-     * let columnGridId = this.column.gridID;
-     * ```
-     * ```typescript
-     * this.column.gridID = 'grid-1';
-     * ```
-     * @memberof IgxColumnComponent
-     */
-    @DeprecateProperty(`The property is deprecated. Please, use \`column.grid.id\` instead.`)
-    public gridID: string;
     /**
      * Gets the column `summaries`.
      * ```typescript

projects/igniteui-angular/src/lib/grids/filtering/base/grid-filtering-row.component.html

@@ -47,7 +47,7 @@
         [outlet]="filteringService.grid.outletDirective"
         [locale]="filteringService.grid.locale"
         (onSelection)="onDateSelected($event)"
-        (onClose)="datePickerClose()">
+        (onClosed)="datePickerClose()">
         <ng-template igxDatePickerTemplate let-openDialog="openDialog">
             <igx-input-group #inputGroup type="box" [displayDensity]="'compact'" (focusout)="onInputGroupFocusout()">
                 <igx-prefix #inputGroupPrefix

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -526,17 +526,6 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
         }
     }
 
-    @DeprecateProperty('rowSelectable property is deprecated. Use rowSelection property instead.')
-    @WatchChanges()
-    @Input()
-    get rowSelectable(): boolean {
-        return this.isRowSelectable;
-    }
-
-    set rowSelectable(val: boolean) {
-        this.rowSelection = val ? GridSelectionMode.multiple : GridSelectionMode.none;
-    }
-
     /**
      * Gets/Sets if the row selectors are hidden.
      * @remarks

projects/igniteui-angular/src/lib/grids/grid/grid.master-detail.spec.ts

@@ -13,7 +13,7 @@ import { IgxGridExpandableCellComponent } from './expandable-cell.component';
 import { SortingDirection } from '../../data-operations/sorting-expression.interface';
 import { IgxStringFilteringOperand } from '../../data-operations/filtering-condition';
 import { IgxInputGroupComponent } from '../../input-group';
-import { GridSummaryCalculationMode, GridSummaryPosition } from '../common/enums';
+import { GridSummaryCalculationMode, GridSummaryPosition, GridSelectionMode } from '../common/enums';
 import { IgxCheckboxComponent } from '../../checkbox/checkbox.component';
 
 const DEBOUNCETIME = 30;
@@ -1168,7 +1168,7 @@ describe('IgxGrid Master Detail #grid', () => {
 @Component({
     template: `
         <igx-grid [data]="data" [width]="width" [height]="height" [primaryKey]="'ID'" [allowFiltering]='true'
-        [paging]="paging" [perPage]="perPage" [rowSelectable]="rowSelectable">
+        [paging]="paging" [perPage]="perPage" [rowSelection]="rowSelectable">
             <igx-column *ngFor="let c of columns" [field]="c.field" [header]="c.field" [width]="c.width" [dataType]='c.dataType'
                 [hidden]='c.hidden' [sortable]="c.sortable" [movable]='c.movable' [groupable]='c.groupable' [editable]="c.editable"
                 [hasSummary]="c.hasSummary" [pinned]='c.pinned'>
@@ -1200,7 +1200,7 @@ export class DefaultGridMasterDetailComponent {
     ];
     public paging = false;
     public perPage = 15;
-    public rowSelectable = false;
+    public rowSelectable = GridSelectionMode.none;
 
     @ViewChild(IgxGridComponent, { read: IgxGridComponent, static: true })
     public grid: IgxGridComponent;
@@ -1209,7 +1209,7 @@ export class DefaultGridMasterDetailComponent {
 @Component({
     template: `
         <igx-grid [data]="data" [expansionStates]='expStates'
-         [width]="width" [height]="height" [primaryKey]="'ID'" [paging]="paging" [rowSelectable]="rowSelectable">
+         [width]="width" [height]="height" [primaryKey]="'ID'" [paging]="paging" [rowSelection]="rowSelectable">
             <igx-column *ngFor="let c of columns" [field]="c.field" [header]="c.field" [width]="c.width" [dataType]='c.dataType'
                 [hidden]='c.hidden' [sortable]="c.sortable" [movable]='c.movable' [groupable]='c.groupable' [editable]="c.editable"
                 [hasSummary]="c.hasSummary" [pinned]='c.pinned'>
@@ -1242,7 +1242,7 @@ export class AllExpandedGridMasterDetailComponent extends DefaultGridMasterDetai
 @Component({
     template: `
         <igx-grid [data]="data"
-         [width]="width" [height]="height" [primaryKey]="'ID'" [paging]="paging" [rowSelectable]="rowSelectable">
+         [width]="width" [height]="height" [primaryKey]="'ID'" [paging]="paging" [rowSelection]="rowSelectable">
         <igx-column-layout field='group2'>
             <igx-column [rowStart]="1" [colStart]="1" [colEnd]="3" field="CompanyName" [width]="'300px'"></igx-column>
             <igx-column [rowStart]="2" [colStart]="1" field="ContactName" [width]="'100px'"></igx-column>

projects/igniteui-angular/src/lib/grids/grid/grid.pinning.spec.ts

@@ -5,7 +5,7 @@ import { SortingDirection } from '../../data-operations/sorting-expression.inter
 import { IgxGridModule } from './index';
 import { IgxStringFilteringOperand } from '../../data-operations/filtering-condition';
 import { configureTestSuite } from '../../test-utils/configure-suite';
-import { ColumnPinningPosition } from '../common/enums';
+import { ColumnPinningPosition, GridSelectionMode } from '../common/enums';
 import { IPinningConfig } from '../common/grid.interface';
 import { wait, UIInteractions } from '../../test-utils/ui-interactions.spec';
 import { GridSummaryFunctions,
@@ -553,7 +553,7 @@ describe('IgxGrid - Column Pinning #grid', () => {
             });
 
             it('should correctly pin column to right when row selectors are enabled.', () => {
-                grid.rowSelectable = true;
+                grid.rowSelection =  GridSelectionMode.multiple;
                 fix.detectChanges();
 
                 // check row DOM

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

@@ -111,42 +111,6 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
         return this._data;
     }
 
-    /**
-     * @hidden
-     * @deprecated
-     * Sets the state of the `IgxHierarchicalGridComponent` containing which rows are expanded.
-     */
-    @Input()
-    @DeprecateProperty(`'hierarchicalState' property is deprecated. Use 'expansionStates' instead.`)
-    public get hierarchicalState() {
-        const res = Array.from(this.expansionStates.entries()).filter(({1: v}) => v === true).map(([k]) => k);
-        return res;
-    }
-    public set hierarchicalState(val) {
-        if (this.hasChildrenKey) {
-            val = val.filter(item => {
-                const rec = this.primaryKey ? this.data.find(x => x[this.primaryKey] === item.rowID) : item.rowID;
-                return rec[this.hasChildrenKey];
-            });
-        }
-        const expansionStates = new Map<any, boolean>();
-        val.forEach(item => {
-            const rec = this.primaryKey ? this.data.find(x => x[this.primaryKey] === item.rowID) : item.rowID;
-            expansionStates.set(rec, true);
-        });
-        this.expansionStates = expansionStates;
-        if (this.parent) {
-            this.notifyChanges(true);
-        }
-    }
-
-    /**
-     * @hidden
-     * @deprecated
-     */
-    @Output()
-    @DeprecateProperty(`'hierarchicalStateChange' @Output property is deprecated. Use 'expansionStates' instead.`)
-    public hierarchicalStateChange = new EventEmitter<any>();
 
     /**
      * Sets an array of objects containing the filtered data in the `IgxHierarchicalGridComponent`.
@@ -293,7 +257,6 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
         }
         this.expansionStatesChange.pipe(takeUntil(this.destroy$)).subscribe((value: Map<any, boolean>) => {
             const res = Array.from(value.entries()).filter(({1: v}) => v === true).map(([k]) => k);
-            this.hierarchicalStateChange.emit(res);
         });
         super.ngOnInit();
     }