Skip to content

Commit 10287a9

Browse files
authored
Merge branch 'master' into ikitanov/fix-16091
2 parents 8c36106 + dd5ba17 commit 10287a9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+635
-93
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ In order for us to verify your eligibility for free usage, please [register for
337337

338338
To acquire a license for commercial usage, please [register for trial](https://Infragistics.com/Angular) and refer to the purchasing options in the pricing section on the product page.
339339

340-
© Copyright 2020 INFRAGISTICS. All Rights Reserved.
340+
© Copyright 2025 INFRAGISTICS. All Rights Reserved.
341341
The Infragistics Ultimate license & copyright applies to this distribution.
342342
For information on that license, please go to our website [https://www.infragistics.com/legal/license](https://www.infragistics.com/legal/license).
343343

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"@types/source-map": "0.5.2",
7575
"express": "^5.1.0",
7676
"fflate": "^0.8.1",
77-
"igniteui-theming": "^19.2.1",
77+
"igniteui-theming": "^19.2.3",
7878
"igniteui-trial-watermark": "^3.1.0",
7979
"lodash-es": "^4.17.21",
8080
"rxjs": "^7.8.2",

projects/igniteui-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"tslib": "^2.3.0",
7474
"igniteui-trial-watermark": "^3.1.0",
7575
"lodash-es": "^4.17.21",
76-
"igniteui-theming": "^19.2.1",
76+
"igniteui-theming": "^19.2.3",
7777
"@igniteui/material-icons-extended": "^3.1.0"
7878
},
7979
"peerDependencies": {

projects/igniteui-angular/src/lib/core/styles/components/switch/_switch-theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132

133133
@if $variant != 'material' {
134134
%switch-thumb {
135-
background: var-get($theme, 'border-hover-color');
135+
background: var-get($theme, 'thumb-off-hover-color');
136136
}
137137

138138
%switch-thumb--x {

projects/igniteui-angular/src/lib/core/styles/themes/_core.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
// Used to configure color accessibility for charts
99
@use 'igniteui-theming/sass/color/functions' as color;
10+
@use 'igniteui-theming/sass/themes/mixins' as theming;
1011

1112
// Common components
1213
@use '../components/_common/igx-control';
@@ -113,6 +114,8 @@
113114
}
114115
}
115116

117+
@include theming.spacing();
118+
116119
@property --_progress-integer {
117120
syntax: '<integer>';
118121
initial-value: 0;

projects/igniteui-angular/src/lib/core/styles/themes/generators/_base.scss

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,18 +84,6 @@
8484
--ig-size-small: 1;
8585
--ig-size-medium: 2;
8686
--ig-size-large: 3;
87-
88-
--ig-spacing-small: 1;
89-
--ig-spacing-medium: 1;
90-
--ig-spacing-large: 1;
91-
92-
--ig-spacing-inline-small: 1;
93-
--ig-spacing-inline-medium: 1;
94-
--ig-spacing-inline-large: 1;
95-
96-
--ig-spacing-block-small: 1;
97-
--ig-spacing-block-medium: 1;
98-
--ig-spacing-block-large: 1;
9987
}
10088

10189
@if not(list.index($exclude, 'palette')) {

projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.spec.ts

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { DebugElement } from '@angular/core';
22
import { fakeAsync, TestBed, tick, flush, waitForAsync, ComponentFixture } from '@angular/core/testing';
33
import { By } from '@angular/platform-browser';
44
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
5-
import { IgxTooltipSingleTargetComponent, IgxTooltipMultipleTargetsComponent, IgxTooltipPlainStringComponent, IgxTooltipWithToggleActionComponent } from '../../test-utils/tooltip-components.spec';
5+
import { IgxTooltipSingleTargetComponent, IgxTooltipMultipleTargetsComponent, IgxTooltipPlainStringComponent, IgxTooltipWithToggleActionComponent, IgxTooltipMultipleTooltipsComponent } from '../../test-utils/tooltip-components.spec';
66
import { UIInteractions } from '../../test-utils/ui-interactions.spec';
77
import { HorizontalAlignment, VerticalAlignment, AutoPositionStrategy } from '../../services/public_api';
88
import { IgxTooltipDirective } from './tooltip.directive';
@@ -621,6 +621,36 @@ describe('IgxTooltip', () => {
621621
}));
622622
});
623623

624+
describe('Multiple tooltips', () => {
625+
let targetOne: IgxTooltipTargetDirective;
626+
627+
let tooltipOne: IgxTooltipDirective;
628+
let tooltipTwo: IgxTooltipDirective;
629+
630+
beforeEach(waitForAsync(() => {
631+
fix = TestBed.createComponent(IgxTooltipMultipleTooltipsComponent);
632+
fix.detectChanges();
633+
targetOne = fix.componentInstance.targetOne;
634+
tooltipOne = fix.componentInstance.tooltipOne;
635+
tooltipTwo = fix.componentInstance.tooltipTwo;
636+
}));
637+
638+
it('should not add multiple document:touchstart event listeners when having multiple igxTooltip instances - #16100', fakeAsync(() => {
639+
spyOn<any>(tooltipOne, 'onDocumentTouchStart').and.callThrough();
640+
spyOn<any>(tooltipTwo, 'onDocumentTouchStart').and.callThrough();
641+
642+
touchElement(targetOne);
643+
tick(500);
644+
645+
const dummyDiv = fix.debugElement.query(By.css('.dummyDiv'));
646+
touchElement(dummyDiv);
647+
flush();
648+
649+
expect(tooltipOne['onDocumentTouchStart']).toHaveBeenCalledTimes(1);
650+
expect(tooltipTwo['onDocumentTouchStart']).not.toHaveBeenCalled();
651+
}));
652+
});
653+
624654
describe('Tooltip integration', () => {
625655
beforeEach(waitForAsync(() => {
626656
fix = TestBed.createComponent(IgxTooltipWithToggleActionComponent);

projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,10 @@ export class IgxTooltipDirective extends IgxToggleDirective implements OnDestroy
122122
super(elementRef, cdr, overlayService, navigationService);
123123

124124
this.onDocumentTouchStart = this.onDocumentTouchStart.bind(this);
125-
this.overlayService.opening.pipe(takeUntil(this._destroy$)).subscribe(() => {
125+
this.opening.pipe(takeUntil(this._destroy$)).subscribe(() => {
126126
this._document.addEventListener('touchstart', this.onDocumentTouchStart, { passive: true });
127127
});
128-
this.overlayService.closed.pipe(takeUntil(this._destroy$)).subscribe(() => {
128+
this.closed.pipe(takeUntil(this._destroy$)).subscribe(() => {
129129
this._document.removeEventListener('touchstart', this.onDocumentTouchStart);
130130
});
131131
}

projects/igniteui-angular/src/lib/grids/cell.component.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -519,11 +519,7 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy, CellT
519519
/** @hidden @internal */
520520
@HostBinding('attr.aria-describedby')
521521
public get ariaDescribeBy() {
522-
let describeBy = (this.gridID + '_' + this.column.field).replace('.', '_');
523-
if (this.isInvalid) {
524-
describeBy += ' ' + this.ariaErrorMessage;
525-
}
526-
return describeBy;
522+
return this.isInvalid ? this.ariaErrorMessage : null;
527523
}
528524

529525
/** @hidden @internal */
@@ -707,6 +703,17 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy, CellT
707703
}
708704
}
709705

706+
@HostBinding('attr.aria-rowindex')
707+
protected get ariaRowIndex(): number {
708+
// +2 because aria-rowindex is 1-based and the first row is the header
709+
return this.rowIndex + 2;
710+
}
711+
712+
@HostBinding('attr.aria-colindex')
713+
protected get ariaColIndex(): number {
714+
return this.column.index + 1;
715+
}
716+
710717
@ViewChild('defaultCell', { read: TemplateRef, static: true })
711718
protected defaultCellTemplate: TemplateRef<any>;
712719

0 commit comments

Comments
 (0)