Skip to content

Commit 130853a

Browse files
authored
Merge branch '9.0.x' into reset-scrollAmount-90x
2 parents dba3ea1 + 48967e2 commit 130853a

File tree

7 files changed

+1448
-2466
lines changed

7 files changed

+1448
-2466
lines changed

projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_toast.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ $_bootstrap-toast: extend(
5656
(
5757
variant: 'bootstrap',
5858
background: #fff,
59+
60+
text-color: (
61+
igx-color: ('grays', 600)
62+
)
5963
)
6064
);
6165

projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts

Lines changed: 1073 additions & 1907 deletions
Large diffs are not rendered by default.

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2430,6 +2430,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
24302430
private _unpinnedWidth = NaN;
24312431
private _visibleColumns = [];
24322432
private _columnGroups = false;
2433+
private _autoGeneratedCols = [];
24332434
protected _headerFeaturesWidth = NaN;
24342435

24352436
private _columnWidth: string;
@@ -4497,6 +4498,12 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
44974498
*/
44984499
protected onColumnsChanged(change: QueryList<IgxColumnComponent>) {
44994500
const diff = this.columnListDiffer.diff(change);
4501+
if (this.autoGenerate && this.columnList.length === 0 && this._autoGeneratedCols.length > 0) {
4502+
// In Ivy if there are nested conditional templates the content children are re-evaluated
4503+
// hence autogenerated columns are cleared and need to be reset.
4504+
this.columnList.reset(this._autoGeneratedCols);
4505+
return;
4506+
}
45004507
if (diff) {
45014508
let added = false;
45024509
let removed = false;
@@ -4720,6 +4727,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
47204727
ref.changeDetectorRef.detectChanges();
47214728
columns.push(ref.instance);
47224729
});
4730+
this._autoGeneratedCols = columns;
47234731

47244732
this.columnList.reset(columns);
47254733
if (data && data.length > 0) {

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-advanced.spec.ts

Lines changed: 356 additions & 556 deletions
Large diffs are not rendered by default.

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
417417
protected onColumnsChanged(change: QueryList<IgxColumnComponent>) {
418418
this.updateColumnList();
419419
const cols = change.filter(c => c.gridAPI.grid === this);
420-
if (cols.length > 0) {
420+
if (cols.length > 0 || this.autoGenerate) {
421421
this.columnList.reset(cols);
422422
super.onColumnsChanged(this.columnList);
423423
}

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,8 +1080,7 @@ describe('IgxHierarchicalGrid Runtime Row Island change Scenarios #hGrid', () =>
10801080
hierarchicalGrid = fixture.componentInstance.hgrid;
10811081
}));
10821082

1083-
xit('should allow changing row islands runtime in root grid.', () => {
1084-
pending('Related to issue #6731');
1083+
it('should allow changing row islands runtime in root grid.', () => {
10851084
const row = hierarchicalGrid.getRowByIndex(0) as IgxHierarchicalRowComponent;
10861085
UIInteractions.clickElement(row.expander);
10871086
fixture.detectChanges();

projects/igniteui-angular/src/lib/test-utils/grid-functions.spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1472,6 +1472,11 @@ export class GridFunctions {
14721472
return initialButtons;
14731473
}
14741474

1475+
public static clickAdvancedFilteringInitialAddGroupButton(fix: ComponentFixture<any>, buttonIndex: number) {
1476+
const addAndGroupButton = this.getAdvancedFilteringInitialAddGroupButtons(fix)[buttonIndex];
1477+
addAndGroupButton.click();
1478+
}
1479+
14751480
public static getAdvancedFilteringContextMenu(fix: ComponentFixture<any>) {
14761481
const gridNativeElement = fix.debugElement.query(By.css('igx-grid')).nativeElement;
14771482
const contextMenu = gridNativeElement.querySelector('.igx-filter-contextual-menu');

0 commit comments

Comments
 (0)