chore(*): Move logic to column actions as hiding/pinning directives already have function that determines if col should appear in ui - actionEnabledColumnsFilter. Same can be re-used to track potential changes.

Author: MKirova

projects/igniteui-angular/src/lib/grids/column-actions/column-actions-base.directive.ts

@@ -23,11 +23,6 @@ export abstract class IgxColumnActionsBaseDirective {
      */
     public uncheckAllLabel: string;
 
-    /**
-     * @hidden @internal
-     */
-    public trackChanges: Function;
-
     /**
      * @hidden @internal
      */

projects/igniteui-angular/src/lib/grids/column-actions/column-actions.component.ts

@@ -6,11 +6,9 @@ import {
     QueryList,
     EventEmitter,
     Output,
-    AfterViewInit,
     IterableDiffers,
     IterableDiffer,
-    DoCheck,
-    OnInit
+    DoCheck
 } from '@angular/core';
 import { IgxColumnComponent } from '../columns/column.component';
 import { ColumnDisplayOrder } from '../common/enums';
@@ -31,10 +29,11 @@ let NEXT_ID = 0;
     selector: 'igx-column-actions',
     templateUrl: './column-actions.component.html'
 })
-export class IgxColumnActionsComponent implements DoCheck, OnInit {
+export class IgxColumnActionsComponent implements DoCheck {
     protected _differ: IterableDiffer<any> | null = null;
 
     constructor (private differs: IterableDiffers) {
+        this._differ = this.differs.find([]).create(this.trackChanges);
     }
 
     /**
@@ -360,7 +359,7 @@ export class IgxColumnActionsComponent implements DoCheck, OnInit {
      * @hidden @internal
      */
     public trackChanges = (index, col) => {
-        return col.field;
+        return col.field + '_' + this.actionsDirective.actionEnabledColumnsFilter(col, index, []);
     }
 
     /**
@@ -375,13 +374,6 @@ export class IgxColumnActionsComponent implements DoCheck, OnInit {
         }
     }
 
-    /**
-     * @hidden @internal
-     */
-    ngOnInit() {
-        this._differ = this.differs.find([]).create(this.trackChanges);
-    }
-
     /**
      * Unchecks all columns and performs the appropriate action.
      * @example

projects/igniteui-angular/src/lib/grids/column-actions/column-hiding.directive.ts

@@ -13,7 +13,6 @@ export class IgxColumnHidingDirective extends IgxColumnActionsBaseDirective {
     ) {
         super();
         columnActions.actionsDirective = this;
-        columnActions.trackChanges = this.trackColumnChanges;
     }
 
     /**
@@ -52,13 +51,6 @@ export class IgxColumnHidingDirective extends IgxColumnActionsBaseDirective {
         return column.hidden;
     }
 
-    /**
-     * @hidden @internal
-     */
-    trackColumnChanges = (index, col) => {
-        return col.field + '_' + col.disableHiding;
-    }
-
     /**
      * @hidden @internal
      */

projects/igniteui-angular/src/lib/grids/column-actions/column-pinning.directive.ts

@@ -13,7 +13,6 @@ export class IgxColumnPinningDirective extends IgxColumnActionsBaseDirective {
     ) {
         super();
         columnActions.actionsDirective = this;
-        columnActions.trackChanges = this.trackColumnChanges;
     }
 
     /**
@@ -52,13 +51,6 @@ export class IgxColumnPinningDirective extends IgxColumnActionsBaseDirective {
         return column.pinned;
     }
 
-    /**
-     * @hidden @internal
-     */
-    trackColumnChanges = (index, col) => {
-        return col.field + '_' + col.disablePinning;
-    }
-
     /**
      * @hidden @internal
      */