Skip to content

Commit 1c325d7

Browse files
committed
refactor(grid): locale/pipeArgs improvements #8195
1 parent 54e27fe commit 1c325d7

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,8 +1207,7 @@ export class IgxColumnComponent implements AfterContentInit {
12071207
this._pipeArgs = Object.assign(this._pipeArgs, value);
12081208
this.grid.summaryService.clearSummaryCache();
12091209
(this.grid as any)._pipeTrigger++;
1210-
this.grid.summaryService.retriggerRootPipe++;
1211-
this.grid.notifyChanges(true);
1210+
this.grid.notifyChanges();
12121211
}
12131212
get pipeArgs(): IColumnPipeArgs {
12141213
return this._pipeArgs;

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
425425
this._locale = value;
426426
this.summaryService.clearSummaryCache();
427427
this._pipeTrigger++;
428-
this.summaryService.retriggerRootPipe++;
429-
this.notifyChanges(true);
428+
this.notifyChanges();
430429
}
431430

432431
@Input()

projects/igniteui-angular/src/lib/grids/summaries/grid-summary.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class IgxSummaryOperand {
6262
* ```
6363
* @memberof IgxSummaryOperand
6464
*/
65-
public operate(data: any[] = [], allData: any[] = [], fieldName?: string, locale: string = 'en'): IgxSummaryResult[] {
65+
public operate(data: any[] = [], allData: any[] = [], fieldName?: string, locale: string = 'en-US'): IgxSummaryResult[] {
6666
const pipe = new DecimalPipe(locale);
6767
return [{
6868
key: 'count',
@@ -152,7 +152,7 @@ export class IgxNumberSummaryOperand extends IgxSummaryOperand {
152152
* ```
153153
* @memberof IgxNumberSummaryOperand
154154
*/
155-
public operate(data: any[] = [], allData: any[] = [], fieldName?: string, locale: string = 'en',
155+
public operate(data: any[] = [], allData: any[] = [], fieldName?: string, locale: string = 'en-US',
156156
pipeArgs: IColumnPipeArgs = { }): IgxSummaryResult[] {
157157
const result = super.operate(data, allData, fieldName, locale);
158158
const pipe = new DecimalPipe(locale);
@@ -235,7 +235,7 @@ export class IgxDateSummaryOperand extends IgxSummaryOperand {
235235
* ```
236236
* @memberof IgxDateSummaryOperand
237237
*/
238-
public operate(data: any[] = [], allData: any[] = [], fieldName?: string, locale: string = 'en',
238+
public operate(data: any[] = [], allData: any[] = [], fieldName?: string, locale: string = 'en-US',
239239
pipeArgs: IColumnPipeArgs = { }): IgxSummaryResult[] {
240240
const result = super.operate(data, allData, fieldName, locale);
241241
const pipe = new DatePipe(locale);

0 commit comments

Comments
 (0)