Skip to content

Commit 1cf885f

Browse files
committed
chore(*): lint fixes for exp panel, transactions
1 parent 887ef81 commit 1cf885f

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

projects/igniteui-angular/src/lib/checkbox/checkbox.component.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,15 +381,15 @@ class CheckboxReadonlyComponent {
381381
})
382382
class CheckboxExternalLabelComponent {
383383
@ViewChild('cb', { static: true }) public cb: IgxCheckboxComponent;
384-
label = 'My Label';
384+
public label = 'My Label';
385385
}
386386

387387
@Component({
388388
template: `<igx-checkbox #cb [aria-label]="label"></igx-checkbox>`
389389
})
390390
class CheckboxInvisibleLabelComponent {
391391
@ViewChild('cb', { static: true }) public cb: IgxCheckboxComponent;
392-
label = 'Invisible Label';
392+
public label = 'Invisible Label';
393393
}
394394

395395
@Component({

projects/igniteui-angular/src/lib/expansion-panel/expansion-panel.component.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
168168
constructor(private cdr: ChangeDetectorRef, private builder: AnimationBuilder) { }
169169

170170
/** @hidden */
171-
ngAfterContentInit(): void {
171+
public ngAfterContentInit(): void {
172172
if (this.body && this.header) {
173173
// schedule at end of turn:
174174
Promise.resolve().then(() => {
@@ -188,7 +188,7 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
188188
* <button (click)="myPanel.collapse($event)">Collpase Panel</button>
189189
* ```
190190
*/
191-
collapse(evt?: Event) {
191+
public collapse(evt?: Event) {
192192
if (this.collapsed) { // If expansion panel is already collapsed, do nothing
193193
return;
194194
}
@@ -211,7 +211,7 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
211211
* <button (click)="myPanel.expand($event)">Expand Panel</button>
212212
* ```
213213
*/
214-
expand(evt?: Event) {
214+
public expand(evt?: Event) {
215215
if (!this.collapsed) { // If the panel is already opened, do nothing
216216
return;
217217
}
@@ -234,18 +234,18 @@ export class IgxExpansionPanelComponent implements IgxExpansionPanelBase, AfterC
234234
* <button (click)="myPanel.toggle($event)">Expand Panel</button>
235235
* ```
236236
*/
237-
toggle(evt?: Event) {
237+
public toggle(evt?: Event) {
238238
if (this.collapsed) {
239239
this.open(evt);
240240
} else {
241241
this.close(evt);
242242
}
243243
}
244244

245-
open(evt?: Event) {
245+
public open(evt?: Event) {
246246
this.expand(evt);
247247
}
248-
close(evt?: Event) {
248+
public close(evt?: Event) {
249249
this.collapse(evt);
250250
}
251251

projects/igniteui-angular/src/lib/services/transaction/base-transaction.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,24 +47,24 @@ export class IgxBaseTransactionService<T extends Transaction, S extends State> i
4747
/**
4848
* @inheritdoc
4949
*/
50-
getTransactionLog(id?: any): T[] {
51-
return [];
52-
}
50+
public getTransactionLog(_id?: any): T[] {
51+
return [];
52+
}
5353

5454
/**
5555
* @inheritdoc
5656
*/
57-
undo(): void { }
57+
public undo(): void { }
5858

5959
/**
6060
* @inheritdoc
6161
*/
62-
redo(): void { }
62+
public redo(): void { }
6363

6464
/**
6565
* @inheritdoc
6666
*/
67-
getAggregatedChanges(mergeChanges: boolean): T[] {
67+
public getAggregatedChanges(mergeChanges: boolean): T[] {
6868
const result: T[] = [];
6969
this._pendingStates.forEach((state: S, key: any) => {
7070
const value = mergeChanges ? this.getAggregatedValue(key, mergeChanges) : state.value;
@@ -97,12 +97,12 @@ export class IgxBaseTransactionService<T extends Transaction, S extends State> i
9797
/**
9898
* @inheritdoc
9999
*/
100-
commit(data: any[], id?: any): void { }
100+
public commit(_data: any[], _id?: any): void { }
101101

102102
/**
103103
* @inheritdoc
104104
*/
105-
clear(id?: any): void {
105+
public clear(_id?: any): void {
106106
this._pendingStates.clear();
107107
this._pendingTransactions = [];
108108
}
@@ -117,7 +117,7 @@ export class IgxBaseTransactionService<T extends Transaction, S extends State> i
117117
/**
118118
* @inheritdoc
119119
*/
120-
public endPending(commit: boolean): void {
120+
public endPending(_commit: boolean): void {
121121
this._isPending = false;
122122
this._pendingStates.clear();
123123
this._pendingTransactions = [];

projects/igniteui-angular/src/lib/services/transaction/igx-transaction.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ export class IgxTransactionService<T extends Transaction, S extends State> exten
1818
/**
1919
* @inheritdoc
2020
*/
21-
get canUndo(): boolean {
21+
public get canUndo(): boolean {
2222
return this._undoStack.length > 0;
2323
}
2424

2525
/**
2626
* @inheritdoc
2727
*/
28-
get canRedo(): boolean {
28+
public get canRedo(): boolean {
2929
return this._redoStack.length > 0;
3030
}
3131

0 commit comments

Comments
 (0)