fix(overlay): reuse passed in open method settings

wnvko · wnvko · commit 223e13885b05 · 2025-01-21T12:00:05.000+02:00
diff --git a/projects/igniteui-angular/src/lib/services/overlay/overlay.spec.ts b/projects/igniteui-angular/src/lib/services/overlay/overlay.spec.ts
@@ -1379,7 +1379,7 @@ describe('igxOverlay', () => {
             overlayInstance.detach(firstCallId);
         }));
 
-        fit('#15228 - Should use provided in show overlay settings ', fakeAsync(() => {
+        it('#15228 - Should use provided in show overlay settings ', fakeAsync(() => {
             const fixture = TestBed.createComponent(SimpleRefComponent);
             fixture.detectChanges();
             const overlayInstance = fixture.componentInstance.overlay;
diff --git a/projects/igniteui-angular/src/lib/services/overlay/overlay.ts b/projects/igniteui-angular/src/lib/services/overlay/overlay.ts
@@ -416,7 +416,7 @@ export class IgxOverlayService implements OnDestroy {
             return;
         }
         if (settings) {
-            // TODO: update attach
+            info.settings = settings;
         }
         this.updateSize(info);
         info.settings.positionStrategy.position(

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ export class IgxOverlayService implements OnDestroy {`
`416`	`416`	`return;`
`417`	`417`	`}`
`418`	`418`	`if (settings) {`
`419`		`- // TODO: update attach`
	`419`	`+ info.settings = settings;`
`420`	`420`	`}`
`421`	`421`	`this.updateSize(info);`
`422`	`422`	`info.settings.positionStrategy.position(`