Skip to content

Commit 299e8c5

Browse files
authored
Merge branch 'master' into pmoleri/memory-leak-fixing
2 parents 8170752 + 7110f09 commit 299e8c5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

projects/igniteui-angular/src/lib/data-operations/filtering-expression.interface.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export enum FilteringLogic {
77
Or
88
}
99

10-
/* tsPlainInterface */
1110
/* marshalByValue */
1211
/**
1312
* Represents filtering expressions.

projects/igniteui-angular/src/lib/data-operations/filtering-expressions-tree.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export declare interface IExpressionTree {
1616
returnFields?: string[] | null;
1717
}
1818

19+
/* alternateBaseType: ExpressionTree */
1920
/* marshalByValue */
2021
export declare interface IFilteringExpressionsTree extends IBaseEventArgs, IExpressionTree {
2122
filteringOperands: (IFilteringExpressionsTree | IFilteringExpression)[];

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6618,10 +6618,10 @@ export abstract class IgxGridBaseDirective implements GridType,
66186618
.filter((c) => c.pinned);
66196619
this._unpinnedColumns = newColumns.filter((c) => !c.pinned);
66206620
this._columns = newColumns;
6621-
if (this._columns && this._filteringExpressionsTree) {
6621+
if (this._columns && this._columns.length && this._filteringExpressionsTree) {
66226622
this._filteringExpressionsTree = recreateTreeFromFields(this._filteringExpressionsTree, this.columns) as IFilteringExpressionsTree;
66236623
}
6624-
if (this._columns && this._advancedFilteringExpressionsTree) {
6624+
if (this._columns && this._columns.length && this._advancedFilteringExpressionsTree) {
66256625
this._advancedFilteringExpressionsTree = recreateTreeFromFields(this._advancedFilteringExpressionsTree, this.columns) as IFilteringExpressionsTree;
66266626
}
66276627
this.resetCaches();
@@ -6686,10 +6686,10 @@ export abstract class IgxGridBaseDirective implements GridType,
66866686
} else {
66876687
this._columns = this.getColumnList();
66886688
}
6689-
if (this._columns && this._filteringExpressionsTree) {
6689+
if (this._columns && this._columns.length && this._filteringExpressionsTree) {
66906690
this._filteringExpressionsTree = recreateTreeFromFields(this._filteringExpressionsTree, this._columns) as IFilteringExpressionsTree;
66916691
}
6692-
if (this._columns && this._advancedFilteringExpressionsTree) {
6692+
if (this._columns && this._columns.length && this._advancedFilteringExpressionsTree) {
66936693
this._advancedFilteringExpressionsTree = recreateTreeFromFields(this._advancedFilteringExpressionsTree, this._columns) as IFilteringExpressionsTree;
66946694
}
66956695

0 commit comments

Comments
 (0)