Merge branch 'master' into dmdimitrov/fix-10391-master

Author: igdmdimitrov

.browserslistrc

@@ -9,4 +9,4 @@
 last 2 versions
 Firefox ESR
 not dead
-IE 11 # For IE 9-11 support, remove 'not'.
+

.eslintrc.json

@@ -16,8 +16,7 @@
         "createDefaultProgram": true
       },
       "extends": [
-        "plugin:@angular-eslint/ng-cli-compat",
-        "plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
+        "plugin:@angular-eslint/recommended",
         "plugin:@angular-eslint/template/process-inline-templates"
       ],
       "rules": {
@@ -36,7 +35,7 @@
         "@typescript-eslint/consistent-type-definitions": "error",
         "@typescript-eslint/dot-notation": "off",
         "@typescript-eslint/explicit-member-accessibility": [
-          "warn",
+          "error",
           {
             "accessibility": "explicit",
             "overrides": {

.github/workflows/nodejs.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [14.x, 16.x]
 
     steps:
       - name: Checkout
@@ -47,16 +47,9 @@ jobs:
       - name: Build i18n & validate output
         run: |
             npm run build:i18n
-            npm run lint:i18n:dist
-      - name: Install coverage combiner - istanbul
-        if: github.repository == 'IgniteUI/igniteui-angular' && matrix.node-version == '14.x'
-        run: npm install -g istanbul
-      - name: Combine scripts
-        if: github.repository == 'IgniteUI/igniteui-angular' && matrix.node-version == '14.x'
-        run: istanbul report --dir coverage --include coverage/**/coverage-final.json lcov
+            npm run test:i18n:dist
       - name: Publish to coveralls.io
         if: github.repository == 'IgniteUI/igniteui-angular' && matrix.node-version == '14.x'
         uses: coverallsapp/[email protected]
         with:
             github-token: ${{ github.token }}
-

.github/workflows/npm-publish.yml

@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 12
+          node-version: 14
           cache: 'npm'
           registry-url: 'https://registry.npmjs.org'
       - run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
@@ -35,8 +35,10 @@ jobs:
             if [[ ${VERSION} == *"alpha"* || ${VERSION} == *"beta"* || ${VERSION} == *"rc"* ]]; then echo "NPM_TAG=next"; else echo "NPM_TAG=latest"; fi >> $GITHUB_ENV
             echo ${NPM_TAG}
 
-      - name: Copy readme for igniteui-angular
-        run: cp ../../README.md README.md
+      - name: Copy readme and license for igniteui-angular
+        run: |
+            cp ../../README.md README.md
+            cp ../../LICENSE LICENSE
         working-directory: dist/igniteui-angular
 
       - name: Copy i18n files

.gitignore

@@ -6,6 +6,8 @@
 /tmp
 /out-tsc
 
+.angular/*
+
 # dependencies
 /node_modules
 
@@ -27,6 +29,7 @@
 !.vscode/extensions.json
 
 # misc
+/.angular/cache
 /.sass-cache
 /connect.lock
 /coverage

CHANGELOG.md

@@ -55,6 +55,11 @@ All notable changes for each version of this project will be documented in this
 
 ### General
 
+- `IE discontinued support` **Breaking Change** [details](https://angular.io/guide/browser-support)
+    - `web-animations-js` is removed as Peer Dependency.
+    - Removed IE from `.browserslistrc`
+    - Removed IE related `polyfills`, like Importing ES7 polyfill for Object (`'core-js/es7/object'`) for IE is no longer used.
+
 - `IgxDialog`
     - **Breaking Change** - The default positionSettings open/close animation has been changed to `fadeIn`/`fadeOut`. The open/close animation can be set through the position settings, e.g. change the animation to the previously default open/close animation:
 
@@ -73,13 +78,41 @@ All notable changes for each version of this project will be documented in this
         - Inputs  `showToolbar`, `toolbarTitle`, `columnHiding`, `columnHidingTitle`, `hiddenColumnsText`,
         `columnPinning`, `columnPinningTitle`, `pinnedColumnsText`.
         Use `IgxGridToolbarComponent`, `IgxGridToolbarHidingComponent`, `IgxGridToolbarPinningComponent` instead.
-- `igxGrid`
+    - **Breaking Change** - The `rowSelected` event is renamed to `rowSelectionChanging` to better reflect its function.
+    - **Breaking Change** - The `columnSelected` event is renamed to `columnSelectionChanging` to better reflect its function.
+    - **Breaking Change** - `columnsCollection` is removed. Use `columns` instead. If at certain ocasions `columns` return empty array, query the columns using `ViewChildren` and access those in `ngAfterViewInit`:
+    ```ts
+    @ViewChildren(IgxColumnComponent, { read: IgxColumnComponent })
+    public columns: QueryList<IgxColumnComponent>;
+    ```
+    - `RowType`, `IgxRowDirective`
+        - **Breaking Change** - `rowData` and `rowID` deprecated properties are now removed. Use `data` and `key` instead. Use `ng update` for automatic migration.
+    - `igxRowSelector`
+        - `rowID` in the context object of the `igxRowSelector` is now deprecated and will be removed in future version. Use `key` property instead:
+        ```html
+        <igx-grid [data]="data", [rowSelection]="'multiple'" primaryKey="ID">
+            <igx-column field="Name"></igx-column>
+            <igx-column field="Age"></igx-column>
+
+            <ng-template igxRowSelector let-rowContext>
+                <span>{{ rowContext.key }}</span>
+            </ng-template>
+        </igx-grid>
+        ```
+    - `IgxColumnActionsComponent`
+        - **Breaking Change** -  Input `columns` has been removed. Use `igxGrid` `columns` input instead.
+    - `igxGrid`
     - Exposed a `groupStrategy` input that functions similarly to `sortStrategy`, allowing customization of the grouping behavior of the grid. Please, refer to the [Group By ](https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/groupby) topic for more information.
-- `IgxColumnActionsComponent`
-    - **Breaking Change** - The following input has been removed
-        - Input `columns`. Use `igxGrid` `columns` input instead.
 - `IgxCarousel`
-    - **Breaking Changes** -The carousel animation type `CarouselAnimationType` is renamed to `HorizontalAnimationType`.
+    - **Breaking Changes** - The carousel animation type `CarouselAnimationType` is renamed to `HorizontalAnimationType`.
+
+- `Theming`
+    - **Breaking Change** - Changed CSS palette variables from HEX values to a list of H, S, L comma-separated values, which requires the use of the CSS `hsl` function when accessing these values directly.
+        ```scss
+        .bozo {
+            background: hsl(var(--igx-surface-500));
+        }
+        ```
 
 ## 12.2.3
 

angular.json

@@ -75,9 +75,6 @@
                   "with": "src/environments/environment.hmr.ts"
                 }
               ]
-            },
-            "es5": {
-              "tsConfig": "src/tsconfig-es5.app.json"
             }
           }
         },
@@ -92,13 +89,7 @@
             },
             "hmr": {
               "hmr": true,
-              "hmrWarning": false,
               "browserTarget": "igniteui-dev-demos:build:hmr"
-            },
-            "es5": {
-              "hmr": true,
-              "hmrWarning": false,
-              "browserTarget": "igniteui-dev-demos:build:es5"
             }
           }
         },

gulpfile.js

@@ -118,6 +118,11 @@ module.exports.copyMigrations = (cb) => {
         '!**/tsconfig.json'
     ]).pipe(gulp.dest('./dist/igniteui-angular/migrations'));
 
+
+    gulp.src([
+        './projects/igniteui-angular/migrations/common/import-helper.js'
+    ]).pipe(gulp.dest('./dist/igniteui-angular/migrations/common'));
+
     cb();
 };