Skip to content

Commit 2cadfa8

Browse files
committed
chore(test): Enable leaks check in all karma configurations
1 parent 83b72d5 commit 2cadfa8

File tree

8 files changed

+14
-9
lines changed

8 files changed

+14
-9
lines changed

projects/igniteui-angular/karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module.exports = function (config) {
5252
customLaunchers: {
5353
ChromeHeadlessNoSandbox: {
5454
base: 'ChromeHeadless',
55-
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800'],
55+
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800', '--js-flags="--expose-gc"'],
5656
debug: false
5757
}
5858
},

projects/igniteui-angular/karma.grid.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module.exports = function (config) {
6161
customLaunchers: {
6262
ChromeHeadlessNoSandbox: {
6363
base: 'ChromeHeadless',
64-
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800'],
64+
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800', '--js-flags="--expose-gc"'],
6565
debug: false
6666
}
6767
},

projects/igniteui-angular/karma.hierarchical-grid.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ module.exports = function (config) {
5959
customLaunchers: {
6060
ChromeHeadlessNoSandbox: {
6161
base: 'ChromeHeadless',
62-
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800'],
62+
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800', '--js-flags="--expose-gc"'],
6363
debug: false
6464
}
6565
},

projects/igniteui-angular/karma.non-grid.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ module.exports = function (config) {
5959
customLaunchers: {
6060
ChromeHeadlessNoSandbox: {
6161
base: 'ChromeHeadless',
62-
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800'],
62+
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800', '--js-flags="--expose-gc"'],
6363
debug: false
6464
}
6565
},

projects/igniteui-angular/karma.pivot-grid.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ module.exports = function (config) {
6262
customLaunchers: {
6363
ChromeHeadlessNoSandbox: {
6464
base: 'ChromeHeadless',
65-
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800'],
65+
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800', '--js-flags="--expose-gc"'],
6666
debug: false
6767
}
6868
},

projects/igniteui-angular/karma.tree-grid.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ module.exports = function (config) {
6060
customLaunchers: {
6161
ChromeHeadlessNoSandbox: {
6262
base: 'ChromeHeadless',
63-
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800'],
63+
flags: ['--no-sandbox', '--disable-gpu', '--window-size=820,800', '--js-flags="--expose-gc"'],
6464
debug: false
6565
}
6666
},

projects/igniteui-angular/karma.watch.conf.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,10 @@ module.exports = function (config) {
4242
customLaunchers: {
4343
ChromeWithGC: {
4444
base: 'Chrome',
45-
flags: ['--js-flags="--expose-gc"'],
45+
flags: [
46+
'--js-flags="--expose-gc"',
47+
'--disable-backgrounding-occluded-windows', // don't throttle when window is fully hidden behind others
48+
],
4649
debug: false
4750
}
4851
},

projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2271,7 +2271,9 @@ describe('IgxGrid Component Tests #grid', () => {
22712271
expect(grid.getRowData(7)).toEqual({});
22722272
});
22732273

2274-
it(`Verify that getRowByIndex and RowType API returns correct data`, () => {
2274+
// note: it leaks when grid.groupBy() is executed because template-outlet doesn't destroy the viewrefs
2275+
// to be addressed in a separate PR
2276+
it(`Verify that getRowByIndex and RowType API returns correct data`, skipLeakCheck(() => {
22752277
const fix = TestBed.createComponent(IgxGridDefaultRenderingComponent);
22762278
fix.componentInstance.initColumnsRows(35, 5);
22772279
fix.detectChanges();
@@ -2430,7 +2432,7 @@ describe('IgxGrid Component Tests #grid', () => {
24302432
expect(thirdRow instanceof IgxGroupByRow).toBe(true);
24312433
expect(thirdRow.index).toBe(2);
24322434
expect(thirdRow.viewIndex).toBe(7);
2433-
});
2435+
}));
24342436

24352437
it('Verify that getRowByIndex returns correct data when paging is enabled', fakeAsync(() => {
24362438
const fix = TestBed.createComponent(IgxGridWrappedInContComponent);

0 commit comments

Comments
 (0)