Skip to content

Commit 2df7d14

Browse files
committed
fix(drop-down): remove shadow when list is empty #3977
1 parent b6a976f commit 2df7d14

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
@extend %igx-drop-down__list !optional;
1818
}
1919

20+
@include e(list, $m: empty) {
21+
@extend %igx-drop-down__list !optional;
22+
@extend %igx-drop-down__list--empty !optional;
23+
}
24+
2025
@include e(list-scroll) {
2126
@extend %igx-drop-down__list-scroll !optional;
2227
}

projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-theme.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,15 +229,15 @@
229229
border: --var($theme, 'border-width') solid --var($theme, 'border-color');
230230
}
231231

232+
%igx-drop-down__list--empty {
233+
box-shadow: none;
234+
}
235+
232236
%igx-drop-down__list-scroll {
233237
overflow-y: auto;
234238
overflow-x: hidden;
235239
position: relative;
236240

237-
&:empty {
238-
box-shadow: none;
239-
}
240-
241241
igx-input-group {
242242
margin-top: -16px !important;
243243
}

projects/igniteui-angular/src/lib/drop-down/drop-down.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="igx-drop-down__list" igxToggle [style.width]="width"
1+
<div [ngClass]="listClass()" igxToggle [style.width]="width"
22
(onOpening)="onToggleOpening($event)" (onOpened)="onToggleOpened()" (onAppended)="onToggleContentAppended()"
33
(onClosing)="onToggleClosing($event)" (onClosed)="onToggleClosed()">
44
<div class="igx-drop-down__list-scroll" #scrollContainer [attr.id]="this.listId" role="listbox"

projects/igniteui-angular/src/lib/drop-down/drop-down.component.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,13 @@ export class IgxDropDownComponent extends IgxDropDownBaseDirective implements ID
524524
}
525525
}
526526

527+
/**
528+
* @hidden @internal
529+
*/
530+
public listClass() {
531+
return this.items.length > 0 ? 'igx-drop-down__list' : 'igx-drop-down__list--empty';
532+
}
533+
527534
/**
528535
* Handles the `onSelection` emit and the drop down toggle when selection changes
529536
* @hidden

0 commit comments

Comments
 (0)