fix(button): memory leak in button

pmoleri · pmoleri · commit 2ffd0364d719 · 2025-02-24T17:30:42.000-03:00
diff --git a/projects/igniteui-angular/src/lib/directives/button/button.directive.spec.ts b/projects/igniteui-angular/src/lib/directives/button/button.directive.spec.ts
@@ -10,7 +10,7 @@ import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 const BUTTON_COMFORTABLE = 'igx-button';
 
 describe('IgxButton', () => {
-    configureTestSuite();
+    configureTestSuite({ checkLeaks: true });
 
     const baseClass = BUTTON_COMFORTABLE;
     const classes = {
diff --git a/projects/igniteui-angular/src/lib/directives/button/button.directive.ts b/projects/igniteui-angular/src/lib/directives/button/button.directive.ts
@@ -128,7 +128,8 @@ export class IgxButtonDirective extends IgxButtonBaseDirective implements AfterC
     }
 
     public ngAfterContentInit() {
-        this.nativeElement.addEventListener('click', this.emitSelected.bind(this));
+        this.emitSelected = this.emitSelected.bind(this);
+        this.nativeElement.addEventListener('click', this.emitSelected);
     }
 
     public ngOnDestroy(): void {

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,8 @@ export class IgxButtonDirective extends IgxButtonBaseDirective implements AfterC`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`public ngAfterContentInit() {`
`131`		`- this.nativeElement.addEventListener('click', this.emitSelected.bind(this));`
	`131`	`+ this.emitSelected = this.emitSelected.bind(this);`
	`132`	`+ this.nativeElement.addEventListener('click', this.emitSelected);`
`132`	`133`	`}`
`133`	`134`
`134`	`135`	`public ngOnDestroy(): void {`