Skip to content

Commit 30693f0

Browse files
kdinevkdinev
authored
refactor(lint): removing leftover on-prefixed outputs (#12651)
1 parent f6f4a69 commit 30693f0

28 files changed

+546
-115
lines changed

‎CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,16 @@ All notable changes for each version of this project will be documented in this
44

55
## 15.1.0
66

7+
### General
78
- `IgxPivotGrid`
89
- The `IgxPivotDateDimension` properties `inBaseDimension` and `inOption` have been deprecated and renamed to `baseDimension` and `options` respectively.
10+
- `IgxGrid`
11+
- **Breaking Change** The `onGroupingDone` output has been renamed to `groupingDone` to not violate the no on-prefixed outputs convention. Automatic migrations are available and will be applied on `ng update`.
12+
- `DisplayDensity`
13+
- **Breaking Change** The `onDensityChanged` output has been renamed to `densityChanged` to not violate the no on-prefixed outputs convention. All components expolsing this event are affected. Automatic migrations are available and will be applied on `ng update`.
14+
- `IgxCarousel`
15+
- **Breaking Change** The `onSlideChanged`, `onSlideAdded`, `onSlideRemoved`, `onCarouselPaused` and `onCarouselPlaying` outputs have been renamed to `slideChanged`, `slideAdded`, `slideRemoved`, `carouselPaused` and `carouselPlaying` to not violate the no on-prefixed outputs convention. Automatic migrations are available and will be applied on `ng update`.
16+
917

1018
## 15.0.1
1119

‎projects/igniteui-angular/.eslintrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
}
3434
],
3535
"@angular-eslint/no-input-rename": "off",
36-
"@angular-eslint/no-output-on-prefix": "warn",
3736
"@typescript-eslint/consistent-type-definitions": "error",
3837
"@typescript-eslint/dot-notation": "off",
3938
"brace-style": [

‎projects/igniteui-angular/migrations/migration-collection.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,11 @@
140140
"version": "15.0.11",
141141
"description": "Updates Ignite UI for Angular from v15.0.x to v15.0.11",
142142
"factory": "./update-15_0_11"
143+
},
144+
"migration-29": {
145+
"version": "15.1.0",
146+
"description": "Updates Ignite UI for Angular from v15.0.x to v15.1.0",
147+
"factory": "./update-15_1_0"
143148
}
144149
}
145150
}

‎projects/igniteui-angular/migrations/update-11_1_0/index.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ export class IconTestComponent {
305305
).toEqual(`<igx-list (panStateChange)="panStateChange($event)"></igx-list>`);
306306
});
307307

308-
xit('should replace IgxListComponent event name OnItemClicked with itemClicked', async () => {
308+
it('should replace IgxListComponent event name OnItemClicked with itemClicked', async () => {
309309
appTree.create(
310310
`/testSrc/appPrefix/component/list.component.html`,
311311
`<igx-list (onItemClicked)="onItemClicked($event)"></igx-list>`

‎projects/igniteui-angular/migrations/update-15_1_0/changes/members.json

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
{
2+
"$schema": "../../common/schema/members-changes.schema.json",
3+
"changes": [
4+
{
5+
"member": "onGroupingDone",
6+
"replaceWith": "groupingDone",
7+
"definedIn": [
8+
"IgxGridComponent"
9+
]
10+
},
11+
{
12+
"member": "onDensityChanged",
13+
"replaceWith": "densityChanged",
14+
"definedIn": [
15+
"IgxActionStripComponent",
16+
"IgxButtonGroupComponent",
17+
"IgxChipComponent",
18+
"IgxComboComponent",
19+
"IgxDatePickerComponent",
20+
"IgxDateRangePickerComponent",
21+
"IgxTimePickerComponent",
22+
"IgxButtonDirective",
23+
"IgxDropDownComponent",
24+
"IgxGridComponent",
25+
"IgxGridToolbarComponent",
26+
"IgxTreeGridComponent",
27+
"IgxHierarchicalGridComponent",
28+
"IgxPivotGridComponent",
29+
"IgxInputGroupComponent",
30+
"IgxListComponent",
31+
"IgxPaginatorComponent",
32+
"IgxQueryBuilderComponent",
33+
"IgxTreeComponent"
34+
]
35+
},
36+
{
37+
"member": "onSlideChanged",
38+
"replaceWith": "slideChanged",
39+
"definedIn": [
40+
"IgxCarouselComponent"
41+
]
42+
},
43+
{
44+
"member": "onSlideAdded",
45+
"replaceWith": "slideAdded",
46+
"definedIn": [
47+
"IgxCarouselComponent"
48+
]
49+
},
50+
{
51+
"member": "onSlideRemoved",
52+
"replaceWith": "slideRemoved",
53+
"definedIn": [
54+
"IgxCarouselComponent"
55+
]
56+
},
57+
{
58+
"member": "onCarouselPaused",
59+
"replaceWith": "carouselPaused",
60+
"definedIn": [
61+
"IgxCarouselComponent"
62+
]
63+
},
64+
{
65+
"member": "onCarouselPlaying",
66+
"replaceWith": "carouselPlaying",
67+
"definedIn": [
68+
"IgxCarouselComponent"
69+
]
70+
}
71+
]
72+
}

‎projects/igniteui-angular/migrations/update-15_1_0/changes/outputs.json

Lines changed: 205 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,205 @@
1+
{
2+
"$schema": "../../common/schema/binding.schema.json",
3+
"changes": [
4+
{
5+
"name": "onSlideChanged",
6+
"replaceWith": "slideChanged",
7+
"owner": {
8+
"selector": "igx-carousel",
9+
"type": "component"
10+
}
11+
},
12+
{
13+
"name": "onSlideAdded",
14+
"replaceWith": "slideAdded",
15+
"owner": {
16+
"selector": "igx-carousel",
17+
"type": "component"
18+
}
19+
},
20+
{
21+
"name": "onSlideRemoved",
22+
"replaceWith": "slideRemoved",
23+
"owner": {
24+
"selector": "igx-carousel",
25+
"type": "component"
26+
}
27+
},
28+
{
29+
"name": "onCarouselPaused",
30+
"replaceWith": "carouselPaused",
31+
"owner": {
32+
"selector": "igx-carousel",
33+
"type": "component"
34+
}
35+
},
36+
{
37+
"name": "onCarouselPlaying",
38+
"replaceWith": "carouselPlaying",
39+
"owner": {
40+
"selector": "igx-carousel",
41+
"type": "component"
42+
}
43+
},
44+
{
45+
"name": "onDensityChanged",
46+
"replaceWith": "densityChanged",
47+
"owner": {
48+
"selector": "igx-action-strip",
49+
"type": "component"
50+
}
51+
},
52+
{
53+
"name": "onDensityChanged",
54+
"replaceWith": "densityChanged",
55+
"owner": {
56+
"selector": "igx-buttongroup",
57+
"type": "component"
58+
}
59+
},
60+
{
61+
"name": "onDensityChanged",
62+
"replaceWith": "densityChanged",
63+
"owner": {
64+
"selector": "igx-chip",
65+
"type": "component"
66+
}
67+
},
68+
{
69+
"name": "onDensityChanged",
70+
"replaceWith": "densityChanged",
71+
"owner": {
72+
"selector": "igx-combo",
73+
"type": "component"
74+
}
75+
},
76+
{
77+
"name": "onDensityChanged",
78+
"replaceWith": "densityChanged",
79+
"owner": {
80+
"selector": "igx-date-picker",
81+
"type": "component"
82+
}
83+
},
84+
{
85+
"name": "onDensityChanged",
86+
"replaceWith": "densityChanged",
87+
"owner": {
88+
"selector": "igx-date-range-picker",
89+
"type": "component"
90+
}
91+
},
92+
{
93+
"name": "onDensityChanged",
94+
"replaceWith": "densityChanged",
95+
"owner": {
96+
"selector": "igx-time-picker",
97+
"type": "component"
98+
}
99+
},
100+
{
101+
"name": "onDensityChanged",
102+
"replaceWith": "densityChanged",
103+
"owner": {
104+
"selector": "igxButton",
105+
"type": "directive"
106+
}
107+
},
108+
{
109+
"name": "onDensityChanged",
110+
"replaceWith": "densityChanged",
111+
"owner": {
112+
"selector": "igx-drop-down",
113+
"type": "component"
114+
}
115+
},
116+
{
117+
"name": "onGroupingDone",
118+
"replaceWith": "groupingDone",
119+
"owner": {
120+
"selector": "igx-grid",
121+
"type": "component"
122+
}
123+
},
124+
{
125+
"name": "onDensityChanged",
126+
"replaceWith": "densityChanged",
127+
"owner": {
128+
"selector": "igx-grid",
129+
"type": "component"
130+
}
131+
},
132+
{
133+
"name": "onDensityChanged",
134+
"replaceWith": "densityChanged",
135+
"owner": {
136+
"selector": "igx-grid-toolbar",
137+
"type": "component"
138+
}
139+
},
140+
{
141+
"name": "onDensityChanged",
142+
"replaceWith": "densityChanged",
143+
"owner": {
144+
"selector": "igx-tree-grid",
145+
"type": "component"
146+
}
147+
},
148+
{
149+
"name": "onDensityChanged",
150+
"replaceWith": "densityChanged",
151+
"owner": {
152+
"selector": "igx-hierarchical-grid",
153+
"type": "component"
154+
}
155+
},
156+
{
157+
"name": "onDensityChanged",
158+
"replaceWith": "densityChanged",
159+
"owner": {
160+
"selector": "igx-pivot-grid",
161+
"type": "component"
162+
}
163+
},
164+
{
165+
"name": "onDensityChanged",
166+
"replaceWith": "densityChanged",
167+
"owner": {
168+
"selector": "igx-input-group",
169+
"type": "component"
170+
}
171+
},
172+
{
173+
"name": "onDensityChanged",
174+
"replaceWith": "densityChanged",
175+
"owner": {
176+
"selector": "igx-list",
177+
"type": "component"
178+
}
179+
},
180+
{
181+
"name": "onDensityChanged",
182+
"replaceWith": "densityChanged",
183+
"owner": {
184+
"selector": "igx-paginator",
185+
"type": "component"
186+
}
187+
},
188+
{
189+
"name": "onDensityChanged",
190+
"replaceWith": "densityChanged",
191+
"owner": {
192+
"selector": "igx-query-builder",
193+
"type": "component"
194+
}
195+
},
196+
{
197+
"name": "onDensityChanged",
198+
"replaceWith": "densityChanged",
199+
"owner": {
200+
"selector": "igx-tree",
201+
"type": "component"
202+
}
203+
}
204+
]
205+
}

0 commit comments

Comments
 (0)