Skip to content

Commit 318e5a1

Browse files
committed
fix(ESF): Made search bool values localizable.
1 parent 6ca29a3 commit 318e5a1

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,9 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
669669
filterListItem.isFiltered = true;
670670
}
671671
filterListItem.value = element;
672-
filterListItem.label = element;
672+
filterListItem.label = element ?
673+
this.grid.resourceStrings.igx_grid_filter_true :
674+
this.grid.resourceStrings.igx_grid_filter_false;
673675
filterListItem.indeterminate = false;
674676
this.listData.push(filterListItem);
675677
} else {

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5204,6 +5204,44 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
52045204
const cellValues = GridFunctions.getColumnCells(fix, 'ProductName').map(c => c.nativeElement.innerText).sort();
52055205
expect(cellValues).toEqual(['Web', 'Web']);
52065206
});
5207+
5208+
it('Should display the default True and False resource strings in the search list for boolean column.', fakeAsync(() => {
5209+
GridFunctions.clickExcelFilterIconFromCode(fix, grid, 'Released');
5210+
flush();
5211+
5212+
const searchComponent = GridFunctions.getExcelStyleSearchComponent(fix);
5213+
const listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix, searchComponent);
5214+
5215+
expect(listItems.length).toBe(4, 'incorrect rendered list items count');
5216+
expect(listItems[2].innerText).toBe('False', 'incorrect list item label');
5217+
expect(listItems[3].innerText).toBe('True', 'incorrect list item label');
5218+
5219+
const checkboxes = GridFunctions.getExcelStyleFilteringCheckboxes(fix);
5220+
checkboxes[3].click();
5221+
tick();
5222+
fix.detectChanges();
5223+
5224+
GridFunctions.clickApplyExcelStyleFiltering(fix);
5225+
flush();
5226+
5227+
expect(grid.filteredData.length).toEqual(5);
5228+
}));
5229+
5230+
it('Should display the custom resource strings when specified in the search list for boolean column.', fakeAsync(() => {
5231+
grid.resourceStrings.igx_grid_filter_false = 'No';
5232+
grid.resourceStrings.igx_grid_filter_true = 'Yes';
5233+
fix.detectChanges();
5234+
5235+
GridFunctions.clickExcelFilterIconFromCode(fix, grid, 'Released');
5236+
flush();
5237+
5238+
const searchComponent = GridFunctions.getExcelStyleSearchComponent(fix);
5239+
const listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix, searchComponent);
5240+
5241+
expect(listItems.length).toBe(4, 'incorrect rendered list items count');
5242+
expect(listItems[2].innerText).toBe('No', 'incorrect list item label');
5243+
expect(listItems[3].innerText).toBe('Yes', 'incorrect list item label');
5244+
}));
52075245
});
52085246

52095247
describe('Templates: ', () => {

0 commit comments

Comments
 (0)