Merge branch '8.2.x' into pbozhinov/fix-5944-8.2

Author: ChronosSF

projects/igniteui-angular/src/lib/grids/common/grid.interface.ts

@@ -33,4 +33,5 @@ export interface GridType {
     lastEditableColumnIndex: number;
 
     endEdit(commit: boolean, event?: Event): void;
+    isGroupByRecord(rec: any): boolean;
 }

projects/igniteui-angular/src/lib/grids/grid-base.component.ts

@@ -5047,6 +5047,14 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
             this.selectionService.clearRowSelection(event) : this.selectionService.selectAllRows(event);
     }
 
+    /**
+    * @hidden
+    * @internal
+    */
+    public isGroupByRecord(rec) {
+        return false;
+    }
+
     /**
      * @hidden
      */

projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts

@@ -250,15 +250,17 @@ export class IgxGridNavigationService {
     }
 
     public navigateTop(visibleColumnIndex) {
+        const targetIndex = this.findFirstDataRowIndex();
         const verticalScroll = this.grid.verticalScrollContainer.getScroll();
         const cellSelector = this.getCellSelector(visibleColumnIndex);
-        if (verticalScroll.scrollTop === 0) {
+        const targetScr = this.grid.verticalScrollContainer.getScrollForIndex(targetIndex, false);
+        if (targetScr >= verticalScroll.scrollTop) {
             const cells = this.grid.nativeElement.querySelectorAll(
                 `${cellSelector}[data-visibleIndex="${visibleColumnIndex}"]`);
             (cells[0] as HTMLElement).focus();
         } else {
            this.getFocusableGrid().nativeElement.focus({ preventScroll: true });
-            this.grid.verticalScrollContainer.scrollTo(0);
+            this.grid.verticalScrollContainer.scrollTo(targetIndex !== -1 ? targetIndex : 0);
             this.grid.verticalScrollContainer.onChunkLoad
                 .pipe(first()).subscribe(() => {
                     const cells = this.grid.nativeElement.querySelectorAll(
@@ -268,17 +270,34 @@ export class IgxGridNavigationService {
         }
     }
 
+    private findFirstDataRowIndex() {
+        const dv = this.grid.dataView;
+        return dv.findIndex(rec => !this.grid.isGroupByRecord(rec));
+    }
+
+    private findLastDataRowIndex() {
+        let i = this.grid.dataView.length;
+        while (i--) {
+            const rec = this.grid.dataView[i];
+            if (!this.grid.isGroupByRecord(rec)) {
+                 return i;
+            }
+        }
+    }
+
     public navigateBottom(visibleColumnIndex) {
+        const targetIndex = this.findLastDataRowIndex();
+        const targetScr = this.grid.verticalScrollContainer.getScrollForIndex(targetIndex, true);
         const verticalScroll = this.grid.verticalScrollContainer.getScroll();
         const cellSelector = this.getCellSelector(visibleColumnIndex);
         if (verticalScroll.scrollHeight === 0 ||
-            verticalScroll.scrollTop === verticalScroll.scrollHeight - this.grid.verticalScrollContainer.igxForContainerSize) {
+            verticalScroll.scrollTop === targetScr) {
             const cells = this.grid.nativeElement.querySelectorAll(
                 `${cellSelector}[data-visibleIndex="${visibleColumnIndex}"]`);
             (cells[cells.length - 1] as HTMLElement).focus();
         } else {
            this.getFocusableGrid().nativeElement.focus({ preventScroll: true });
-            this.grid.verticalScrollContainer.scrollTo(this.grid.dataView.length - 1);
+            this.grid.verticalScrollContainer.scrollTo(targetIndex !== -1 ? targetIndex : this.grid.dataView.length - 1);
             this.grid.verticalScrollContainer.onChunkLoad
                 .pipe(first()).subscribe(() => {
                     const cells = this.grid.nativeElement.querySelectorAll(
@@ -372,35 +391,33 @@ export class IgxGridNavigationService {
     }
 
     public goToFirstCell() {
+        const targetIndex = this.findFirstDataRowIndex();
+        const targetScr = this.grid.verticalScrollContainer.getScrollForIndex(targetIndex, false);
         const verticalScroll = this.grid.verticalScrollContainer.getScroll();
-        const horizontalScroll = this.grid.dataRowList.first.virtDirRow.getScroll();
-        if (verticalScroll.scrollTop === 0) {
+        if (verticalScroll.scrollTop === targetScr) {
             this.onKeydownHome(this.grid.dataRowList.first.index);
         } else {
-            if (!horizontalScroll.clientWidth || parseInt(horizontalScroll.scrollLeft, 10) <= 1 || this.grid.pinnedColumns.length) {
-                this.navigateTop(0);
-            } else {
-               this.getFocusableGrid().nativeElement.focus({ preventScroll: true });
-                this.horizontalScroll(this.grid.dataRowList.first.index).scrollTo(0);
-                this.grid.parentVirtDir.onChunkLoad
-                    .pipe(first())
-                    .subscribe(() => {
-                        this.navigateTop(0);
-                    });
-            }
+            this.getFocusableGrid().nativeElement.focus({ preventScroll: true });
+            this.grid.verticalScrollContainer.scrollTo(targetIndex !== -1 ? targetIndex : 0);
+            this.grid.verticalScrollContainer.onChunkLoad
+                .pipe(first()).subscribe(() => {
+                    this.onKeydownHome(this.grid.dataRowList.first.index);
+                });
         }
     }
 
     public goToLastCell() {
+        const targetIndex = this.findLastDataRowIndex();
+        const targetScr = this.grid.verticalScrollContainer.getScrollForIndex(targetIndex, true);
         const verticalScroll = this.grid.verticalScrollContainer.getScroll();
         if (verticalScroll.scrollHeight === 0 ||
-            verticalScroll.scrollTop === verticalScroll.scrollHeight - this.grid.verticalScrollContainer.igxForContainerSize) {
+            verticalScroll.scrollTop === targetScr) {
             const rows = this.getAllRows();
             const rowIndex = parseInt(rows[rows.length - 1].getAttribute('data-rowIndex'), 10);
             this.onKeydownEnd(rowIndex);
         } else {
            this.getFocusableGrid().nativeElement.focus({ preventScroll: true });
-            this.grid.verticalScrollContainer.scrollTo(this.grid.dataView.length - 1);
+            this.grid.verticalScrollContainer.scrollTo(targetIndex !== -1 ? targetIndex : this.grid.dataView.length - 1);
             this.grid.verticalScrollContainer.onChunkLoad
                 .pipe(first()).subscribe(() => {
                     const rows = this.getAllRows();