fix(simple-combo): correct filtering functionality when combo is focused

Author: georgianastasov

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts

@@ -1530,20 +1530,25 @@ describe('IgxSimpleCombo', () => {
         });
 
         it('should properly filter dropdown when a key is pressed while the combo is focused but not opened', fakeAsync(() => {
-            spyOn(combo, 'open').and.callThrough();
+            expect(combo.collapsed).toEqual(true);
+
+            combo.handleInputChange('z');
+            tick();
+            fixture.detectChanges();
+
+            expect(combo.filteredData.length).toEqual(1);
 
-            const event = UIInteractions.getKeyboardEvent('keydown', 'z');
+            combo.close();
+            tick();
+            fixture.detectChanges();
 
             expect(combo.collapsed).toEqual(true);
 
-            combo.handleKeyDown(event);
+            combo.handleInputChange(' ');
             tick();
             fixture.detectChanges();
 
-            expect(combo.collapsed).toEqual(false);
-            expect(combo.open).toHaveBeenCalled();
-            expect(combo.filteredData.length).toEqual(1);
-            expect(combo.filteredData).toEqual([{ field: 'Arizona', region: 'Mount' }]);
+            expect(combo.filteredData.length).toEqual(12);
         }));
     });
 

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts

@@ -240,7 +240,9 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
                 this.filterValue = this.searchValue = this.comboInput.value;
                 return;
             }
-            this.filterValue = this.searchValue = '';
+            if (!this.comboInput.value) {
+                this.filterValue = this.searchValue = '';
+            }
         });
         this.dropdown.opened.pipe(takeUntil(this.destroy$)).subscribe(() => {
             if (this.composing) {
@@ -288,7 +290,7 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
         if (this.collapsed && this.comboInput.focused) {
             this.open();
         }
-        if (!this.comboInput.value.trim() && super.selection.length) {
+        if (!this.comboInput.value.trim() && super.selection.length && super.selection[0][this.valueKey] !== "") {
             // handle clearing of input by space
             this.clearSelection();
             this._onChangeCallback(null);
@@ -337,20 +339,6 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
             this.clearOnBlur();
             this.close();
         }
-        if (this.collapsed && event.key && event.key.length > 0
-            && event.key !== this.platformUtil.KEYMAP.CONTROL && !event.altKey && !event.metaKey) {
-            const newFilterValue = this.filterValue + event.key.toLowerCase();
-            this.filterValue = newFilterValue;
-            this.searchValue = newFilterValue;
-            this.filteredData = this.data.filter(item => this.findAllMatches(item));
-            this.open();
-        }
-        if (event.key === this.platformUtil.KEYMAP.SPACE && this.filteredData.length !== this.data.length) {
-            this.clearSelection();
-            this.filterValue = '';
-            this.searchValue = '';
-            this.filteredData = this.data;
-        }
         this.composing = false;
         super.handleKeyDown(event);
     }