fix(input-group): prefix & suffix wrong colors (#12158)

SisIvanova · simeonoff · web-flow · commit 33506abb9033 · 2022-10-05T18:17:10.000+03:00
* fix(input-group): prefix &amp; suffix wrong colors

* refactor(input-group): simplify placeholder selectors

Co-authored-by: Simeon Simeonoff &lt;sim.simeonoff@gmail.com&gt;
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-component.scss b/projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-component.scss
@@ -132,6 +132,8 @@
         }
 
         @include m(filled) {
+            @extend %form-group-display--filled !optional;
+
             @include e(label) {
                 @extend %form-group-label--float !optional;
             }
@@ -150,8 +152,6 @@
         }
 
         @include m(invalid) {
-            @extend %form-group-display--error !optional;
-
             @include e(label) {
                 @extend %form-group-label--error !optional;
             }
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss
@@ -394,15 +394,12 @@
         }
     }
 
-    %form-group-display--error {
+    %form-group-display--filled {
         igx-prefix,
-        [igxPrefix] {
-            @extend %form-group-prefix--error;
-        }
-
+        [igxPrefix],
         igx-suffix,
         [igxSuffix] {
-            @extend %form-group-suffix--error;
+            @extend %form-group-prefix--filled;
         }
     }
 
@@ -1426,9 +1423,8 @@
         padding: 0;
     }
 
-    %form-group-prefix--error,
-    %form-group-suffix--error {
-        color: var-get($theme, 'error-secondary-color');
+    %form-group-prefix--filled {
+        color: var-get($theme, 'filled-text-color');
     }
 
     %form-group-border {

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,8 @@`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`@include m(filled) {`
	`135`	`+ @extend %form-group-display--filled !optional;`
	`136`	`+`
`135`	`137`	`@include e(label) {`
`136`	`138`	`@extend %form-group-label--float !optional;`
`137`	`139`	`}`
`@@ -150,8 +152,6 @@`
`150`	`152`	`}`
`151`	`153`
`152`	`154`	`@include m(invalid) {`
`153`		`- @extend %form-group-display--error !optional;`
`154`		`-`
`155`	`155`	`@include e(label) {`
`156`	`156`	`@extend %form-group-label--error !optional;`
`157`	`157`	`}`
Original file line number	Diff line number	Diff line change
`@@ -394,15 +394,12 @@`
`394`	`394`	`}`
`395`	`395`	`}`
`396`	`396`
`397`		`- %form-group-display--error {`
	`397`	`+ %form-group-display--filled {`
`398`	`398`	`igx-prefix,`
`399`		`- [igxPrefix] {`
`400`		`- @extend %form-group-prefix--error;`
`401`		`- }`
`402`		`-`
	`399`	`+ [igxPrefix],`
`403`	`400`	`igx-suffix,`
`404`	`401`	`[igxSuffix] {`
`405`		`- @extend %form-group-suffix--error;`
	`402`	`+ @extend %form-group-prefix--filled;`
`406`	`403`	`}`
`407`	`404`	`}`
`408`	`405`
`@@ -1426,9 +1423,8 @@`
`1426`	`1423`	`padding: 0;`
`1427`	`1424`	`}`
`1428`	`1425`
`1429`		`- %form-group-prefix--error,`
`1430`		`- %form-group-suffix--error {`
`1431`		`- color: var-get($theme, 'error-secondary-color');`
	`1426`	`+ %form-group-prefix--filled {`
	`1427`	`+ color: var-get($theme, 'filled-text-color');`
`1432`	`1428`	`}`
`1433`	`1429`
`1434`	`1430`	`%form-group-border {`