Merge branch '10.2.x' into bpenkov/date-picker-focusing

Lipata · web-flow · commit 33bc7c5249e2 · 2020-10-21T09:22:32.000+03:00
diff --git a/projects/igniteui-angular/migrations/common/UpdateChanges.spec.ts b/projects/igniteui-angular/migrations/common/UpdateChanges.spec.ts
@@ -390,7 +390,7 @@ describe('UpdateChanges', () => {
         });
         spyOn<any>(fs, 'readFileSync').and.callFake(() => JSON.stringify(classJson));
 
-        const fileContent =
+        let fileContent =
 `import { Size, Type as someThg } from "igniteui-angular";
 import { IgxService, IgxDiffService as eDiffService, Calendar as Calendar } from 'igniteui-angular';
 import { Type } from "@angular/core";
@@ -411,7 +411,7 @@ export class Test {
         expect(update.getClassChanges()).toEqual(classJson);
 
         update.applyChanges();
-        expect(appTree.readContent('test.component.ts')).toEqual(
+        let expectedFileContent =
 `import { IgxSize, IgxType as someThg } from "igniteui-angular";
 import { IgxService1, IgxNewDiffService as eDiffService, CalendarActual as Calendar } from 'igniteui-angular';
 import { Type } from "@angular/core";
@@ -423,8 +423,15 @@ export class Test {
     cal: Calendar;
 
     constructor (public router: Router, private _iconService: IgxService1) {}
-}`
-        );
+}`;
+        expect(appTree.readContent('test.component.ts')).toEqual(expectedFileContent);
+
+        // with ig feed package:
+        fileContent = fileContent.replace(/igniteui-angular/g, '@infragistics/igniteui-angular');
+        expectedFileContent = expectedFileContent.replace(/igniteui-angular/g, '@infragistics/igniteui-angular');
+        appTree.overwrite('test.component.ts', fileContent);
+        update.applyChanges();
+        expect(appTree.readContent('test.component.ts')).toEqual(expectedFileContent);
     });
 
     it('should move property value between element tags', done => {
diff --git a/projects/igniteui-angular/migrations/common/tsUtils.ts b/projects/igniteui-angular/migrations/common/tsUtils.ts
@@ -69,7 +69,7 @@ export function getImportModulePositions(sourceText: string, startsWith: string)
 /** Filters out statements to named imports (e.g. `import {x, y}`) from PACKAGE_IMPORT */
 const namedImportFilter = (statement: ts.Statement) => {
     if (statement.kind === ts.SyntaxKind.ImportDeclaration &&
-        ((statement as ts.ImportDeclaration).moduleSpecifier as ts.StringLiteral).text === IG_PACKAGE_NAME) {
+        ((statement as ts.ImportDeclaration).moduleSpecifier as ts.StringLiteral).text.endsWith(IG_PACKAGE_NAME)) {
 
         const clause = (statement as ts.ImportDeclaration).importClause;
         return clause && clause.namedBindings && clause.namedBindings.kind === ts.SyntaxKind.NamedImports;
diff --git a/projects/igniteui-angular/package.json b/projects/igniteui-angular/package.json
@@ -84,7 +84,7 @@
         "web-animations-js": "^2.3.2"
     },
     "igxDevDependencies": {
-        "@igniteui/angular-schematics": "~10.2.620-beta.0"
+        "@igniteui/angular-schematics": "~10.2.620"
     },
     "ng-update": {
         "migrations": "./migrations/migration-collection.json"
diff --git a/projects/igniteui-angular/src/lib/grids/cell.component.ts b/projects/igniteui-angular/src/lib/grids/cell.component.ts
@@ -191,12 +191,12 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {
             const inlineEditorTemplate = this.column.inlineEditorTemplate;
             return inlineEditorTemplate ? inlineEditorTemplate : this.inlineEditorTemplate;
         }
-        if (this.grid.rowEditable && this.row.addRow) {
-            return this.addRowCellTemplate;
-        }
         if (this.cellTemplate) {
             return this.cellTemplate;
         }
+        if (this.grid.rowEditable && this.row.addRow) {
+            return this.addRowCellTemplate;
+        }
         return this.defaultCellTemplate;
     }
 
diff --git a/projects/igniteui-angular/src/lib/grids/column-actions/column-actions-base.directive.ts b/projects/igniteui-angular/src/lib/grids/column-actions/column-actions-base.directive.ts
@@ -16,12 +16,12 @@ export abstract class IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel: string;
+    public abstract get checkAllLabel(): string;
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel: string;
+    public abstract get uncheckAllLabel(): string;
 
     /**
      * @hidden @internal
diff --git a/projects/igniteui-angular/src/lib/grids/column-actions/column-hiding.directive.ts b/projects/igniteui-angular/src/lib/grids/column-actions/column-hiding.directive.ts
@@ -18,13 +18,16 @@ export class IgxColumnHidingDirective extends IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_hiding_check_all_label ?? 'Hide All';
+    public get checkAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_check_all_label ?? 'Hide All';
+    }
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_hiding_uncheck_all_label ?? 'Show All';
-
+    public get uncheckAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_uncheck_all_label ?? 'Show All';
+    }
     /**
      * @hidden @internal
      */
diff --git a/projects/igniteui-angular/src/lib/grids/column-actions/column-pinning.directive.ts b/projects/igniteui-angular/src/lib/grids/column-actions/column-pinning.directive.ts
@@ -18,13 +18,16 @@ export class IgxColumnPinningDirective extends IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_pinning_check_all_label ?? 'Pin All';
+    public get checkAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_pinning_check_all_label ?? 'Pin All';
+    }
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_pinning_uncheck_all_label ?? 'Unpin All';
-
+    public get uncheckAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_pinning_uncheck_all_label ?? 'Unpin All';
+    }
     /**
      * @hidden @internal
      */
diff --git a/projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts b/projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts
@@ -501,7 +501,7 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
 
     private generateUniqueValues(columnValues: any[]) {
         if (this.column.dataType === DataType.String && this.column.filteringIgnoreCase) {
-            const filteredUniqueValues = columnValues.map(s => s?.toLowerCase())
+            const filteredUniqueValues = columnValues.map(s => s?.toString().toLowerCase())
                 .reduce((map, val, i) => map.get(val) ? map : map.set(val, columnValues[i]),
                 new Map);
 
diff --git a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts
@@ -3149,7 +3149,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
      */
     public generateRowID(): string | number {
         const primaryColumn = this.columnList.find(col => col.field === this.primaryKey);
-        const idType = primaryColumn ? primaryColumn.dataType : this.data.length ? typeof (this.data[0][this.primaryKey]) : 'string';
+        const idType = this.data.length ? typeof (this.data[0][this.primaryKey]) : primaryColumn ? primaryColumn.dataType : 'string';
         return idType === 'string' ? uuidv4() : FAKE_ROW_ID--;
     }
 
@@ -6659,7 +6659,8 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
                 if (args.cancel) {
                     return args.cancel;
                 }
-                this.gridAPI.addRowToData(row.data, this.addRowParent.asChild ? this.addRowParent.rowID : undefined);
+                const parentId = this._getParentRecordId();
+                this.gridAPI.addRowToData(row.data, parentId);
                 const doneArgs = row.createDoneEditEventArgs(cachedRowData);
                 this.rowEditDone.emit(doneArgs);
                 this.crudService.endRowEdit();
@@ -6685,6 +6686,14 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
         return this.cancelAddMode;
     }
 
+    /**
+     * @hidden
+     * @internal
+     */
+    protected _getParentRecordId() {
+        return this.addRowParent.asChild ? this.addRowParent.rowID : undefined;
+    }
+
     /**
      * @hidden
      * @internal
diff --git a/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts b/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts
@@ -224,7 +224,7 @@ export class IgxGridNavigationService {
     }
 
     focusFirstCell(header = true) {
-        if (this.grid.dataView.length && this.activeNode &&
+        if ((header || this.grid.dataView.length) && this.activeNode &&
             (this.activeNode.row === -1 || this.activeNode.row === this.grid.dataView.length ||
             (!header && !this.grid.hasSummarizedColumns))) { return; }
 
diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts
@@ -1,4 +1,4 @@
-import { async, TestBed, fakeAsync } from '@angular/core/testing';
+import { async, TestBed, fakeAsync, tick } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { IgxColumnComponent, IgxGridComponent, IgxGridModule, IGridEditEventArgs, IGridEditDoneEventArgs } from './public_api';
@@ -756,20 +756,23 @@ describe('IgxGrid - Cell Editing #grid', () => {
             expect(grid.cellEdit.emit).toHaveBeenCalledWith(cellArgs);
         });
 
-        it(`Should be able to cancel 'cellEdit' event`, () => {
-            spyOn(grid.cellEdit, 'emit').and.callThrough();
+        it(`Should be able to cancel 'cellEdit' event`, fakeAsync(() => {
+            const emitSpy = spyOn(grid.cellEdit, 'emit').and.callThrough();
             grid.cellEdit.subscribe((e: IGridEditEventArgs) => {
                 e.cancel = true;
             });
-            let cell = grid.getCellByColumn(0, 'fullName');
+            const cell = grid.getCellByColumn(0, 'fullName');
             let cellArgs: IGridEditEventArgs;
             const initialRowData = {...cell.rowData};
 
             UIInteractions.simulateDoubleClickAndSelectEvent(cell);
             fixture.detectChanges();
+            tick(16); // trigger igxFocus rAF
+            const editInput = fixture.debugElement.query(By.css('igx-grid-cell input')).nativeElement;
 
             expect(cell.editMode).toBe(true);
-            let cellValue = cell.value;
+            expect(document.activeElement).toBe(editInput);
+            const cellValue = cell.value;
             const newValue = 'new value';
             cell.editValue = newValue;
 
@@ -790,29 +793,39 @@ describe('IgxGrid - Cell Editing #grid', () => {
             expect(grid.cellEdit.emit).toHaveBeenCalledTimes(1);
             expect(grid.cellEdit.emit).toHaveBeenCalledWith(cellArgs);
 
+            emitSpy.calls.reset();
             UIInteractions.triggerEventHandlerKeyDown('tab', gridContent);
             fixture.detectChanges();
 
             expect(cell.editMode).toBe(true);
             expect(cell.value).toBe(cellValue);
-            expect(grid.cellEdit.emit).toHaveBeenCalledTimes(2);
+            expect(document.activeElement).toBe(editInput);
+            expect(grid.cellEdit.emit).toHaveBeenCalledTimes(1);
             expect(grid.cellEdit.emit).toHaveBeenCalledWith(cellArgs);
 
-            cell = grid.getCellByColumn(0, 'age');
-            cellValue = cell.value;
-            expect(cell.editMode).toBe(false);
+            const nextCell = grid.getCellByColumn(0, 'age');
+            expect(nextCell.editMode).toBe(false);
 
             // activate the new cell
-            cell.activate(null);
+            emitSpy.calls.reset();
+            nextCell.activate(null);
             fixture.detectChanges();
-            expect(grid.cellEdit.emit).toHaveBeenCalledTimes(3);
+            expect(grid.cellEdit.emit).toHaveBeenCalledTimes(1);
             expect(grid.cellEdit.emit).toHaveBeenCalledWith(cellArgs);
 
-            expect(cell.editMode).toBe(false);
+            expect(nextCell.editMode).toBe(false);
+            expect(cell.editMode).toBe(true);
+            expect(document.activeElement).toBe(editInput);
+
+            emitSpy.calls.reset();
+            UIInteractions.triggerEventHandlerKeyDown('enter', gridContent);
+            fixture.detectChanges();
 
-            cell = grid.getCellByColumn(0, 'fullName');
             expect(cell.editMode).toBe(true);
-        });
+            expect(document.activeElement).toBe(editInput);
+            expect(grid.cellEdit.emit).toHaveBeenCalledTimes(1);
+            expect(grid.cellEdit.emit).toHaveBeenCalledWith(cellArgs);
+        }));
 
         it(`Should be able to update other cell in 'cellEdit' event`, () => {
             grid.primaryKey = 'personNumber';
@@ -1031,7 +1044,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
             expect(grid.crudService.cellInEditMode).toEqual(true);
         });
 
-        it('When cellEdit is canceled the new value of the cell should never be commited nor the editing should be closed', () => {
+        it('When cellEdit is canceled the new value of the cell should never be committed nor the editing should be closed', () => {
             const cell = grid.getCellByColumn(0, 'fullName');
             grid.cellEdit.pipe(takeUntil($destroyer)).subscribe((evt) => {
                 evt.cancel = true;
diff --git a/projects/igniteui-angular/src/lib/grids/selection/selection.service.ts b/projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
@@ -210,12 +210,12 @@ export class IgxGridCRUDService {
         }
 
         if (this.cellInEditMode) {
+            // TODO: case solely for f2/enter nav that uses enterEditMode as toggle. Refactor.
             const canceled = this.grid.endEdit(true);
-            if (this.grid.rowEditable && canceled) {
-                this._rowEditingBlocked = canceled;
-            }
 
-            this.grid.tbody.nativeElement.focus();
+            if (!canceled || !this.cell) {
+                this.grid.tbody.nativeElement.focus();
+            }
         } else {
 
             if (cell?.row.addRow) {
@@ -355,7 +355,7 @@ export class IgxGridCRUDService {
     }
 
 
-    /** Cleares cell and row editing state and closes row editing template if it is open */
+    /** Clears cell and row editing state and closes row editing template if it is open */
     public endEditMode() {
         this.endCellEdit();
         if (this.grid.rowEditable) {
diff --git a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-add-row-ui.spec.ts b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-add-row-ui.spec.ts
@@ -92,5 +92,40 @@ describe('IgxTreeGrid - Add Row UI #tGrid', () => {
             const addRow = treeGrid.getRowByIndex(2);
             expect(addRow.addRow).toBeTrue();
         });
+
+        it('should allow adding sibling to child row via the API.', () => {
+            const row = treeGrid.rowList.toArray()[2] as IgxTreeGridRowComponent;
+            // adds row as sibling
+            row.beginAddRow();
+            fix.detectChanges();
+            endTransition();
+
+            treeGrid.endEdit(true);
+            fix.detectChanges();
+
+            // check row is added as sibling
+            expect(treeGrid.rowList.length).toBe(9);
+            const addedRow = treeGrid.rowList.toArray()[4] as IgxTreeGridRowComponent;
+            expect(addedRow.rowData.Name).toBe(undefined);
+            // should have same parent record.
+            expect(addedRow.treeRow.parent).toBe(row.treeRow.parent);
+        });
+
+        it('should allow adding row to empty grid', () => {
+            treeGrid.data = [];
+            fix.detectChanges();
+
+            expect(treeGrid.rowList.length).toBe(0);
+
+            // begin add row for empty grid
+            treeGrid.beginAddRowByIndex(null, -1);
+            fix.detectChanges();
+            endTransition();
+
+            treeGrid.endEdit(true);
+            fix.detectChanges();
+
+            expect(treeGrid.rowList.length).toBe(1);
+        });
     });
 });
diff --git a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts
@@ -519,6 +519,19 @@ export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridTy
         this.notifyChanges();
     }
 
+    /**
+     * @hidden
+     * @internal
+     */
+    protected _getParentRecordId() {
+        if (this.addRowParent.asChild) {
+            return super._getParentRecordId();
+        } else if (this.addRowParent.rowID !== null && this.addRowParent.rowID !== undefined) {
+            const spawnedForRecord =  this._gridAPI.get_rec_by_id(this.addRowParent.rowID);
+            return spawnedForRecord?.parent?.rowID;
+        }
+    }
+
     /** @hidden */
     public deleteRowById(rowId: any) {
         //  if this is flat self-referencing data, and CascadeOnDelete is set to true
diff --git a/src/app/grid-column-actions/custom-action-directive.ts b/src/app/grid-column-actions/custom-action-directive.ts
@@ -18,12 +18,16 @@ export class IgxColumnGroupingDirective extends IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel = 'Group By All';
+    public get checkAllLabel(): string {
+        return 'Group By All';
+    }
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel = 'Ungroup All';
+    public get uncheckAllLabel(): string {
+        return 'Ungroup All';
+    }
 
     /**
      * @hidden @internal

Original file line number	Diff line number	Diff line change
`@@ -191,12 +191,12 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {`
`191`	`191`	`const inlineEditorTemplate = this.column.inlineEditorTemplate;`
`192`	`192`	`return inlineEditorTemplate ? inlineEditorTemplate : this.inlineEditorTemplate;`
`193`	`193`	`}`
`194`		`- if (this.grid.rowEditable && this.row.addRow) {`
`195`		`- return this.addRowCellTemplate;`
`196`		`- }`
`197`	`194`	`if (this.cellTemplate) {`
`198`	`195`	`return this.cellTemplate;`
`199`	`196`	`}`
	`197`	`+ if (this.grid.rowEditable && this.row.addRow) {`
	`198`	`+ return this.addRowCellTemplate;`
	`199`	`+ }`
`200`	`200`	`return this.defaultCellTemplate;`
`201`	`201`	`}`
`202`	`202`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ export class IgxGridNavigationService {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`focusFirstCell(header = true) {`
`227`		`- if (this.grid.dataView.length && this.activeNode &&`
	`227`	`+ if ((header \|\| this.grid.dataView.length) && this.activeNode &&`
`228`	`228`	`(this.activeNode.row === -1 \|\| this.activeNode.row === this.grid.dataView.length \|\|`
`229`	`229`	`(!header && !this.grid.hasSummarizedColumns))) { return; }`
`230`	`230`