Merge branch 'aria-grid-errors' of https://github.com/IgniteUI/igniteui-angular into aria-grid-errors

Author: zdrawku

projects/igniteui-angular/src/lib/grids/filtering/base/grid-filtering-row.component.ts

@@ -24,7 +24,7 @@ import { IBaseChipEventArgs, IgxChipsAreaComponent, IgxChipComponent } from '../
 import { ExpressionUI } from '../grid-filtering.service';
 import { IgxDropDownItemComponent } from '../../../drop-down/drop-down-item.component';
 import { IgxFilteringService } from '../grid-filtering.service';
-import { KEYS, isEdge, isIE } from '../../../core/utils';
+import { KEYS, isEdge } from '../../../core/utils';
 import { AbsoluteScrollStrategy } from '../../../services/overlay/scroll';
 
 /**
@@ -262,11 +262,8 @@ export class IgxGridFilteringRowComponent implements AfterViewInit {
     public onInput(eventArgs) {
         // The 'iskeyPressed' flag is needed for a case in IE, because the input event is fired on focus and for some reason,
         // when you have a japanese character as a placeholder, on init the value here is empty string .
-        // There is no need to reset the value on every invalid number input.
-        // The invalid value is converted to empty string input type="number"
-        const target = eventArgs.target;
-        if (isEdge() && target.type !== 'number' || this.isKeyPressed && isIE() || target.value) {
-             this.value = target.value;
+        if (isEdge() || this.isKeyPressed || eventArgs.target.value) {
+            this.value = eventArgs.target.value;
         }
     }
 

projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts

@@ -350,7 +350,7 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
         }
     }
 
-    constructor(private cdr: ChangeDetectorRef) {}
+    constructor(private cdr: ChangeDetectorRef, private element: ElementRef) {}
 
     /**
      * @hidden @internal
@@ -519,7 +519,7 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
         this.customDialog.selectedOperator = eventArgs.newSelection.value;
         eventArgs.cancel = true;
         if (this.overlayComponentId) {
-            this.mainDropdown.nativeElement.style.display = 'none';
+            this.element.nativeElement.style.display = 'none';
         }
         this.subMenu.close();
         this.customDialog.open(this.mainDropdown.nativeElement);

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

@@ -229,13 +229,6 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
 
             expect(grid.rowList.length).toEqual(3);
             verifyFilterRowUI(input, close, reset, false);
-
-            // greater than or equal to with invalid value should not reset filter
-            GridFunctions.openFilterDDAndSelectCondition(fix, 4);
-            GridFunctions.typeValueInFilterRowInput('254..', fix, input);
-
-            expect(grid.rowList.length).toEqual(3);
-            verifyFilterRowUI(input, close, reset, false);
         }));
 
         // UI tests boolean column