Skip to content

Commit 3862b66

Browse files
committed
fix(i18n): Fixes to wrong locale prop used and DatePipe.
1 parent c28c44d commit 3862b66

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

projects/igniteui-angular/src/lib/core/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { NEVER, Observable, Subject } from 'rxjs';
1212
import { setImmediate } from './setImmediate';
1313
import { isDevMode } from '@angular/core';
1414
import type { IgxTheme } from '../services/theme/theme.token';
15-
import { DateTimeFormat, getI18nManager, IntlDateTimeStyleValues, IResourceChangeEventArgs } from 'igniteui-i18n-core';
15+
import { getI18nManager, IntlDateTimeStyleValues, IResourceChangeEventArgs } from 'igniteui-i18n-core';
1616

1717
/** @hidden @internal */
1818
export const ELEMENTS_TOKEN = /*@__PURE__*/new InjectionToken<boolean>('elements environment');

projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ export class IgxDateRangePickerComponent extends PickerBaseDirective
10801080

10811081
protected override onResourceChange(args: CustomEvent<IResourceChangeEventArgs>) {
10821082
super.onResourceChange(args);
1083-
this._resourceStrings = getCurrentResourceStrings(DateRangePickerResourceStringsEN, false);
1083+
this._defaultResourceStrings = getCurrentResourceStrings(DateRangePickerResourceStringsEN, false);
10841084
if (this.hasProjectedInputs) {
10851085
this.updateInputLocale();
10861086
this.updateDisplayFormat();

projects/igniteui-angular/src/lib/list/list.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ export class IgxListComponent extends IgxListBaseDirective {
467467
constructor(public element: ElementRef) {
468468
super(element);
469469
onResourceChangeHandle(this._destroyRef, () => {
470-
this._resourceStrings = getCurrentResourceStrings(ListResourceStringsEN, false);
470+
this._defaultResourceStrings = getCurrentResourceStrings(ListResourceStringsEN, false);
471471
}, this);
472472
}
473473

projects/igniteui-angular/src/lib/services/exporter-common/base-export-service.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { EventEmitter } from '@angular/core';
2-
import { cloneArray, cloneValue, columnFieldPath, getCurrencyCode, IBaseEventArgs, resolveNestedPath, yieldingLoop } from '../../core/utils';
2+
import { cloneArray, cloneValue, columnFieldPath, formatDate, getCurrencyCode, IBaseEventArgs, resolveNestedPath, yieldingLoop } from '../../core/utils';
33
import { GridColumnDataType, DataUtil } from '../../data-operations/data-util';
44
import { ExportUtilities } from './export-utilities';
55
import { IgxExporterOptionsBase } from './exporter-options-base';
@@ -9,7 +9,7 @@ import { IGroupingState } from '../../data-operations/groupby-state.interface';
99
import { getHierarchy, isHierarchyMatch } from '../../data-operations/operations';
1010
import { IGroupByExpandState } from '../../data-operations/groupby-expand-state.interface';
1111
import { IFilteringState } from '../../data-operations/filtering-state.interface';
12-
import { DatePipe, FormatWidth, getLocaleDateFormat, getLocaleDateTimeFormat } from '@angular/common';
12+
import { FormatWidth, getLocaleDateFormat, getLocaleDateTimeFormat } from '@angular/common';
1313
import { IGroupByRecord } from '../../data-operations/groupby-record.interface';
1414
import { ColumnType, GridType, IPathSegment } from '../../grids/common/grid.interface';
1515
import { FilterUtil } from '../../data-operations/filtering-strategy';
@@ -1057,8 +1057,7 @@ export abstract class IgxBaseExporter {
10571057
if (isDate) {
10581058
const timeZoneOffset = recordVal.getTimezoneOffset() * 60000;
10591059
const isoString = (new Date(recordVal - timeZoneOffset)).toISOString();
1060-
const pipe = new DatePipe(grid.locale);
1061-
recordVal = pipe.transform(isoString);
1060+
recordVal = formatDate(isoString, 'mediumDate', grid.locale);
10621061
}
10631062

10641063
const groupExpressionName = record.column && record.column.header ?

0 commit comments

Comments
 (0)