Skip to content

Commit 3d03a0a

Browse files
committed
chore(combo): temporary revert filterable migration
1 parent 98f4df0 commit 3d03a0a

File tree

3 files changed

+0
-44
lines changed

3 files changed

+0
-44
lines changed

projects/igniteui-angular/migrations/update-18_0_0/changes/inputs.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,6 @@
161161
"selector": "igx-pivot-grid",
162162
"type": "component"
163163
}
164-
},
165-
{
166-
"name": "filterable",
167-
"replaceWith": "filteringOptions",
168-
"valueTransform": "comboFilteringTransform",
169-
"owner": {
170-
"selector": "igx-combo",
171-
"type": "component"
172-
}
173164
}
174165
]
175166
}

projects/igniteui-angular/migrations/update-18_0_0/index.spec.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -507,24 +507,4 @@ public onBannerOpened(event: BannerEventArgs) {
507507
tree.readContent('/testSrc/appPrefix/component/expansion-test.component.ts')
508508
).toEqual(expectedContent);
509509
});
510-
511-
it('should replace Combo property `filterable` with `filteringOptions`', async () => {
512-
appTree.create(`/testSrc/appPrefix/component/test.component.html`,
513-
`
514-
<igx-combo [filterable]="false"></igx-combo>
515-
<igx-combo filterable="true"></igx-combo>
516-
<igx-combo [filterable]="myProp"></igx-combo>
517-
`
518-
);
519-
520-
const tree = await schematicRunner.runSchematic(migrationName, { shouldInvokeLS: false }, appTree);
521-
522-
expect(tree.readContent('/testSrc/appPrefix/component/test.component.html')).toEqual(
523-
`
524-
<igx-combo [filteringOptions]="{ filterable: false }"></igx-combo>
525-
<igx-combo [filteringOptions]="{ filterable: true }"></igx-combo>
526-
<igx-combo [filteringOptions]="{ filterable: myProp }"></igx-combo>
527-
`
528-
);
529-
});
530510
});

projects/igniteui-angular/migrations/update-18_0_0/index.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -77,21 +77,6 @@ export default (): Rule => async (host: Tree, context: SchematicContext) => {
7777
}
7878
});
7979

80-
update.addValueTransform('comboFilteringTransform', (args: BoundPropertyObject): void => {
81-
args.bindingType = InputPropertyType.EVAL;
82-
83-
switch (args.value) {
84-
case 'true':
85-
args.value = '{ filterable: true }';
86-
break;
87-
case 'false':
88-
args.value = '{ filterable: false }';
89-
break;
90-
default:
91-
args.value = `{ filterable: ${args.value} }`;
92-
}
93-
});
94-
9580
const updateMainCSSFile = (host: Tree, context: SchematicContext): Tree => {
9681
const angularConfigBuffer = host.read('angular.json');
9782
if (!angularConfigBuffer) {

0 commit comments

Comments
 (0)