Skip to content

Commit 4317953

Browse files
authored
Merge branch 'master' into mkirova/fix-6239
2 parents a6f598a + 7565799 commit 4317953

File tree

7 files changed

+12
-16
lines changed

7 files changed

+12
-16
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ All notable changes for each version of this project will be documented in this
1313
- `IgxRowComponent` -> `IgxRowDirective`
1414
- `IgxHierarchicalGridBaseComponent` -> `IgxHierarchicalGridBaseDirective`
1515
- `IgxMonthPickerBase` -> `IgxMonthPickerBaseDirective`
16-
- `IgxBaseExporter` -> `IgxBaseExporterDirective`
1716

1817
- `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
1918
- **Behavioral Change** - Pinning columns is no longer automatically prevented when the pinning area would exceed the size of the grid.

projects/igniteui-angular/src/lib/grids/common/events.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { IBaseEventArgs, CancelableEventArgs } from '../../core/utils';
2-
import { IgxBaseExporterDirective, IgxExporterOptionsBase } from '../../services';
2+
import { IgxBaseExporter, IgxExporterOptionsBase } from '../../services';
33
import { GridKeydownTargetType } from './enums';
44
import { IgxDragDirective } from '../../directives/drag-drop/drag-drop.directive';
55
import { IGridDataBindable } from './grid.interface';
@@ -70,7 +70,7 @@ export interface ISearchInfo {
7070

7171
export interface IGridToolbarExportEventArgs extends IBaseEventArgs {
7272
grid: IgxGridBaseDirective;
73-
exporter: IgxBaseExporterDirective;
73+
exporter: IgxBaseExporter;
7474
options: IgxExporterOptionsBase;
7575
cancel: boolean;
7676
}

projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
import { IDisplayDensityOptions, DisplayDensityToken, DisplayDensityBase } from '../../core/displayDensity';
1313
import {
1414
CsvFileTypes,
15-
IgxBaseExporterDirective,
15+
IgxBaseExporter,
1616
IgxCsvExporterOptions,
1717
IgxCsvExporterService,
1818
IgxExcelExporterOptions,
@@ -309,7 +309,7 @@ export class IgxGridToolbarComponent extends DisplayDensityBase {
309309
this.performExport(this.csvExporter, 'csv');
310310
}
311311

312-
private performExport(exp: IgxBaseExporterDirective, exportType: string) {
312+
private performExport(exp: IgxBaseExporter, exportType: string) {
313313
this.exportClicked();
314314

315315
const fileName = 'ExportedData';

projects/igniteui-angular/src/lib/services/csv/csv-exporter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { EventEmitter, Injectable, Output } from '@angular/core';
2-
import { IgxBaseExporterDirective } from '../exporter-common/base-export-service';
2+
import { IgxBaseExporter } from '../exporter-common/base-export-service';
33
import { ExportUtilities } from '../exporter-common/export-utilities';
44
import { CharSeparatedValueData } from './char-separated-value-data';
55
import { CsvFileTypes, IgxCsvExporterOptions } from './csv-exporter-options';
@@ -32,7 +32,7 @@ export interface ICsvExportEndedEventArgs extends IBaseEventArgs {
3232
* ```
3333
*/
3434
@Injectable()
35-
export class IgxCsvExporterService extends IgxBaseExporterDirective {
35+
export class IgxCsvExporterService extends IgxBaseExporter {
3636
private _stringData: string;
3737

3838
/**

projects/igniteui-angular/src/lib/services/excel/excel-exporter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { ExcelElementsFactory } from './excel-elements-factory';
55
import { ExcelFolderTypes } from './excel-enums';
66
import { IgxExcelExporterOptions } from './excel-exporter-options';
77
import { IExcelFolder } from './excel-interfaces';
8-
import { IgxBaseExporterDirective } from '../exporter-common/base-export-service';
8+
import { IgxBaseExporter } from '../exporter-common/base-export-service';
99
import { ExportUtilities } from '../exporter-common/export-utilities';
1010
import { WorksheetData } from './worksheet-data';
1111
import { IBaseEventArgs } from '../../core/utils';
@@ -36,7 +36,7 @@ export interface IExcelExportEndedEventArgs extends IBaseEventArgs {
3636
* ```
3737
*/
3838
@Injectable()
39-
export class IgxExcelExporterService extends IgxBaseExporterDirective {
39+
export class IgxExcelExporterService extends IgxBaseExporter {
4040

4141
private static ZIP_OPTIONS = { compression: 'DEFLATE', type: 'base64' };
4242
private _xlsx: JSZip;

projects/igniteui-angular/src/lib/services/exporter-common/base-export-service.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { EventEmitter, Output, Directive } from '@angular/core';
1+
import { EventEmitter } from '@angular/core';
22

33
import { cloneValue, IBaseEventArgs } from '../../core/utils';
44
import { DataUtil } from '../../data-operations/data-util';
@@ -66,8 +66,7 @@ export interface IColumnExportingEventArgs extends IBaseEventArgs {
6666
skipFormatter: boolean;
6767
}
6868

69-
@Directive()
70-
export abstract class IgxBaseExporterDirective {
69+
export abstract class IgxBaseExporter {
7170
private _columnList: any[];
7271
private flatRecords = [];
7372

@@ -84,7 +83,6 @@ export abstract class IgxBaseExporterDirective {
8483
* ```
8584
* @memberof IgxBaseExporter
8685
*/
87-
@Output()
8886
public onRowExport = new EventEmitter<IRowExportingEventArgs>();
8987

9088
/**
@@ -96,7 +94,6 @@ export abstract class IgxBaseExporterDirective {
9694
* ```
9795
* @memberof IgxBaseExporter
9896
*/
99-
@Output()
10097
public onColumnExport = new EventEmitter<IColumnExportingEventArgs>();
10198

10299
/**

src/app/grid/grid.sample.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
IgxToastComponent,
88
SortingDirection,
99
CsvFileTypes,
10-
IgxBaseExporterDirective,
10+
IgxBaseExporter,
1111
IgxCsvExporterOptions,
1212
IgxCsvExporterService,
1313
IgxExcelExporterOptions,
@@ -250,7 +250,7 @@ export class GridSampleComponent implements OnInit, AfterViewInit {
250250
this.getExporterService().exportData(this.grid3.data, this.getOptions('Data'));
251251
}
252252

253-
private getExporterService(): IgxBaseExporterDirective {
253+
private getExporterService(): IgxBaseExporter {
254254
return this.exportFormat === 'XLSX' ? this.excelExporterService : this.csvExporterService;
255255
}
256256

0 commit comments

Comments
 (0)