Skip to content

Commit 43d2404

Browse files
committed
fix(csv-exporter): use arrays instead of strings to build data #6673
1 parent 6ba049b commit 43d2404

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

projects/igniteui-angular/ng-package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"whitelistedNonPeerDependencies": [
99
"@types/hammerjs",
1010
"@types/jszip",
11-
"core-js",
11+
"core-js-pure",
1212
"hammerjs",
1313
"jszip",
1414
"resize-observer-polyfill",

projects/igniteui-angular/ng-package.prod.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"whitelistedNonPeerDependencies": [
1111
"@types/hammerjs",
1212
"@types/jszip",
13-
"core-js",
13+
"core-js-pure",
1414
"hammerjs",
1515
"jszip",
1616
"resize-observer-polyfill",

projects/igniteui-angular/src/lib/services/csv/char-separated-value-data.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,23 +85,26 @@ export class CharSeparatedValueData {
8585
}
8686

8787
private processDataRecords(currentData, keys, escapeChars) {
88-
let dataRecords = '';
89-
for (const row of currentData) {
90-
dataRecords += this.processRecord(row, keys, escapeChars);
88+
const dataRecords = new Array(currentData.length);
89+
90+
for (let i = 0; i < currentData.length; i++) {
91+
const row = currentData[i]
92+
dataRecords[i] = this.processRecord(row, keys, escapeChars);
9193
}
9294

93-
return dataRecords;
95+
return dataRecords.join('');
9496
}
9597

9698
private processDataRecordsAsync(currentData, keys, escapeChars, done: (result: string) => void) {
97-
let dataRecords = '';
99+
const dataRecords = new Array(currentData.length);
100+
98101
yieldingLoop(currentData.length, 1000,
99102
(i) => {
100103
const row = currentData[i];
101-
dataRecords += this.processRecord(row, keys, escapeChars);
104+
dataRecords[i] = this.processRecord(row, keys, escapeChars);
102105
},
103106
() => {
104-
done(dataRecords);
107+
done(dataRecords.join(''));
105108
});
106109
}
107110

0 commit comments

Comments
 (0)