Skip to content

Commit 446ae32

Browse files
Ivan KitanovIvan Kitanov
authored andcommitted
chore(combo): Updating changelog and removing unnecessary code
1 parent 0ef89e5 commit 446ae32

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

CHANGELOG.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@
22

33
All notable changes for each version of this project will be documented in this file.
44

5-
## 19.2.0
6-
7-
### New Features
5+
## 19.2.14
6+
### General
87
- `IgxSimpleCombo`
9-
- Added `disableFiltering` to the `IgxSimpleCombo`, which enables/disables the filtering in the list. The default is `false`.
8+
- Added `disableFiltering` to the `IgxSimpleCombo`, which enables/disables the filtering in the list. The default is `false`. With this introduction, `filteringOptions.filterable` is no longer usde.
9+
- `IgxCombo`, `IgxSimpleCombo`
10+
- Removed deprecated `filteringOptions.filterable` option.
11+
12+
## 19.2.0
1013

1114
### General
1215
- `IgxCarousel`

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,7 +1234,6 @@ describe('IgxSimpleCombo', () => {
12341234
combo.disableFiltering = true;
12351235
fixture.detectChanges();
12361236
combo.focusSearchInput();
1237-
expect(combo.filteredData.length).toEqual(combo.data.length);
12381237

12391238
UIInteractions.simulateTyping('con', input);
12401239
expect(combo.comboInput.value).toEqual('con');
@@ -1247,7 +1246,9 @@ describe('IgxSimpleCombo', () => {
12471246
combo.disableFiltering = false;
12481247
fixture.detectChanges();
12491248
combo.focusSearchInput();
1250-
expect(combo.filteredData.length).toEqual(combo.data.length);
1249+
1250+
combo.comboInput.value = '';
1251+
fixture.detectChanges();
12511252
UIInteractions.simulateTyping('con', input);
12521253
expect(combo.comboInput.value).toEqual('con');
12531254
fixture.detectChanges();

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { DOCUMENT, NgTemplateOutlet } from '@angular/common';
22
import {
3-
AfterViewInit, booleanAttribute, ChangeDetectorRef, Component, DoCheck, ElementRef, EventEmitter, HostListener, Inject, Injector,
4-
Input,
3+
AfterViewInit, ChangeDetectorRef, Component, DoCheck, ElementRef, EventEmitter, HostListener, Inject, Injector,
54
Optional, Output, ViewChild
65
} from '@angular/core';
76
import { ControlValueAccessor, FormGroupDirective, NG_VALUE_ACCESSOR } from '@angular/forms';
@@ -292,10 +291,6 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
292291
this.open();
293292
}
294293

295-
if (this.disableFiltering) {
296-
return;
297-
}
298-
299294
if (event !== undefined) {
300295
this.filterValue = this.searchValue = typeof event === 'string' ? event : event.target.value;
301296
}

0 commit comments

Comments
 (0)