refactor(overlay): apply requested changes

Author: jackofdiamond5

CHANGELOG.md

@@ -9,6 +9,8 @@ All notable changes for each version of this project will be documented in this
     - **Behavioral Change** - Change default positioning strategy from `ConnectedPositioningStrategy` to `AutoPositionStrategy`. The [`Auto`](https://www.infragistics.com/products/ignite-ui-angular/angular/components/overlay_position.html#auto) strategy will initially try to show the element like the Connected strategy does. If the element goes out of the viewport Auto will flip the starting point and the direction, i.e. if the direction is 'bottom', it will switch it to 'top' and so on. If after flipping direction the content goes out of the view, auto strategy will revert to initial start point and direction and will push the content into the view. Note after pushing the content it may hide the combo's input.
 - `IgxOverlay`
     - Added new property - `closeOnEsc` - in `OverlaySettings`. The overlay can now be prevented from closing, on escape keypress, by setting the property to `false`, by default it's `true`.
+- `igxDialog`
+    - Added `closeOnEscapeKey` - with it, the dialog can be allowed or prevented from closing when `Esc` is pressed.
 ### New Features
 - `IgxGridState` directive
     - Added support for expansion states, column selection and row pinning.

projects/igniteui-angular/src/lib/combo/combo.component.ts

@@ -156,7 +156,6 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
     private _overlaySettings: OverlaySettings = {
         scrollStrategy: new AbsoluteScrollStrategy(),
         positionStrategy: new AutoPositionStrategy(),
-        closeOnEsc: true,
         modal: false,
         closeOnOutsideClick: true,
         excludePositionTarget: true

projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts

@@ -402,12 +402,10 @@ export class IgxDateRangePickerComponent extends DisplayDensityBase
     private _focusedInput: IgxDateRangeInputsBaseComponent;
     private _dialogOverlaySettings: OverlaySettings = {
         closeOnOutsideClick: true,
-        closeOnEsc: true,
         modal: true
     };
     private _dropDownOverlaySettings: OverlaySettings = {
         closeOnOutsideClick: true,
-        closeOnEsc: true,
         modal: false
     };
     private onChangeCallback = (dateRange: DateRange) => { };

projects/igniteui-angular/src/lib/dialog/dialog.component.ts

@@ -414,7 +414,7 @@ export class IgxDialogComponent implements IToggleView, OnInit, OnDestroy, After
             positionStrategy: new GlobalPositionStrategy(this._positionSettings),
             scrollStrategy: new NoOpScrollStrategy(),
             modal: this.isModal,
-            closeOnEsc: true,
+            closeOnEsc: this._closeOnEscapeKey,
             closeOnOutsideClick: this.closeOnOutsideSelect
         };
     }

projects/igniteui-angular/src/lib/directives/autocomplete/autocomplete.directive.ts

@@ -86,7 +86,6 @@ export class IgxAutocompleteDirective extends IgxDropDownItemNavigationDirective
 
     private defaultSettings: OverlaySettings = {
         modal: false,
-        closeOnEsc: true,
         scrollStrategy: new AbsoluteScrollStrategy(),
         positionStrategy: new AutoPositionStrategy({ target: this.parentElement }),
         excludePositionTarget: true

projects/igniteui-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.ts

@@ -136,7 +136,6 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
     private _overlaySettings: OverlaySettings = {
         closeOnOutsideClick: false,
         modal: false,
-        closeOnEsc: true,
         positionStrategy: new ConnectedPositioningStrategy(this._positionSettings),
         scrollStrategy: new CloseScrollStrategy()
     };
@@ -147,7 +146,6 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
     public columnSelectOverlaySettings: OverlaySettings = {
         scrollStrategy: new AbsoluteScrollStrategy(),
         modal: false,
-        closeOnEsc: true,
         closeOnOutsideClick: false,
         excludePositionTarget: true
     };
@@ -158,7 +156,6 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
     public conditionSelectOverlaySettings: OverlaySettings = {
         scrollStrategy: new AbsoluteScrollStrategy(),
         modal: false,
-        closeOnEsc: true,
         closeOnOutsideClick: false,
         excludePositionTarget: true
     };

projects/igniteui-angular/src/lib/grids/filtering/base/grid-filtering-row.component.ts

@@ -47,7 +47,6 @@ export class IgxGridFilteringRowComponent implements AfterViewInit {
         excludePositionTarget: true,
         closeOnOutsideClick: true,
         modal: false,
-        closeOnEsc: true,
         scrollStrategy: new AbsoluteScrollStrategy(),
         positionStrategy: new ConnectedPositioningStrategy(this._positionSettings)
     };
@@ -56,7 +55,6 @@ export class IgxGridFilteringRowComponent implements AfterViewInit {
         excludePositionTarget: true,
         closeOnOutsideClick: true,
         modal: false,
-        closeOnEsc: true,
         scrollStrategy: new AbsoluteScrollStrategy(),
         positionStrategy: new ConnectedPositioningStrategy(this._positionSettings)
     };

projects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-default-expression.component.ts

@@ -43,7 +43,6 @@ export class IgxExcelStyleDefaultExpressionComponent implements AfterViewInit {
     public dropDownOverlaySettings: OverlaySettings = {
         scrollStrategy: new AbsoluteScrollStrategy(),
         modal: false,
-        closeOnEsc: true,
         closeOnOutsideClick: true,
         excludePositionTarget: true
     };

projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts

@@ -209,7 +209,6 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
     private _subMenuOverlaySettings: OverlaySettings = {
         closeOnOutsideClick: true,
         modal: false,
-        closeOnEsc: true,
         positionStrategy: new AutoPositionStrategy(this._subMenuPositionSettings),
         scrollStrategy: new AbsoluteScrollStrategy()
     };

projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts

@@ -90,7 +90,6 @@ export class IgxFilteringService implements OnDestroy {
         this._filterMenuOverlaySettings = {
             closeOnOutsideClick: true,
             modal: false,
-            closeOnEsc: true,
             positionStrategy: new ExcelStylePositionStrategy(this._filterMenuPositionSettings),
             scrollStrategy: new AbsoluteScrollStrategy()
         };