Skip to content

Commit 46a0bcc

Browse files
committed
Merge remote-tracking branch 'remotes/origin/master' into mvenkov/handle_correctly_target_as_point
2 parents 91b76ec + 5e6245f commit 46a0bcc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+299
-406
lines changed

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@angular/platform-browser": "^10.1.0",
5353
"@angular/platform-browser-dynamic": "^10.1.0",
5454
"@angular/router": "^10.1.0",
55-
"@igniteui/material-icons-extended": "^2.3.0",
55+
"@igniteui/material-icons-extended": "^2.4.0",
5656
"@types/hammerjs": "^2.0.36",
5757
"@types/source-map": "0.5.2",
5858
"classlist.js": "^1.1.20150312",

projects/igniteui-angular/ng-package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"resize-observer-polyfill",
1313
"igniteui-trial-watermark",
1414
"lodash.merge",
15-
"uuid"
15+
"uuid",
16+
"@igniteui/material-icons-extended"
1617
]
1718
}

projects/igniteui-angular/ng-package.prod.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"resize-observer-polyfill",
1515
"igniteui-trial-watermark",
1616
"lodash.merge",
17-
"uuid"
17+
"uuid",
18+
"@igniteui/material-icons-extended"
1819
]
1920
}

projects/igniteui-angular/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
"resize-observer-polyfill": "^1.5.1",
7474
"igniteui-trial-watermark": "^1.0.3",
7575
"lodash.merge": "^4.6.2",
76-
"uuid": "^8.3.0"
76+
"uuid": "^8.3.0",
77+
"@igniteui/material-icons-extended": "^2.4.0"
7778
},
7879
"peerDependencies": {
7980
"@angular/common": "^10.0.0",

projects/igniteui-angular/schematics/utils/dependency-handler.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,13 @@ export const DEPENDENCIES_MAP: PackageEntry[] = [
3131
{ name: 'igniteui-trial-watermark', target: PackageTarget.NONE },
3232
{ name: 'lodash.merge', target: PackageTarget.NONE },
3333
{ name: 'uuid', target: PackageTarget.NONE },
34+
{ name: 'web-animations-js', target: PackageTarget.REGULAR },
35+
{ name: '@igniteui/material-icons-extended', target: PackageTarget.REGULAR },
3436
// peerDependencies
3537
{ name: '@angular/forms', target: PackageTarget.NONE },
3638
{ name: '@angular/common', target: PackageTarget.NONE },
3739
{ name: '@angular/core', target: PackageTarget.NONE },
3840
{ name: '@angular/animations', target: PackageTarget.NONE },
39-
{ name: 'web-animations-js', target: PackageTarget.REGULAR },
4041
// igxDevDependencies
4142
{ name: '@igniteui/angular-schematics', target: PackageTarget.DEV }
4243
];

projects/igniteui-angular/src/lib/action-strip/action-strip.component.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,13 @@ export class IgxActionStripComponent extends DisplayDensityBase implements After
147147
@ContentChildren(IgxGridActionsBaseDirective)
148148
public actionButtons: QueryList<IgxGridActionsBaseDirective>;
149149

150+
/**
151+
* Getter for menu overlay settings
152+
* @hidden
153+
* @internal
154+
*/
155+
public menuOverlaySettings: OverlaySettings = { scrollStrategy: new CloseScrollStrategy() };
156+
150157
/**
151158
* Menu Items list.
152159
* @hidden
@@ -243,15 +250,6 @@ export class IgxActionStripComponent extends DisplayDensityBase implements After
243250
}
244251
}
245252

246-
/**
247-
* Getter for menu overlay settings
248-
* @hidden
249-
* @internal
250-
*/
251-
get menuOverlaySettings (): OverlaySettings {
252-
return { scrollStrategy: new CloseScrollStrategy() };
253-
}
254-
255253
/**
256254
* Close the menu if opened
257255
* @hidden

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-actions-base.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgxGridActionButtonComponent } from './grid-action-button.component';
33
import { Directive, Inject, Input, AfterViewInit, QueryList, ViewChildren,
44
OnInit, IterableDiffers, IterableChangeRecord, OnDestroy } from '@angular/core';
55
import { IgxActionStripComponent } from '../action-strip.component';
6-
import { IgxRowDirective } from '../../grids/public_api';
6+
import { IgxRowDirective } from '../../grids/row.directive';
77
import { IgxIconService } from '../../icon/icon.service';
88
import { Subject } from 'rxjs';
99

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts

Lines changed: 94 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ import { IgxGridModule, IgxGridComponent } from '../../grids/grid/public_api';
77
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
88
import { By } from '@angular/platform-browser';
99
import { IgxActionStripModule } from '../action-strip.module';
10+
import { UIInteractions } from '../../test-utils/ui-interactions.spec';
11+
import { IgxHierarchicalGridActionStripComponent } from '../../test-utils/hierarchical-grid-components.spec';
12+
import { IgxHierarchicalRowComponent, IgxHierarchicalGridComponent, IgxHierarchicalGridModule } from '../../grids/hierarchical-grid/public_api';
1013

1114
describe('igxGridEditingActions #grid ', () => {
1215
let fixture;
@@ -18,12 +21,14 @@ describe('igxGridEditingActions #grid ', () => {
1821
declarations: [
1922
IgxActionStripTestingComponent,
2023
IgxActionStripPinEditComponent,
21-
IgxActionStripEditMenuComponent
24+
IgxActionStripEditMenuComponent,
25+
IgxHierarchicalGridActionStripComponent
2226
],
2327
imports: [
2428
NoopAnimationsModule,
2529
IgxActionStripModule,
2630
IgxGridModule,
31+
IgxHierarchicalGridModule,
2732
IgxIconModule
2833
]
2934
}).compileComponents();
@@ -114,6 +119,94 @@ describe('igxGridEditingActions #grid ', () => {
114119
expect(pinningIcons[0].nativeElement.className.indexOf('igx-button--disabled') === -1).toBeTruthy();
115120
});
116121
});
122+
123+
describe('auto show/hide', () => {
124+
beforeEach(fakeAsync(/** height/width setter rAF */() => {
125+
fixture = TestBed.createComponent(IgxActionStripPinEditComponent);
126+
fixture.detectChanges();
127+
actionStrip = fixture.componentInstance.actionStrip;
128+
grid = fixture.componentInstance.grid;
129+
}));
130+
it('should auto-show on mouse over of row.', () => {
131+
const row = grid.getRowByIndex(0);
132+
const rowElem = row.nativeElement;
133+
UIInteractions.simulateMouseEvent('mouseover', rowElem, 0, 0);
134+
fixture.detectChanges();
135+
136+
expect(actionStrip.context).toBe(row);
137+
expect(actionStrip.hidden).toBeFalse();
138+
});
139+
it('should auto-hide on mouse leave of grid.', () => {
140+
const row = grid.getRowByIndex(0);
141+
actionStrip.show(row);
142+
fixture.detectChanges();
143+
144+
expect(actionStrip.hidden).toBeFalse();
145+
UIInteractions.simulateMouseEvent('mouseleave', grid.nativeElement, 0, 0);
146+
fixture.detectChanges();
147+
148+
expect(actionStrip.hidden).toBeTrue();
149+
});
150+
});
151+
152+
describe('auto show/hide in HierarchicalGrid', () => {
153+
let actionStripRoot, actionStripChild, hierarchicalGrid: IgxHierarchicalGridComponent;
154+
beforeEach(fakeAsync(/** height/width setter rAF */() => {
155+
fixture = TestBed.createComponent(IgxHierarchicalGridActionStripComponent);
156+
fixture.detectChanges();
157+
actionStripRoot = fixture.componentInstance.actionStripRoot;
158+
actionStripChild = fixture.componentInstance.actionStripChild;
159+
hierarchicalGrid = fixture.componentInstance.hgrid;
160+
}));
161+
162+
it('should auto-show root actionStrip on mouse over of root row.', () => {
163+
const row = hierarchicalGrid.getRowByIndex(0);
164+
const rowElem = row.nativeElement;
165+
UIInteractions.simulateMouseEvent('mouseover', rowElem, 0, 0);
166+
fixture.detectChanges();
167+
168+
expect(actionStripRoot.context).toBe(row);
169+
expect(actionStripRoot.hidden).toBeFalse();
170+
expect(actionStripChild.context).toBeUndefined();
171+
});
172+
173+
it('should auto-show row island actionStrip on mouse over of child row.', () => {
174+
const row = hierarchicalGrid.getRowByIndex(0) as IgxHierarchicalRowComponent;
175+
row.toggle();
176+
fixture.detectChanges();
177+
178+
const childGrid = hierarchicalGrid.hgridAPI.getChildGrids(false)[1];
179+
180+
const childRow = childGrid.getRowByIndex(0);
181+
const rowElem = childRow.nativeElement;
182+
UIInteractions.simulateMouseEvent('mouseover', rowElem, 0, 0);
183+
fixture.detectChanges();
184+
185+
expect(actionStripChild.context).toBe(childRow);
186+
expect(actionStripChild.hidden).toBeFalse();
187+
188+
expect(actionStripRoot.context).toBeUndefined();
189+
});
190+
191+
it('should auto-hide all actionStrip on mouse leave of root grid.', () => {
192+
const row = hierarchicalGrid.getRowByIndex(0) as IgxHierarchicalRowComponent;
193+
row.toggle();
194+
fixture.detectChanges();
195+
196+
const childGrid = hierarchicalGrid.hgridAPI.getChildGrids(false)[0];
197+
const childRow = childGrid.getRowByIndex(0);
198+
199+
actionStripRoot.show(row);
200+
actionStripChild.show(childRow);
201+
fixture.detectChanges();
202+
203+
UIInteractions.simulateMouseEvent('mouseleave', hierarchicalGrid.nativeElement, 0, 0);
204+
fixture.detectChanges();
205+
206+
expect(actionStripRoot.hidden).toBeTrue();
207+
expect(actionStripChild.hidden).toBeTrue();
208+
});
209+
});
117210
});
118211

119212
@Component({

projects/igniteui-angular/src/lib/combo/combo.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
(keydown)="handleKeyDown($event)" (focus)="dropdown.onBlur($event)" [attr.placeholder]="searchPlaceholder"
4141
aria-autocomplete="both" [attr.aria-owns]="dropdown.id" [attr.aria-labelledby]="ariaLabelledBy" />
4242
<igx-suffix *ngIf="showSearchCaseIcon">
43-
<igx-icon fontSet="case-sensitive" name="case-sensitive" [isActive]="filteringOptions.caseSensitive"
43+
<igx-icon fontSet="imx-icons" name="case-sensitive" [isActive]="filteringOptions.caseSensitive"
4444
(click)="toggleCaseSensitive()">
4545
</igx-icon>
4646
</igx-suffix>

0 commit comments

Comments
 (0)