Skip to content

Commit 488b745

Browse files
authored
Merge branch '8.2.x' into rkaraivanov/radio-group-fix-82
2 parents f41de24 + 16283d7 commit 488b745

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-advanced.spec.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -540,10 +540,12 @@ describe('IgxGrid - Advanced Filtering', () => {
540540
fix.detectChanges();
541541

542542
// Verify the filter results.
543-
expect(grid.filteredData.length).toEqual(6);
544-
expect(grid.rowList.length).toBe(6);
545-
expect(GridFunctions.getCurrentCellFromGrid(grid, 0, 1).value).toBe('Ignite UI for JavaScript');
546-
expect(GridFunctions.getCurrentCellFromGrid(grid, 1, 1).value).toBe('NetAdvantage');
543+
const expectedData = fix.componentInstance.data.filter(r =>
544+
r.ReleaseDate && r.ReleaseDate.getFullYear() === (new Date()).getFullYear());
545+
expect(grid.filteredData.length).toEqual(expectedData.length);
546+
expect(grid.rowList.length).toBe(expectedData.length);
547+
expect(GridFunctions.getCurrentCellFromGrid(grid, 0, 1).value).toBe(expectedData[0].ProductName);
548+
expect(GridFunctions.getCurrentCellFromGrid(grid, 1, 1).value).toBe(expectedData[1].ProductName);
547549
}));
548550

549551
it('Should correctly filter by a \'date\' column through UI with value from calendar.', fakeAsync(() => {

projects/igniteui-angular/src/lib/services/overlay/overlay.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -817,19 +817,15 @@ describe('igxOverlay', () => {
817817
spyOn(scrollStrat, 'attach').and.callThrough();
818818
spyOn(scrollStrat, 'detach').and.callThrough();
819819
const scrollSpy = spyOn<any>(scrollStrat, 'onScroll').and.callThrough();
820-
const wheelSpy = spyOn<any>(scrollStrat, 'onWheel').and.callThrough();
821820
overlay.show(SimpleDynamicComponent, overlaySettings);
822821
tick();
823822

824823
expect(scrollStrat.attach).toHaveBeenCalledTimes(1);
825824
expect(scrollStrat.initialize).toHaveBeenCalledTimes(1);
826825
expect(scrollStrat.detach).toHaveBeenCalledTimes(0);
827826
document.dispatchEvent(new Event('scroll'));
828-
829827
expect(scrollSpy).toHaveBeenCalledTimes(1);
830828

831-
document.dispatchEvent(new Event('wheel'));
832-
expect(wheelSpy).toHaveBeenCalledTimes(1);
833829
overlay.hide('0');
834830
tick();
835831
expect(scrollStrat.detach).toHaveBeenCalledTimes(1);

projects/igniteui-angular/src/lib/services/overlay/scroll/block-scroll-strategy.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,11 @@ export class BlockScrollStrategy extends ScrollStrategy {
2828
/** @inheritdoc */
2929
public attach(): void {
3030
this._document.addEventListener('scroll', this.onScroll, true);
31-
this._document.addEventListener('wheel', this.onWheel, true);
3231
}
3332

3433
/** @inheritdoc */
3534
public detach(): void {
3635
this._document.removeEventListener('scroll', this.onScroll, true);
37-
this._document.removeEventListener('wheel', this.onWheel, true);
3836
this._sourceElement = null;
3937
this._initialScrollTop = 0;
4038
this._initialScrollLeft = 0;
@@ -52,9 +50,4 @@ export class BlockScrollStrategy extends ScrollStrategy {
5250
this._sourceElement.scrollTop = this._initialScrollTop;
5351
this._sourceElement.scrollLeft = this._initialScrollLeft;
5452
}
55-
56-
private onWheel(ev: WheelEvent) {
57-
ev.stopImmediatePropagation();
58-
ev.preventDefault();
59-
}
6053
}

0 commit comments

Comments
 (0)