Skip to content

Commit 4e0f39b

Browse files
authored
fix(i18n): Change advanced filtering cancel and apply buttons to start with capital letter (#15171)
1 parent e68ddc5 commit 4e0f39b

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

projects/igniteui-angular/src/lib/core/i18n/grid-resources.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,8 @@ export const GridResourceStringsEN: IGridResourceStrings = {
235235
igx_grid_excel_custom_dialog_add: 'add filter',
236236
igx_grid_excel_custom_dialog_clear: 'Clear filter',
237237
igx_grid_excel_custom_dialog_header: 'Custom auto-filter on column: ',
238-
igx_grid_excel_cancel: 'cancel',
239-
igx_grid_excel_apply: 'apply',
238+
igx_grid_excel_cancel: 'Cancel',
239+
igx_grid_excel_apply: 'Apply',
240240
igx_grid_excel_search_placeholder: 'Search',
241241
igx_grid_excel_select_all: 'Select All',
242242
igx_grid_excel_select_all_search_results: 'Select all search results',

projects/igniteui-angular/src/lib/test-utils/grid-functions.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ export class GridFunctions {
737737
public static getApplyButtonExcelStyleFiltering(fix: ComponentFixture<any>, menu = null, grid = 'igx-grid') {
738738
const excelMenu = menu ? menu : GridFunctions.getExcelStyleFilteringComponent(fix, grid);
739739
const containedButtons = Array.from(excelMenu.querySelectorAll('.igx-button--contained'));
740-
const applyButton: any = containedButtons.find((rb: any) => rb.innerText === 'apply');
740+
const applyButton: any = containedButtons.find((rb: any) => rb.innerText.toLowerCase() === 'apply');
741741
return applyButton;
742742
}
743743

@@ -749,7 +749,7 @@ export class GridFunctions {
749749
public static clickCancelExcelStyleFiltering(fix: ComponentFixture<any>, menu = null) {
750750
const excelMenu = menu ? menu : GridFunctions.getExcelStyleFilteringComponent(fix);
751751
const flatButtons = Array.from(excelMenu.querySelectorAll('.igx-button--flat'));
752-
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText === 'cancel');
752+
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText.toLowerCase() === 'cancel');
753753
cancelButton.click();
754754
}
755755

@@ -770,7 +770,7 @@ export class GridFunctions {
770770
public static getApplyExcelStyleCustomFiltering(fix: ComponentFixture<any>): HTMLElement {
771771
const customFilterMenu = GridFunctions.getExcelStyleCustomFilteringDialog(fix);
772772
const containedButtons = Array.from(customFilterMenu.querySelectorAll('.igx-button--contained'));
773-
const applyButton = containedButtons.find((rb: any) => rb.innerText === 'apply');
773+
const applyButton = containedButtons.find((rb: any) => rb.innerText.toLowerCase() === 'apply');
774774
return applyButton as HTMLElement;
775775
}
776776

@@ -803,7 +803,7 @@ export class GridFunctions {
803803
public static clickCancelExcelStyleCustomFiltering(fix: ComponentFixture<any>) {
804804
const customFilterMenu = GridFunctions.getExcelStyleCustomFilteringDialog(fix);
805805
const flatButtons = Array.from(customFilterMenu.querySelectorAll('.igx-button--flat'));
806-
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText === 'cancel');
806+
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText.toLowerCase() === 'cancel');
807807
cancelButton.click();
808808
}
809809

0 commit comments

Comments
 (0)