Skip to content

Commit 4f5e847

Browse files
authored
Merge branch 'master' into mkirova/fix-5478-8.2.x
2 parents b7642cc + 087ca0c commit 4f5e847

File tree

5 files changed

+29
-10
lines changed

5 files changed

+29
-10
lines changed

projects/igniteui-angular/src/lib/core/styles/components/navdrawer/_navdrawer-theme.scss

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,10 @@
209209
%aside--mini {
210210
width: rem(60px);
211211
transition-duration: .2s, .2s;
212+
213+
%item {
214+
justify-content: center;
215+
}
212216
}
213217

214218
%aside--normal {
@@ -251,17 +255,18 @@
251255
%item {
252256
position: relative;
253257
display: flex;
258+
align-items: center;
254259
flex-flow: row nowrap;
255260
color: --var($theme, 'item-text-color');
256261
max-height: rem(48px);
257-
padding: rem(12px) rem(16px);
262+
min-width: rem(32px);
263+
padding: rem(12px) rem(8px);
258264
cursor: pointer;
259-
align-items: center;
260265
user-select: none;
261266
outline: transparent;
262267
white-space: nowrap;
263268
border-radius: --var($theme, 'item-border-radius');
264-
margin: 8px;
269+
margin: rem(8px) rem(8px);
265270

266271
> igx-icon + span {
267272
margin-left: rem(32px);

projects/igniteui-angular/src/lib/grids/column.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2003,8 +2003,6 @@ export class IgxColumnLayoutComponent extends IgxColumnGroupComponent implements
20032003
}
20042004

20052005
this.children.forEach(child => {
2006-
child.disableHiding = true;
2007-
child.disablePinning = true;
20082006
child.movable = false;
20092007
});
20102008
}

projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.integration.spec.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,21 @@ describe('IgxGrid - multi-row-layout Integration - ', () => {
801801

802802
verifyDOMMatchesLayoutSettings(gridFirstRow, fixture.componentInstance.colGroups);
803803
});
804+
805+
it('should render unpin and hide column buttons into the excel style filter', () => {
806+
const filterIcons = fixture.debugElement.queryAll(By.css('.igx-excel-filter__icon'));
807+
expect(filterIcons.length).not.toBe(0);
808+
809+
filterIcons[0].nativeElement.click();
810+
fixture.detectChanges();
811+
812+
const excelMenu = grid.nativeElement.querySelector('.igx-excel-filter__menu');
813+
const unpinComponent = excelMenu.querySelector('.igx-excel-filter__actions-unpin');
814+
const hideComponent = excelMenu.querySelector('.igx-excel-filter__actions-hide');
815+
816+
expect(unpinComponent).toBeDefined();
817+
expect(hideComponent).toBeDefined();
818+
});
804819
});
805820

806821
describe('GroupBy ', () => {

projects/igniteui-angular/src/lib/navigation-drawer/navigation-drawer.component.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ describe('Navigation Drawer', () => {
240240
fixture.detectChanges();
241241
asideElem = fixture.debugElement.query(By.css('.igx-nav-drawer__aside'));
242242

243-
expect(asideElem.styles['width']).toEqual('60px');
243+
expect(asideElem.styles['width']).toEqual('68px');
244244

245245
fixture.componentInstance.miniView = false;
246246
fixture.detectChanges();
@@ -441,9 +441,10 @@ describe('Navigation Drawer', () => {
441441
fixture = TestBed.createComponent(TestComponentDIComponent);
442442
fixture.detectChanges();
443443

444-
fixture.componentInstance.drawerMiniWidth = 60;
444+
fixture.componentInstance.drawerMiniWidth = 68;
445445
fixture.detectChanges();
446-
expect(fixture.componentInstance.viewChild.maxEdgeZone).toBe(66);
446+
expect(fixture.componentInstance.viewChild.maxEdgeZone)
447+
.toBe(fixture.componentInstance.drawerMiniWidth * 1.1);
447448

448449
fixture.componentInstance.drawerMiniWidth = 80;
449450
fixture.detectChanges();

projects/igniteui-angular/src/lib/navigation-drawer/navigation-drawer.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ export class IgxNavigationDrawerComponent implements
183183
@Input() public width = '280px';
184184

185185
/**
186-
* Width of the drawer in its mini state. Defaults to 60px.
186+
* Width of the drawer in its mini state. Defaults to 68px.
187187
*
188188
* ```typescript
189189
* // get
@@ -195,7 +195,7 @@ export class IgxNavigationDrawerComponent implements
195195
* <igx-nav-drawer [miniWidth]="'34px'"></igx-nav-drawer>
196196
* ```
197197
*/
198-
@Input() public miniWidth = '60px';
198+
@Input() public miniWidth = '68px';
199199

200200
/**
201201
* Pinned state change output for two-way binding.

0 commit comments

Comments
 (0)