Merge branch 'master' into mkirova/fix-13583

Author: kdinev

projects/igniteui-angular/src/lib/accordion/accordion.component.ts

@@ -1,10 +1,14 @@
-import { AfterContentInit, AfterViewInit, ChangeDetectorRef, Component, ContentChildren, EventEmitter,
-    HostBinding, Input, OnDestroy, Output, QueryList } from '@angular/core';
+import {
+    AfterContentInit, AfterViewInit, ChangeDetectorRef, Component, ContentChildren, EventEmitter,
+    HostBinding, Input, OnDestroy, Output, QueryList, booleanAttribute
+} from '@angular/core';
 import { fromEvent, Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 import { ACCORDION_NAVIGATION_KEYS } from '../core/utils';
-import { IExpansionPanelCancelableEventArgs,
-    IExpansionPanelEventArgs, IgxExpansionPanelBase } from '../expansion-panel/expansion-panel.common';
+import {
+    IExpansionPanelCancelableEventArgs,
+    IExpansionPanelEventArgs, IgxExpansionPanelBase
+} from '../expansion-panel/expansion-panel.common';
 import { IgxExpansionPanelComponent } from '../expansion-panel/expansion-panel.component';
 import { ToggleAnimationSettings } from '../expansion-panel/toggle-animation-component';
 
@@ -113,7 +117,7 @@ export class IgxAccordionComponent implements AfterContentInit, AfterViewInit, O
      * this.accordion.singleBranchExpand = false;
      * ```
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public get singleBranchExpand(): boolean {
         return this._singleBranchExpand;
     }
@@ -249,7 +253,7 @@ export class IgxAccordionComponent implements AfterContentInit, AfterViewInit, O
      */
     public expandAll(): void {
         if (this.singleBranchExpand) {
-            for(let i = 0; i < this.panels.length - 1; i++) {
+            for (let i = 0; i < this.panels.length - 1; i++) {
                 this.panels[i].collapse();
             }
             this._panels.last.expand();
@@ -277,7 +281,7 @@ export class IgxAccordionComponent implements AfterContentInit, AfterViewInit, O
                 p.collapsed = true;
             }
         });
-        this.cdr.detectChanges();
+        this.cdr.markForCheck();
     }
 
     private handleKeydown(event: KeyboardEvent, panel: IgxExpansionPanelComponent): void {
@@ -325,7 +329,7 @@ export class IgxAccordionComponent implements AfterContentInit, AfterViewInit, O
                 this._enabledPanels.forEach(p => p.collapse());
             } else {
                 if (this.singleBranchExpand) {
-                    for(let i = 0; i < this._enabledPanels.length - 1; i++) {
+                    for (let i = 0; i < this._enabledPanels.length - 1; i++) {
                         this._enabledPanels[i].collapse();
                     }
                     this._enabledPanels[this._enabledPanels.length - 1].expand();

projects/igniteui-angular/src/lib/action-strip/action-strip.component.ts

@@ -14,7 +14,8 @@ import {
     AfterContentInit,
     ChangeDetectorRef,
     AfterViewInit,
-    ElementRef
+    ElementRef,
+    booleanAttribute
 } from '@angular/core';
 import { DisplayDensityBase, DisplayDensityToken, IDisplayDensityOptions } from '../core/density';
 import { ActionStripResourceStringsEN, IActionStripResourceStrings } from '../core/i18n/action-strip-resources';
@@ -120,14 +121,9 @@ export class IgxActionStripComponent extends DisplayDensityBase implements After
      *  <igx-action-strip [hidden]="false">
      * ```
      */
-    @Input()
-    public set hidden(value) {
-        this._hidden = value;
-    }
+    @Input({ transform: booleanAttribute })
+    public hidden = false;
 
-    public get hidden() {
-        return this._hidden;
-    }
 
     /**
      * Gets/Sets the resource strings.
@@ -150,13 +146,13 @@ export class IgxActionStripComponent extends DisplayDensityBase implements After
      * @hidden
      * @internal
      */
-     public get hideOnRowLeave(): boolean{
-        if(this.menu.items.length === 0){
+    public get hideOnRowLeave(): boolean {
+        if (this.menu.items.length === 0) {
             return true;
-        }else if(this.menu.items.length > 0){
-            if(this.menu.collapsed){
+        } else if (this.menu.items.length > 0) {
+            if (this.menu.collapsed) {
                 return true;
-            }else{
+            } else {
                 return false;
             }
         }
@@ -215,14 +211,14 @@ export class IgxActionStripComponent extends DisplayDensityBase implements After
     /**
      * Getter for the 'display' property of the current `IgxActionStrip`
      */
-     @HostBinding('style.display')
-     private get display(): string {
-         return this._hidden ? 'none' : 'flex';
-     }
+    @HostBinding('style.display')
+    private get display(): string {
+        return this.hidden ? 'none' : 'flex';
+    }
 
-     /**
-      * Host `attr.class` binding.
-      */
+    /**
+     * Host `attr.class` binding.
+     */
     @HostBinding('class.igx-action-strip')
     protected hostClass = 'igx-action-strip';
 

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-action-button.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, TemplateRef, ViewChild, Output, EventEmitter, ElementRef } from '@angular/core';
+import { Component, Input, TemplateRef, ViewChild, Output, EventEmitter, ElementRef, booleanAttribute } from '@angular/core';
 import { IgxIconComponent } from '../../icon/icon.component';
 import { IgxRippleDirective } from '../../directives/ripple/ripple.directive';
 import { IgxButtonDirective } from '../../directives/button/button.directive';
@@ -38,7 +38,7 @@ export class IgxGridActionButtonComponent {
     /**
      * Whether button action is rendered in menu and should container text label.
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public asMenuItem = false;
 
     /**
@@ -75,7 +75,7 @@ export class IgxGridActionButtonComponent {
      * @internal
      */
     public handleClick(event) {
-       this.actionClick.emit(event);
+        this.actionClick.emit(event);
     }
 
     /**

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-actions-base.directive.ts

@@ -1,5 +1,5 @@
 import { IgxGridActionButtonComponent } from './grid-action-button.component';
-import { Directive, Input, AfterViewInit, QueryList, ViewChildren, IterableDiffers } from '@angular/core';
+import { Directive, Input, AfterViewInit, QueryList, ViewChildren, IterableDiffers, booleanAttribute } from '@angular/core';
 import { IgxActionStripComponent } from '../action-strip.component';
 import { IgxRowDirective } from '../../grids/row.directive';
 import { IgxIconService } from '../../icon/icon.service';
@@ -22,7 +22,7 @@ export class IgxGridActionsBaseDirective implements AfterViewInit {
      *  <igx-grid-editing-actions [asMenuItems]='true'></igx-grid-editing-actions>
      * ```
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public asMenuItems = false;
 
     /** @hidden @internal **/

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.ts

@@ -1,7 +1,7 @@
-import { Component, HostBinding, Input } from '@angular/core';
+import { Component, HostBinding, Input, booleanAttribute } from '@angular/core';
 import { IgxGridActionsBaseDirective } from './grid-actions-base.directive';
 import { showMessage } from '../../core/utils';
-import { addRow, addChild  } from '@igniteui/material-icons-extended';
+import { addRow, addChild } from '@igniteui/material-icons-extended';
 import { IgxGridActionButtonComponent } from './grid-action-button.component';
 import { NgIf } from '@angular/common';
 
@@ -27,7 +27,7 @@ export class IgxGridEditingActionsComponent extends IgxGridActionsBaseDirective
     /**
      * An input to enable/disable action strip row adding button
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public set addRow(value: boolean) {
         this._addRow = value;
     }
@@ -42,13 +42,13 @@ export class IgxGridEditingActionsComponent extends IgxGridActionsBaseDirective
     /**
      * An input to enable/disable action strip row editing button
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public editRow = true;
 
     /**
     * An input to enable/disable action strip row deleting button
     */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public deleteRow = true;
 
     /**
@@ -87,7 +87,7 @@ export class IgxGridEditingActionsComponent extends IgxGridActionsBaseDirective
     /**
      * An input to enable/disable action strip child row adding button
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public addChild = false;
 
     private isMessageShown = false;
@@ -116,12 +116,12 @@ export class IgxGridEditingActionsComponent extends IgxGridActionsBaseDirective
             this.isMessageShown = showMessage(
                 'The grid should be editable in order to use IgxGridEditingActionsComponent',
                 this.isMessageShown);
-                return;
+            return;
         }
         // be sure row is in view
         if (grid.rowList.filter(r => r === row).length !== 0) {
             grid.gridAPI.crudService.enterEditMode(firstEditable, event);
-            if (!grid.gridAPI.crudService.nonEditable){
+            if (!grid.gridAPI.crudService.nonEditable) {
                 firstEditable.activate(event);
             }
         }

projects/igniteui-angular/src/lib/buttonGroup/buttonGroup.component.ts

@@ -15,7 +15,8 @@ import {
     Renderer2,
     ViewChildren,
     OnDestroy,
-    ElementRef
+    ElementRef,
+    booleanAttribute
 } from '@angular/core';
 import { Subject } from 'rxjs';
 import { IgxButtonDirective } from '../directives/button/button.directive';
@@ -194,7 +195,7 @@ export class IgxButtonGroupComponent extends DisplayDensityBase implements After
      * <igx-buttongroup [disabled]="true" [selectionMode]="'multi'" [values]="fontOptions"></igx-buttongroup>
      * ```
      */
-    @Input()
+    @Input({ transform: booleanAttribute })
     public get disabled(): boolean {
         return this._disabled;
     }
@@ -493,13 +494,13 @@ export class IgxButtonGroupComponent extends DisplayDensityBase implements After
 
         if (this.selectedIndexes.indexOf(index) === -1) {
             this.selected.emit(args);
-            if(!args.cancel){
+            if (!args.cancel) {
                 this.selectButton(index);
             }
         } else {
             if (this.selectionMode !== 'singleRequired') {
                 this.deselected.emit(args);
-                if(!args.cancel){
+                if (!args.cancel) {
                     this.deselectButton(index);
                 }
             }

projects/igniteui-angular/src/lib/calendar/calendar-base.ts

@@ -1,4 +1,4 @@
-import { Input, Output, EventEmitter, Directive, Inject, LOCALE_ID, HostListener } from '@angular/core';
+import { Input, Output, EventEmitter, Directive, Inject, LOCALE_ID, HostListener, booleanAttribute } from '@angular/core';
 import { WEEKDAYS, Calendar, isDateInRanges, IFormattingOptions, IFormattingViews, IViewDateChangeEventArgs, ScrollMonth, IgxCalendarView, CalendarSelection } from './calendar';
 import { ControlValueAccessor } from '@angular/forms';
 import { DateRangeDescriptor } from '../core/dates';
@@ -26,7 +26,7 @@ export class IgxCalendarBaseDirective implements ControlValueAccessor {
      * ```
      */
 
-    @Input()
+    @Input({ transform: booleanAttribute })
     public hideOutsideDays = false;
 
     /**
@@ -62,7 +62,7 @@ export class IgxCalendarBaseDirective implements ControlValueAccessor {
      * ```
      */
     @Output()
-    public activeViewChanged  = new EventEmitter<IgxCalendarView>();
+    public activeViewChanged = new EventEmitter<IgxCalendarView>();
 
     /**
      * @hidden
@@ -99,9 +99,9 @@ export class IgxCalendarBaseDirective implements ControlValueAccessor {
      */
     public shiftKey = false;
 
-     /**
-     * @hidden
-     */
+    /**
+    * @hidden
+    */
     public lastSelectedDate: Date;
 
     /**
@@ -483,10 +483,7 @@ export class IgxCalendarBaseDirective implements ControlValueAccessor {
     public deselectMultipleInMonth(value: Date) {
         // deselect multiple dates from last clicked to shift clicked date (excluding)
         if (this.shiftKey) {
-            let start: Date;
-            let end: Date;
-
-            [start, end] = this.lastSelectedDate.getTime() < value.getTime()
+            const [start, end] = this.lastSelectedDate.getTime() < value.getTime()
                 ? [this.lastSelectedDate, value]
                 : [value, this.lastSelectedDate];