fix(grids): base types and implementations strict incompatibilities

Author: damyanpetev

projects/igniteui-angular/core/src/data-operations/grid-types.ts

@@ -330,7 +330,7 @@ export interface ColumnType extends FieldType {
      * The immediate parent (right above) column of this column (if any).
      * If there is no parent, that means the current column is the root parent
      */
-    parent?: ColumnType;
+    parent: ColumnType | null;
     pipeArgs: IColumnPipeArgs;
     hasNestedPath: boolean;
     additionalTemplateContext: any;

projects/igniteui-angular/grids/core/src/api.service.ts

@@ -31,13 +31,13 @@ export class GridBaseAPIService<T extends GridType> implements GridServiceType {
     public cms = inject(IgxColumnMovingService)
 
     public grid: T;
-    protected destroyMap: Map<string, Subject<boolean>> = new Map<string, Subject<boolean>>();    
+    protected destroyMap: Map<string, Subject<boolean>> = new Map<string, Subject<boolean>>();
 
     public get_column_by_name(name: string): ColumnType {
         return this.grid.columns.find((col: ColumnType) => col.field === name);
     }
 
-    public get_summary_data() {
+    public get_summary_data(): any[] | null {
         const grid = this.grid;
         let data = grid.filteredData;
         if (data && grid.hasPinnedRecords) {

projects/igniteui-angular/grids/core/src/columns/column.component.ts

@@ -1801,10 +1801,8 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy
      * ```typescript
      * this.column.parent = higherLevelColumn;
      * ```
-     *
-     * @memberof IgxColumnComponent
      */
-    public parent = null;
+    public parent: ColumnType | null = null;
 
     /* blazorSuppress */
     /**

projects/igniteui-angular/grids/core/src/common/grid.interface.ts

@@ -27,7 +27,7 @@ export const IGX_GRID_SERVICE_BASE = /*@__PURE__*/new InjectionToken<GridService
 
 export interface IGridDataBindable extends GridTypeBase {
     data: any[] | null;
-    get filteredData(): any[];
+    get filteredData(): any[] | null;
 }
 
 /* marshalByValue */
@@ -385,7 +385,7 @@ export interface GridServiceType {
     get_row_expansion_state(id: any): boolean;
     /** Represents a method declaration for setting a new expansion state. It can be triggered by an event */
     set_row_expansion_state(id: any, expanded: boolean, event?: Event): void;
-    get_summary_data(): any[];
+    get_summary_data(): any[] | null;
 
     prepare_sorting_expression(stateCollections: Array<Array<any>>, expression: ISortingExpression): void;
     /**
@@ -417,7 +417,7 @@ export interface GridServiceType {
     clear_groupby?(field: string | any): void;
     getParentRowId?(child: GridType): any;
     getChildGrids?(inDepth?: boolean): GridType[];
-    getChildGrid?(path: IPathSegment[]): GridType;
+    getChildGrid?(path: IPathSegment[]): GridType | undefined;
 
     unsetChildRowIsland?(rowIsland: GridType): void;
     registerChildRowIsland?(rowIsland: GridType): void;
@@ -497,7 +497,7 @@ export interface GridType extends IGridDataBindable {
     /** @hidden @internal */
     tfoot: ElementRef<HTMLElement>;
     /** @hidden @internal */
-    paginator: IgxPaginatorComponent;
+    paginator?: IgxPaginatorComponent;
     /** @hidden @internal */
     paginatorList?: QueryList<IgxPaginatorComponent>;
     /** @hidden @internal */
@@ -691,7 +691,7 @@ export interface GridType extends IGridDataBindable {
     dataView: any[];
     _filteredUnpinnedData: any[];
     _filteredSortedUnpinnedData: any[];
-    filteredSortedData: any[];
+    filteredSortedData: any[] | null;
     dataWithAddedInTransactionRows: any[];
     /** Represents the transaction service for the grid. */
     readonly transactions: TransactionService<Transaction, State>;

projects/igniteui-angular/grids/grid/src/grid-base.directive.ts

@@ -2729,11 +2729,11 @@ export abstract class IgxGridBaseDirective implements GridType,
     }
 
     /** @hidden @internal */
-    public get activeDescendant() {
+    public get activeDescendant(): string | undefined {
         const activeElem = this.navigation.activeNode;
 
         if (!activeElem || !Object.keys(activeElem).length || activeElem.row < 0) {
-            return null;
+            return;
         }
         return `${this.id}_${activeElem.row}_${activeElem.column}`;
     }
@@ -2773,7 +2773,7 @@ export abstract class IgxGridBaseDirective implements GridType,
     /**
      * @hidden @internal
      */
-    public get maxLevelHeaderDepth() {
+    public get maxLevelHeaderDepth(): number {
         if (this._maxLevelHeaderDepth === null) {
             this._maxLevelHeaderDepth = this.hasColumnLayouts ?
                 this._columns.reduce((acc, col) => Math.max(acc, col.rowStart), 0) :
@@ -3139,7 +3139,7 @@ export abstract class IgxGridBaseDirective implements GridType,
     /**
      * @hidden
      */
-    protected _maxLevelHeaderDepth = null;
+    protected _maxLevelHeaderDepth = 0;
     /**
      * @hidden
      */
@@ -3353,7 +3353,7 @@ export abstract class IgxGridBaseDirective implements GridType,
      * const filteredSortedData = this.grid1.filteredSortedData;
      * ```
      */
-    public get filteredSortedData(): any[] {
+    public get filteredSortedData(): any[] | null {
         return this._filteredSortedData;
     }
 

projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid-api.service.ts

@@ -25,7 +25,7 @@ export class IgxHierarchicalGridAPIService extends GridBaseAPIService<GridType>
         return this.childRowIslands.get(key);
     }
 
-    public getChildGrid(path: Array<IPathSegment>) {
+    public getChildGrid(path: Array<IPathSegment>): GridType | undefined {
         const currPath = path;
         let grid;
         const pathElem = currPath.shift();

projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts

@@ -153,7 +153,6 @@ const MINIMUM_COLUMN_WIDTH_SUPER_COMPACT = 104;
 })
 export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnInit, AfterContentInit,
     PivotGridType, AfterViewInit, OnChanges {
-    public override readonly gridAPI = inject<GridBaseAPIService<IgxGridBaseDirective & GridType>>(GridBaseAPIService);
     public override navigation = inject(IgxPivotGridNavigationService);
     protected override colResizingService = inject(IgxPivotColumnResizingService);
 
@@ -676,8 +675,8 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
      * @hidden @internal
      */
     @Input()
-    public override get pagingMode() {
-        return;
+    public override get pagingMode(): GridPagingMode {
+        return 'local';
     }
 
     public override set pagingMode(_val: GridPagingMode) {
@@ -688,8 +687,8 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
      */
     @WatchChanges()
     @Input({ transform: booleanAttribute })
-    public override get hideRowSelectors() {
-        return;
+    public override get hideRowSelectors(): boolean {
+        return false;
     }
 
     public override set hideRowSelectors(_value: boolean) {
@@ -733,7 +732,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
      */
     @Input({ transform: booleanAttribute })
     public override get rowDraggable(): boolean {
-        return;
+        return false;
     }
 
 
@@ -789,7 +788,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
      */
     @Input()
     public override get perPage(): number {
-        return;
+        return 0;
     }
 
     public override set perPage(_val: number) {
@@ -894,7 +893,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
     }
 
     /**
-     * @hidden @interal
+     * @hidden @internal
      */
     @Input()
     public override get summaryCalculationMode() {
@@ -905,7 +904,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
     }
 
     /**
-     * @hidden @interal
+     * @hidden @internal
      */
     @Input({ transform: booleanAttribute })
     public override get showSummaryOnCollapse() {
@@ -918,23 +917,23 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
     /**
      * @hidden @internal
      */
-    public override get hiddenColumnsCount() {
-        return null;
+    public override get hiddenColumnsCount(): number {
+        return 0;
     }
 
     /**
      * @hidden @internal
      */
-    public override get pinnedColumnsCount() {
-        return null;
+    public override get pinnedColumnsCount(): number {
+        return 0;
     }
 
     /**
      * @hidden @internal
      */
     @Input({ transform: booleanAttribute })
     public override get batchEditing(): boolean {
-        return;
+        return false;
     }
 
     public override set batchEditing(_val: boolean) {
@@ -1276,7 +1275,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
      * @hidden @internal
      */
     public override isRecordPinnedByIndex(_rowIndex: number) {
-        return null;
+        return false;
     }
 
     /**
@@ -1991,9 +1990,9 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
     }
 
     /** @hidden @internal */
-    public override get activeDescendant() {
+    public override get activeDescendant(): string | undefined {
         if (this.navigation.isRowHeaderActive || this.navigation.isRowDimensionHeaderActive) {
-            return null;
+            return;
         }
         return super.activeDescendant;
     }

projects/igniteui-angular/grids/tree-grid/src/tree-grid-api.service.ts

@@ -28,7 +28,7 @@ export class IgxTreeGridAPIService extends GridBaseAPIService<GridType> {
         return data;
     }
 
-    public override get_summary_data() {
+    public override get_summary_data(): any[] | null {
         const grid = this.grid;
         const data = grid.processedRootRecords?.filter(row => row.isFilteredOutParent === undefined || row.isFilteredOutParent === false)
             .map(rec => rec.data);

projects/igniteui-angular/grids/tree-grid/src/tree-grid.component.ts

@@ -518,7 +518,7 @@ export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridTy
         super.ngAfterContentInit();
     }
 
-    public override getDefaultExpandState(record: ITreeGridRecord) {
+    public override getDefaultExpandState(record: ITreeGridRecord): boolean {
         return record.children && record.children.length && record.level < this.expansionDepth;
     }