Skip to content

Commit 51749ce

Browse files
author
Konstantin Dinev
committed
fix(*): moving the IgxOverlayOutletDirective and some renamed exports
1 parent c26e0c1 commit 51749ce

File tree

29 files changed

+129
-102
lines changed

29 files changed

+129
-102
lines changed

projects/igniteui-angular/carousel/src/carousel/carousel.component.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
import { HammerGestureConfig, HAMMER_GESTURE_CONFIG } from '@angular/platform-browser';
2828
import { merge, Subject } from 'rxjs';
2929
import { takeUntil } from 'rxjs/operators';
30-
import { CarouselResourceStringsEN, ICarouselResourceStrings } from 'igniteui-angular/core';
30+
import { CarouselResourceStringsEN, ICarouselResourceStrings, IgxDirectionality } from 'igniteui-angular/core';
3131
import { first, IBaseEventArgs, last, PlatformUtil } from 'igniteui-angular/core';
3232
import { IgxAngularAnimationService } from 'igniteui-angular/core';
3333
import { AnimationService } from 'igniteui-angular/core';
@@ -39,7 +39,6 @@ import { IgxButtonDirective } from 'igniteui-angular/directives';
3939
import { getCurrentResourceStrings } from 'igniteui-angular/core';
4040
import { HammerGesturesManager } from 'igniteui-angular/core';
4141
import { CarouselAnimationType, CarouselIndicatorsOrientation } from './enums';
42-
import { ɵIgxDirectionality } from 'igniteui-angular/core';
4342

4443
let NEXT_ID = 0;
4544

@@ -571,7 +570,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
571570
private iterableDiffers: IterableDiffers,
572571
@Inject(IgxAngularAnimationService) animationService: AnimationService,
573572
private platformUtil: PlatformUtil,
574-
private dir: ɵIgxDirectionality,
573+
private dir: IgxDirectionality,
575574
@Inject(DOCUMENT) private document: any
576575
) {
577576
super(animationService, cdr);

projects/igniteui-angular/core/src/services/overlay/utilities.ts

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,29 @@
11
import { AnimationReferenceMetadata } from '@angular/animations';
2-
import { ComponentRef, ElementRef, Injector, NgZone } from '@angular/core';
2+
import { ComponentRef, Directive, ElementRef, Injector, NgZone } from '@angular/core';
33
import { CancelableBrowserEventArgs, CancelableEventArgs, cloneValue, IBaseEventArgs } from '../../core/utils';
44
import { AnimationPlayer } from '../animation/animation';
55
import { IPositionStrategy } from './position/IPositionStrategy';
66
import { IScrollStrategy } from './scroll';
77

88
/**
9-
* Interface representing an overlay outlet directive.
10-
* The actual implementation is in igniteui-angular/directives.
9+
* Mark an element as an igxOverlay outlet container.
10+
* Directive instance is exported as `overlay-outlet` to be assigned to templates variables:
11+
* ```html
12+
* <div igxOverlayOutlet #outlet="overlay-outlet"></div>
13+
* ```
1114
*/
12-
export interface IgxOverlayOutletDirective {
13-
element: ElementRef;
14-
readonly nativeElement: HTMLElement;
15+
@Directive({
16+
exportAs: 'overlay-outlet',
17+
selector: '[igxOverlayOutlet]',
18+
standalone: true
19+
})
20+
export class IgxOverlayOutletDirective {
21+
constructor(public element: ElementRef<HTMLElement>) { }
22+
23+
/** @hidden */
24+
public get nativeElement() {
25+
return this.element.nativeElement;
26+
}
1527
}
1628

1729
/* blazorAlternateName: GridHorizontalAlignment */

projects/igniteui-angular/core/src/services/public_api.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,15 @@ export * from './animation/animation';
55
export * from './csv/csv-exporter';
66
export * from './csv/csv-exporter-options';
77
export * from './csv/char-separated-value-data';
8-
export { Direction as ɵDirection, DIR_DOCUMENT as ɵDIR_DOCUMENT, IgxDirectionality as ɵIgxDirectionality } from './direction/directionality';
8+
export * from './direction/directionality';
99
export * from './excel/excel-exporter';
1010
export * from './excel/excel-exporter-options';
1111
export * from './exporter-common/base-export-service';
1212
export * from './exporter-common/exporter-options-base';
1313
export * from './overlay/overlay';
1414
export * from './overlay/position';
1515
export * from './overlay/scroll';
16-
export {
17-
AbsolutePosition, ConnectedFit, HorizontalAlignment, OffsetMode, OverlayAnimationEventArgs, OverlayCancelableEventArgs, OverlayClosingEventArgs,
18-
OverlayCreateSettings, OverlayEventArgs, OverlaySettings, Point, PositionSettings, RelativePosition, RelativePositionStrategy, Size, VerticalAlignment, Util
19-
} from './overlay/utilities';
16+
export * from './overlay/utilities';
2017
export * from './transaction/base-transaction';
2118
export * from './transaction/hierarchical-transaction';
2219
export * from './transaction/igx-hierarchical-transaction';

projects/igniteui-angular/date-picker/src/date-picker/date-picker.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import {
4343
import { fromEvent, Subscription, noop, MonoTypeOperatorFunction } from 'rxjs';
4444
import { filter, takeUntil } from 'rxjs/operators';
4545

46-
import { IgxDateTimeEditorDirective, IgxOverlayOutletDirective, IgxTextSelectionDirective } from 'igniteui-angular/directives';
46+
import { IgxDateTimeEditorDirective, IgxTextSelectionDirective } from 'igniteui-angular/directives';
4747
import {
4848
AbsoluteScrollStrategy,
4949
AutoPositionStrategy,
@@ -64,7 +64,8 @@ import {
6464
DateTimeUtil,
6565
DatePartDeltas,
6666
DatePart,
67-
isDateInRanges
67+
isDateInRanges,
68+
IgxOverlayOutletDirective
6869
} from 'igniteui-angular/core';
6970
import { IDatePickerValidationFailedEventArgs } from './date-picker.common';
7071
import { IgxIconComponent } from 'igniteui-angular/icon';

projects/igniteui-angular/date-picker/src/date-picker/picker-base.directive.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import { getLocaleFirstDayOfWeek } from "@angular/common";
88
import { merge, Subject } from 'rxjs';
99
import { takeUntil } from 'rxjs/operators';
1010
import { IGX_INPUT_GROUP_TYPE, IgxInputGroupComponent, IgxInputGroupType, IgxPrefixDirective, IgxSuffixDirective } from 'igniteui-angular/input-group';
11-
import { DateRange, EditorProvider, IBaseCancelableBrowserEventArgs, IBaseEventArgs, IgxPickerClearComponent, IgxPickerToggleComponent, IToggleView, OverlaySettings, PickerHeaderOrientation, PickerInteractionMode, WEEKDAYS } from 'igniteui-angular/core';
12-
import { IgxOverlayOutletDirective } from 'igniteui-angular/directives';
11+
import { DateRange, EditorProvider, IBaseCancelableBrowserEventArgs, IBaseEventArgs, IgxOverlayOutletDirective, IgxPickerClearComponent, IgxPickerToggleComponent, IToggleView, OverlaySettings, PickerHeaderOrientation, PickerInteractionMode, WEEKDAYS } from 'igniteui-angular/core';
1312

1413
@Directive()
1514
export abstract class PickerBaseDirective implements IToggleView, EditorProvider, AfterViewInit, AfterContentChecked, OnDestroy {

projects/igniteui-angular/date-picker/src/date-range-picker/date-range-picker.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ import {
3737
DateTimeUtil,
3838
IgxPickerActionsDirective,
3939
isDateInRanges,
40-
PickerCalendarOrientation
40+
PickerCalendarOrientation,
41+
IgxOverlayOutletDirective
4142
} from 'igniteui-angular/core';
4243
import { IgxCalendarContainerComponent } from '../date-picker/calendar-container/calendar-container.component';
4344
import { PickerBaseDirective } from '../date-picker/picker-base.directive';
44-
import { IgxOverlayOutletDirective } from 'igniteui-angular/directives';
4545
import {
4646
IgxInputDirective,
4747
IgxInputGroupComponent,

projects/igniteui-angular/directives/src/directives/notification/notifications.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Directive, ElementRef, HostBinding, Input, OnDestroy, booleanAttribute } from '@angular/core';
2-
import { IToggleView } from 'igniteui-angular/core';
2+
import { IgxOverlayOutletDirective, IToggleView } from 'igniteui-angular/core';
33
import { IPositionStrategy, OverlaySettings } from 'igniteui-angular/core';
4-
import { IgxOverlayOutletDirective, IgxToggleDirective } from '../toggle/toggle.directive';
4+
import { IgxToggleDirective } from '../toggle/toggle.directive';
55

66
@Directive()
77
export abstract class IgxNotificationsDirective extends IgxToggleDirective

projects/igniteui-angular/directives/src/directives/toggle/toggle.directive.ts

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
Optional,
1212
Output,
1313
} from '@angular/core';
14-
import { AbsoluteScrollStrategy } from 'igniteui-angular/core';
14+
import { AbsoluteScrollStrategy, IgxOverlayOutletDirective } from 'igniteui-angular/core';
1515
import { CancelableBrowserEventArgs, IBaseEventArgs, PlatformUtil } from 'igniteui-angular/core';
1616
import { ConnectedPositioningStrategy } from 'igniteui-angular/core';
1717
import { filter, first, takeUntil } from 'rxjs/operators';
@@ -526,24 +526,3 @@ export class IgxToggleActionDirective implements OnInit {
526526
return settings;
527527
}
528528
}
529-
530-
/**
531-
* Mark an element as an igxOverlay outlet container.
532-
* Directive instance is exported as `overlay-outlet` to be assigned to templates variables:
533-
* ```html
534-
* <div igxOverlayOutlet #outlet="overlay-outlet"></div>
535-
* ```
536-
*/
537-
@Directive({
538-
exportAs: 'overlay-outlet',
539-
selector: '[igxOverlayOutlet]',
540-
standalone: true
541-
})
542-
export class IgxOverlayOutletDirective {
543-
constructor(public element: ElementRef<HTMLElement>) { }
544-
545-
/** @hidden */
546-
public get nativeElement() {
547-
return this.element.nativeElement;
548-
}
549-
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { NgModule } from '@angular/core';
2-
import { IgxOverlayOutletDirective, IgxToggleActionDirective, IgxToggleDirective } from './toggle.directive';
2+
import { IgxToggleActionDirective, IgxToggleDirective } from './toggle.directive';
33

44
/**
55
* @hidden
66
* IMPORTANT: The following is NgModule exported for backwards-compatibility before standalone components
77
*/
88
@NgModule({
9-
imports: [IgxToggleDirective, IgxToggleActionDirective, IgxOverlayOutletDirective],
10-
exports: [IgxToggleDirective, IgxToggleActionDirective, IgxOverlayOutletDirective]
9+
imports: [IgxToggleDirective, IgxToggleActionDirective],
10+
exports: [IgxToggleDirective, IgxToggleActionDirective]
1111
})
1212
export class IgxToggleModule { }

projects/igniteui-angular/drop-down/src/drop-down/autocomplete/autocomplete.directive.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
import { NgModel, FormControlName } from '@angular/forms';
1919
import { Subject } from 'rxjs';
2020
import { takeUntil } from 'rxjs/operators';
21-
import { CancelableEventArgs, IBaseEventArgs } from 'igniteui-angular/core';
21+
import { CancelableEventArgs, IBaseEventArgs, IgxOverlayOutletDirective } from 'igniteui-angular/core';
2222
import {
2323
AbsoluteScrollStrategy,
2424
AutoPositionStrategy,
@@ -28,7 +28,6 @@ import {
2828
} from 'igniteui-angular/core';
2929
import { IgxDropDownComponent } from '../drop-down.component';
3030
import { IgxDropDownItemNavigationDirective } from '../drop-down-navigation.directive';
31-
import { IgxOverlayOutletDirective } from 'igniteui-angular/directives';
3231
import { ISelectionEventArgs } from '../drop-down.common';
3332
import { IgxInputGroupComponent } from 'igniteui-angular/input-group';
3433

0 commit comments

Comments
 (0)