Merge branch 'master' into simeonoff/contrast-css-vars

Author: ChronosSF

CHANGELOG.md

@@ -69,8 +69,8 @@ All notable changes for each version of this project will be documented in this
     - `tickLabelsOrientation` input was added. Allows you to change the rotation of all tick labels from horizontal to vertical(toptobottom, bottomtotop).
     - `igxSliderTickLabel` directive has been introduced. Allows you to set a custom template for all tick labels.
     - `isContinuous` - input has been deleted. The option is not supported anymore.
-    - `onValueChanged` - new output has been exposed. This event is emitted at the end of every slide interaction. 
-   
+    - `onValueChanged` - new output has been exposed. This event is emitted at the end of every slide interaction.
+
 - `IgxCarousel`:
     - `keyboardSupport` input is added, which can be used to enable and disable keyboard navigation
     - `gesturesSupport` input is added, which can be used to enable and disable gestures
@@ -81,7 +81,7 @@ All notable changes for each version of this project will be documented in this
     - `nextButtonTemplate` directive is added, which is used to provide a custom next button template. If not provided, a default next button is used.
     - `prevButtonTemplate` directive is added, which is used to provide a custom previous button template. If not provided, a default previous button is used.
 
-- `IgxSelect`: 
+- `IgxSelect`:
     - adding `IgxSelectHeaderDirective` and `IgxSelectFooterDirective`. These can be used to provide a custom header, respectively footer templates for the `igxSelect` drop-down list. If there are no templates marked with these directives - no default templates will be used so the drop-down list will not have header nor footer.
 
 - `IgxCombo`:
@@ -124,6 +124,7 @@ All notable changes for each version of this project will be documented in this
 
     @include igx-progress-circular($theme);
     ```
+    - RTL support
 
 ## 8.2.6
 

package-lock.json

@@ -45,14 +45,14 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "^9.0.0-rc.10",
-    "@angular/common": "^9.0.0-rc.10",
-    "@angular/compiler": "^9.0.0-rc.10",
-    "@angular/core": "^9.0.0-rc.10",
-    "@angular/forms": "^9.0.0-rc.10",
-    "@angular/platform-browser": "^9.0.0-rc.10",
-    "@angular/platform-browser-dynamic": "^9.0.0-rc.10",
-    "@angular/router": "^9.0.0-rc.10",
+    "@angular/animations": "^9.0.0-rc.11",
+    "@angular/common": "^9.0.0-rc.11",
+    "@angular/compiler": "^9.0.0-rc.11",
+    "@angular/core": "^9.0.0-rc.11",
+    "@angular/forms": "^9.0.0-rc.11",
+    "@angular/platform-browser": "^9.0.0-rc.11",
+    "@angular/platform-browser-dynamic": "^9.0.0-rc.11",
+    "@angular/router": "^9.0.0-rc.11",
     "@types/hammerjs": "^2.0.36",
     "@types/source-map": "0.5.2",
     "classlist.js": "^1.1.20150312",
@@ -70,8 +70,8 @@
     "@angular-devkit/build-ng-packagr": "~0.900.0-rc.10",
     "@angular-devkit/schematics": "^9.0.0-rc.10",
     "@angular/cli": "~9.0.0-rc.10",
-    "@angular/compiler-cli": "^9.0.0-rc.10",
-    "@angular/language-service": "^9.0.0-rc.10",
+    "@angular/compiler-cli": "^9.0.0-rc.11",
+    "@angular/language-service": "^9.0.0-rc.11",
     "@angularclass/hmr": "^2.1.3",
     "@types/jasmine": "~3.3.5",
     "@types/jasminewd2": "~2.0.6",

package.json

@@ -15,6 +15,7 @@ import { IgxSuffixDirective } from './../directives/suffix/suffix.directive';
 import { DisplayDensity } from '../core/displayDensity';
 import { UIInteractions, wait } from '../test-utils/ui-interactions.spec';
 import { configureTestSuite } from '../test-utils/configure-suite';
+import { ControlsFunction } from '../test-utils/controls-functions.spec';
 
 @Component({
     template: `
@@ -129,7 +130,7 @@ describe('IgxChip', () => {
 
         it('should render remove button when enabled after the content inside the chip', () => {
             const chipElems = fix.debugElement.queryAll(By.directive(IgxChipComponent));
-            const chipRemoveButton = HelperTestFunctions.getDeleteButton(fix);
+            const chipRemoveButton = ControlsFunction.getChipRemoveButton(chipElems[1].nativeElement);
 
             // For this second chip there are 3 elements. The prefix, content span and the remove button icon .
             expect(chipElems[1].nativeElement.children[0].children.length).toEqual(4);
@@ -241,10 +242,10 @@ describe('IgxChip', () => {
 
         it('should delete chip when space button is pressed on delete button', () => {
             HelperTestFunctions.verifyChipsCount(fix, 4);
-
-            const deleteButtonElement = HelperTestFunctions.getDeleteButton(fix);
+            const chipElems = fix.debugElement.queryAll(By.directive(IgxChipComponent));
+            const deleteButtonElement = ControlsFunction.getChipRemoveButton(chipElems[1].nativeElement);
             // Removes chip with id City, because country chip is unremovable
-            UIInteractions.triggerKeyDownEvtUponElem(' ', deleteButtonElement.nativeElement, true);
+            UIInteractions.triggerKeyDownEvtUponElem(' ', deleteButtonElement, true);
             fix.detectChanges();
 
             HelperTestFunctions.verifyChipsCount(fix, 3);
@@ -257,9 +258,10 @@ describe('IgxChip', () => {
         it('should delete chip when enter button is pressed on delete button', () => {
             HelperTestFunctions.verifyChipsCount(fix, 4);
 
-            const deleteButtonElement = HelperTestFunctions.getDeleteButton(fix);
+            const chipElems = fix.debugElement.queryAll(By.directive(IgxChipComponent));
+            const deleteButtonElement = ControlsFunction.getChipRemoveButton(chipElems[1].nativeElement);
             // Removes chip with id City, because country chip is unremovable
-            UIInteractions.triggerKeyDownEvtUponElem('Enter', deleteButtonElement.nativeElement, true);
+            UIInteractions.triggerKeyDownEvtUponElem('Enter', deleteButtonElement, true);
             fix.detectChanges();
 
             HelperTestFunctions.verifyChipsCount(fix, 3);
@@ -360,7 +362,8 @@ describe('IgxChip', () => {
             spyOn(secondChipComp.onSelection, 'emit');
             spyOn(secondChipComp.onSelectionDone, 'emit');
 
-            const chipRemoveButton = HelperTestFunctions.getDeleteButton(fix).nativeElement;
+            const chipRemoveButton = ControlsFunction.getChipRemoveButton(secondChipComp.chipArea.nativeElement);
+
             const removeBtnTop = chipRemoveButton.getBoundingClientRect().top;
             const removeBtnLeft = chipRemoveButton.getBoundingClientRect().left;
 
@@ -400,12 +403,6 @@ describe('IgxChip', () => {
 });
 
 class HelperTestFunctions {
-    public static CHIP_REMOVE_BUTTON = '.igx-chip__remove';
-
-    public static getDeleteButton(fix, index = 0) {
-        return fix.debugElement.queryAll(By.css(HelperTestFunctions.CHIP_REMOVE_BUTTON))[index];
-    }
-
     public static verifyChipsCount(fix, count) {
         const chipComponents = fix.debugElement.queryAll(By.directive(IgxChipComponent));
         expect(chipComponents.length).toEqual(count);

projects/igniteui-angular/src/lib/chips/chip.spec.ts

@@ -107,6 +107,8 @@ export class IgxTemplateOutletDirective implements OnChanges {
             this._viewContainerRef.insert(view, 0);
             this._updateExistingContext(this.igxTemplateOutletContext);
             this.onViewMoved.emit({ owner: this, view: this._viewRef, context: this.igxTemplateOutletContext });
+        } else {
+            this._updateExistingContext(this.igxTemplateOutletContext);
         }
     }
     private _useCachedView() {

projects/igniteui-angular/src/lib/directives/template-outlet/template_outlet.directive.ts

@@ -620,6 +620,16 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {
         if (this.editable && editMode && !this.row.deleted) {
             if (editableCell) {
                 this.gridAPI.update_cell(editableCell, editableCell.editValue);
+                /* This check is related with the following issue #6517:
+                 * when edit cell that belongs to a column which is sorted and press tab,
+                 * the next cell in edit mode is with wrong value /its context is not updated/;
+                 * So we reapply sorting before the next cell enters edit mode.
+                 * Also we need to keep the notifyChanges below, because of the current
+                 * change detection cycle when we have editing with enabled transactions
+                 */
+                if (this.grid.sortingExpressions.length && this.grid.sortingExpressions.indexOf(editableCell.column.field)) {
+                    this.grid.cdr.detectChanges();
+                }
             }
             crud.end();
             this.grid.notifyChanges();

projects/igniteui-angular/src/lib/grids/cell.component.ts

@@ -18,6 +18,7 @@ import {
     IgxGridExternalAdvancedFilteringComponent,
     IgxGridAdvancedFilteringBindingComponent
 } from '../../test-utils/grid-samples.spec';
+import { ControlsFunction } from '../../test-utils/controls-functions.spec';
 
 const ADVANCED_FILTERING_OPERATOR_LINE_AND_CSS_CLASS = 'igx-filter-tree__line--and';
 const ADVANCED_FILTERING_OPERATOR_LINE_OR_CSS_CLASS = 'igx-filter-tree__line--or';
@@ -2441,7 +2442,7 @@ describe('IgxGrid - Advanced Filtering #grid', () => {
 
                 // Press 'Enter' on the remove icon of the second chip.
                 const chip = GridFunctions.getAdvancedFilteringTreeExpressionChip(fix, [1]);
-                const removeIcon = chip.querySelector('.igx-chip__remove');
+                const removeIcon = ControlsFunction.getChipRemoveButton(chip);
                 UIInteractions.simulateKeyDownEvent(removeIcon, 'Enter');
                 tick(200);
                 fix.detectChanges();