Skip to content

Commit 53cebd9

Browse files
committed
feat(IgxHeader): add aria attributes to the column headers elements #3343
1 parent ba23a1d commit 53cebd9

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

projects/igniteui-angular/src/lib/grids/headers/grid-header-group.component.html

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,29 @@
2424
<span [attr.title]="column.header">{{column.header}}</span>
2525
</ng-template>
2626

27+
<ng-template #defaultCollapseIndicator>
28+
<igx-icon [attr.draggable]="false" >
29+
{{column.expand ? 'expand_less' : 'expand_more'}} </igx-icon>
30+
</ng-template>
31+
2732
<ng-container *ngIf="!grid.hasColumnLayouts && column.columnGroup">
2833
<span *ngIf="grid.hasMovableColumns" class="igx-grid__th-drop-indicator-left"></span>
2934
<div class="igx-grid__thead-title"
35+
role="columnheader"
36+
[attr.aria-label]="column.header || column.field"
37+
[attr.aria-expanded]="column.expand"
38+
tabindex="0"
3039
[ngClass]="{'igx-grid__th--pinned-last': hasLastPinnedChildColumn}"
3140
[igxColumnMovingDrag]="column"
3241
[ghostHost]="grid.outletDirective.nativeElement"
3342
[attr.droppable]="true"
3443
[igxColumnMovingDrop]="column">
35-
<ng-container *ngIf="column.collapsible">
36-
<igx-icon [attr.draggable]="false" (click)="column.expanded = !column.expanded">
37-
{{column.expanded ? 'expand_less' : 'expand_more'}} </igx-icon>
44+
<ng-container *ngIf="column.collapsible">
45+
<div (click)="column.expand = !column.expand">
46+
<ng-container
47+
*ngTemplateOutlet="column.collapsibleIndicatorTemplate ? column.collapsibleIndicatorTemplate : defaultCollapseIndicator; context: {$implicit: column, column: column}">
48+
</ng-container>
49+
</div>
3850
</ng-container>
3951
<ng-container *ngTemplateOutlet="column.headerTemplate ? column.headerTemplate : defaultColumn; context: { $implicit: column, column: column}">
4052
</ng-container>

projects/igniteui-angular/src/lib/grids/headers/grid-header-group.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ export class IgxGridHeaderGroupComponent implements DoCheck {
6868
return this.column.colStart;
6969
}
7070

71-
7271
/**
7372
* Gets the column of the header group.
7473
* @memberof IgxGridHeaderGroupComponent

projects/igniteui-angular/src/lib/grids/headers/grid-header.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class IgxGridHeaderComponent implements DoCheck, OnInit, OnDestroy {
115115
public hostRole = 'columnheader';
116116

117117
@HostBinding('attr.tabindex')
118-
public tabindex = -1;
118+
public tabindex = 0;
119119

120120
@HostBinding('attr.id')
121121
get headerID() {

0 commit comments

Comments
 (0)