Skip to content

Commit 5472d6d

Browse files
authored
feat(text-highlight): implement disposal (#13927)
1 parent 423b797 commit 5472d6d

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

projects/igniteui-angular/src/lib/directives/text-highlight/text-highlight.service.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,10 @@ export class IgxTextHighlightService {
2929
this.onActiveElementChanged.emit(groupName);
3030
}
3131

32+
/**
33+
* Destroys a highlight group.
34+
*/
35+
public destroyGroup(groupName: string) {
36+
this.highlightGroupsMap.delete(groupName);
37+
}
3238
}

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3962,6 +3962,8 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
39623962
this.transactionChange$.complete();
39633963
this._destroyed = true;
39643964

3965+
this.textHighlightService.destroyGroup(this.id);
3966+
39653967
if (this._advancedFilteringOverlayId) {
39663968
this.overlayService.detach(this._advancedFilteringOverlayId);
39673969
delete this._advancedFilteringOverlayId;

projects/igniteui-angular/src/lib/grids/hierarchical-grid/row-island.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ export class IgxRowIslandComponent extends IgxHierarchicalGridBaseDirective
357357
* @hidden
358358
*/
359359
public override ngOnDestroy() {
360-
// Override the base destroy because we don't have rendered anything to use removeEventListener on
360+
// Override the base destroy because we have not rendered anything to use removeEventListener on
361361
this.destroy$.next(true);
362362
this.destroy$.complete();
363363
this._destroyed = true;

0 commit comments

Comments
 (0)