Skip to content

Commit 555db7d

Browse files
authored
Merge pull request #8356 from IgniteUI/mkirova/fix-grid-overlay-position
fix(igxGrid): When reposition rows ensure object used in overlay inst…
2 parents 62ddcba + 97641d4 commit 555db7d

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6467,7 +6467,6 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
64676467
this.configureRowEditingOverlay(id, this.rowList.length <= MIN_ROW_EDITING_COUNT_THRESHOLD);
64686468

64696469
this.rowEditingOverlay.open(this.rowEditSettings);
6470-
this.rowEditPositioningStrategy.isTopInitialPosition = this.rowEditPositioningStrategy.isTop;
64716470
this.rowEditingOverlay.element.addEventListener('wheel', this.rowEditingWheelHandler);
64726471
}
64736472

@@ -6510,14 +6509,19 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
65106509
}
65116510

65126511
private configureRowEditingOverlay(rowID: any, useOuter = false) {
6513-
this.rowEditSettings.outlet = useOuter ? this.parentRowOutletDirective : this.rowOutletDirective;
6512+
let settings = this.rowEditSettings;
6513+
const overlay = this.overlayService.getOverlayById(this.rowEditingOverlay.overlayId);
6514+
if (overlay) {
6515+
settings = overlay.settings;
6516+
}
6517+
settings.outlet = useOuter ? this.parentRowOutletDirective : this.rowOutletDirective;
65146518
this.rowEditPositioningStrategy.settings.container = this.tbody.nativeElement;
65156519
const pinned = this._pinnedRecordIDs.indexOf(rowID) !== -1;
65166520
const targetRow = !pinned ? this.gridAPI.get_row_by_key(rowID) : this.pinnedRows.find(x => x.rowID === rowID);
65176521
if (!targetRow) {
65186522
return;
65196523
}
6520-
this.rowEditSettings.target = targetRow.element.nativeElement;
6524+
settings.target = targetRow.element.nativeElement;
65216525
this.toggleRowEditingOverlay(true);
65226526
}
65236527

0 commit comments

Comments
 (0)