Skip to content

Commit 561ef8c

Browse files
MKirovaMKirova
authored andcommitted
chore(*): Additional fix and updating with some additional checks.
1 parent 436bcd3 commit 561ef8c

File tree

2 files changed

+33
-7
lines changed

2 files changed

+33
-7
lines changed

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.pipes.spec.ts

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1331,7 +1331,7 @@ describe('Pivot pipes #pivotGrid', () => {
13311331
let rowPipeResult = rowPipe.transform(data, pivotConfig, expansionStates);
13321332
let columnPipeResult = columnPipe.transform(rowPipeResult, pivotConfig, new Map<any, boolean>());
13331333
let rowStatePipeResult = rowStatePipe.transform(columnPipeResult, pivotConfig, expansionStates, true);
1334-
expect(rowStatePipeResult.length).toBe(77);
1334+
expect(rowStatePipeResult.length).toBe(84);
13351335
const prod_country_date_seller_discontinued = PivotGridFunctions.getDimensionData(rowStatePipeResult, pivotConfig.rows);
13361336
const allPeriods_allProducts_records = prod_country_date_seller_discontinued.filter(x => x['AllPeriods'] === 'All Periods' &&
13371337
x['AllProduct'] === 'All Products');
@@ -1379,7 +1379,33 @@ describe('Pivot pipes #pivotGrid', () => {
13791379
expect(allPeriods_bikes_records).toEqual([
13801380
{ AllPeriods: 'All Periods', ProductCategory: 'Bikes', AllCountries: 'All Countries', SellerName: 'Lydia', Discontinued: 'true' },
13811381
{ AllPeriods: 'All Periods', ProductCategory: 'Bikes', Country: 'Uruguay', SellerName: 'Lydia', Discontinued: 'true' }
1382-
])
1382+
]);
1383+
1384+
// 2021
1385+
const year_2021_records = prod_country_date_seller_discontinued.filter(x => x['Years'] === '2021');
1386+
expect(year_2021_records).toEqual([
1387+
{ Years: '2021', AllProduct: 'All Products', AllCountries: 'All Countries', SellerName: 'Stanley', Discontinued: 'false' },
1388+
{ Years: '2021', AllProduct: 'All Products', AllCountries: 'All Countries', SellerName: 'David', Discontinued: 'false' },
1389+
{ Years: '2021', AllProduct: 'All Products', AllCountries: 'All Countries', SellerName: 'John', Discontinued: 'false' },
1390+
{ Years: '2021', AllProduct: 'All Products', Country: 'Bulgaria', SellerName: 'Stanley', Discontinued: 'false' },
1391+
{ Years: '2021', AllProduct: 'All Products', Country: 'USA', SellerName: 'David', Discontinued: 'false' },
1392+
{ Years: '2021', AllProduct: 'All Products', Country: 'USA', SellerName: 'John', Discontinued: 'false' },
1393+
{ Years: '2021', ProductCategory: 'Clothing', AllCountries: 'All Countries', SellerName: 'Stanley', Discontinued: 'false' },
1394+
{ Years: '2021', ProductCategory: 'Clothing', Country: 'Bulgaria', SellerName: 'Stanley', Discontinued: 'false' },
1395+
{ Years: '2021', ProductCategory: 'Accessories', AllCountries: 'All Countries', SellerName: 'David', Discontinued: 'false' },
1396+
{ Years: '2021', ProductCategory: 'Accessories', Country: 'USA', SellerName: 'David', Discontinued: 'false' },
1397+
{ Years: '2021', ProductCategory: 'Components', AllCountries: 'All Countries', SellerName: 'John', Discontinued: 'false' },
1398+
{ Years: '2021', ProductCategory: 'Components', Country: 'USA', SellerName: 'John', Discontinued: 'false' },
1399+
]);
1400+
1401+
// 01/01/2021
1402+
const date_2021_clothing_records = prod_country_date_seller_discontinued.filter(x => x['Date'] === '01/01/2021');
1403+
expect(date_2021_clothing_records).toEqual([
1404+
{ Date: '01/01/2021', AllProduct: 'All Products', AllCountries: 'All Countries', SellerName: 'Stanley', Discontinued: 'false' },
1405+
{ Date: '01/01/2021', AllProduct: 'All Products', Country: 'Bulgaria', SellerName: 'Stanley', Discontinued: 'false' },
1406+
{ Date: '01/01/2021', ProductCategory: 'Clothing', AllCountries: 'All Countries', SellerName: 'Stanley', Discontinued: 'false' },
1407+
{ Date: '01/01/2021', ProductCategory: 'Clothing', Country: 'Bulgaria', SellerName: 'Stanley', Discontinued: 'false' }
1408+
]);
13831409
// Discontinued, Date, Product, Country, Seller
13841410
pivotConfig.rows = [
13851411
dims[4],
@@ -1392,12 +1418,12 @@ describe('Pivot pipes #pivotGrid', () => {
13921418
rowPipeResult = rowPipe.transform(data, pivotConfig, expansionStates);
13931419
columnPipeResult = columnPipe.transform(rowPipeResult, pivotConfig, new Map<any, boolean>());
13941420
rowStatePipeResult = rowStatePipe.transform(columnPipeResult, pivotConfig, expansionStates, true);
1395-
expect(rowStatePipeResult.length).toBe(77);
1421+
expect(rowStatePipeResult.length).toBe(84);
13961422
const discontinued_prod_country_date_seller = PivotGridFunctions.getDimensionData(rowStatePipeResult, pivotConfig.rows);
13971423
const ongoing_records = discontinued_prod_country_date_seller.filter(x => x['Discontinued'] === 'false');
13981424
const discontinued_records = discontinued_prod_country_date_seller.filter(x => x['Discontinued'] === 'true');
1399-
expect(discontinued_records.length).toBe(33);
1400-
expect(ongoing_records.length).toBe(44);
1425+
expect(discontinued_records.length).toBe(36);
1426+
expect(ongoing_records.length).toBe(48);
14011427
const ongoing_allPeriods = ongoing_records.filter(x => x['AllPeriods'] === 'All Periods');
14021428
expect(ongoing_allPeriods).toEqual([
14031429
{ Discontinued: 'false', AllPeriods: 'All Periods', AllProduct: 'All Products', AllCountries: 'All Countries', SellerName: 'Stanley' },
@@ -1476,7 +1502,7 @@ describe('Pivot pipes #pivotGrid', () => {
14761502
rowPipeResult = rowPipe.transform(data, pivotConfig, expansionStates);
14771503
columnPipeResult = columnPipe.transform(rowPipeResult, pivotConfig, new Map<any, boolean>());
14781504
rowStatePipeResult = rowStatePipe.transform(columnPipeResult, pivotConfig, expansionStates, true);
1479-
expect(rowStatePipeResult.length).toBe(75);
1505+
expect(rowStatePipeResult.length).toBe(84);
14801506
const date_prod_disc_seller = PivotGridFunctions.getDimensionData(rowStatePipeResult, pivotConfig.rows);
14811507

14821508
const date_allPeriods_allProducts_records = date_prod_disc_seller.filter(x => x['AllPeriods'] === 'All Periods' && x['AllProduct'] === 'All Products');

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ export class PivotUtil {
285285
// otherwise overwrite direct child collection
286286
child[row.memberName + pivotKeys.rowDimensionSeparator + pivotKeys.records] = siblingData2;
287287
}
288-
const sibs = prevRowDims.filter(x => !x.childLevel && x.memberName !== prevRowField);
288+
const sibs = prevRowDims.filter(x => x.memberName !== prevRowField);
289289
if (sibs.length > 0) {
290290
// Process sibling dimensions in depth
291291
this.processSubGroups(row, [...sibs], [child], pivotKeys, lvl);

0 commit comments

Comments
 (0)