fix(tabs): replace igx-icon with igc-icon in WC demo + fix theme parameters (scoped) (#16415)

Author: adrianptrv

projects/igniteui-angular/src/lib/tabs/tabs/header/themes/_base.scss

@@ -45,7 +45,7 @@ $theme-variant: map.get($theme, '_meta', 'theme-variant');
         }
 
         &:focus {
-            background: var-get($theme, 'item-active-background');
+            background: var-get($theme, 'item-hover-background');
             color: var-get($theme, 'item-hover-color');
             border-bottom-color: transparent;
         }
@@ -71,14 +71,15 @@ $theme-variant: map.get($theme, '_meta', 'theme-variant');
         @include m(selected) {
             outline: 0;
             color: var-get($theme, 'item-active-color');
+            background: var-get($theme, 'item-active-background');
 
             &:hover,
             &:focus {
-                background: var-get($theme, 'item-active-background');
-                color: if($variant == 'fluent', var-get($theme, 'item-hover-color'), var-get($theme, 'item-active-color'));
+                background: var-get($theme, 'item-active-hover-background');
+                color: var-get($theme, 'item-active-hover-color');
 
                 igx-icon {
-                    color: var-get($theme, 'item-active-icon-color');
+                    color: var-get($theme, 'item-active-hover-icon-color');
                 }
             }
 

projects/igniteui-angular/src/lib/tabs/tabs/header/themes/shared/_bootstrap.scss

@@ -8,8 +8,9 @@ $_theme: $bootstrap;
 @include themed-block(igx-tabs, bootstrap) {
     %igx-tab-header--focus {
         border: none;
-        box-shadow: inset 0 0 0 rem(2px) var-get($_theme, 'item-hover-color');
-        border-radius: rem(4px);
+        box-shadow: inset 0 0 0 rem(2px) var-get($_theme, 'item-active-hover-color');
+        border-bottom-left-radius: rem(4px);
+        border-bottom-right-radius: rem(4px);
         z-index: 1;
 
         &::after {
@@ -32,7 +33,6 @@ $_theme: $bootstrap;
         }
 
         @include m(selected) {
-            background: var-get($_theme, 'item-active-background');
             position: relative;
             box-shadow: inset 0 0 0 rem(1px) var-get($_theme, 'border-color');
             z-index: 1;
@@ -62,6 +62,16 @@ $_theme: $bootstrap;
 
             &:hover {
                 box-shadow: inset 0 0 0 rem(1px) var-get($_theme, 'border-color');
+
+                &::before {
+                    background: linear-gradient(
+                            to right,
+                            var-get($_theme, 'border-color') 1px,
+                            var-get($_theme, 'item-active-hover-background') 1px,
+                            var-get($_theme, 'item-active-hover-background') calc(100% - 1px),
+                            var-get($_theme, 'border-color') calc(100% - 1px)
+                    );								
+                }
             }
         }
     }

projects/igniteui-angular/src/lib/tabs/tabs/header/themes/shared/_fluent.scss

@@ -14,6 +14,7 @@ $_theme: $fluent;
         min-height: rem(44px);
         transition: all .3s $tabs-animation-function;
         border: rem(1px) solid var-get($_theme, 'border-color');
+        border-radius: var-get($_theme, 'border-radius');
 
         &:hover,
         &:focus {

projects/igniteui-angular/src/lib/tabs/tabs/header/themes/shared/_indigo.scss

@@ -17,6 +17,7 @@ $_theme: $indigo;
 
         transition: all .3s $tabs-animation-function;
         border: rem(1px) solid var-get($_theme, 'border-color');
+        border-radius: var-get($_theme, 'border-radius');
 
         border-top: rem(1px) solid transparent;
         border-inline: none;
@@ -28,13 +29,6 @@ $_theme: $indigo;
             border-bottom: rem(1px) solid var-get($_theme, 'border-color');
         }
 
-        @include m(selected) {
-            &:hover,
-            &:focus-visible {
-                background: var-get($_theme, 'item-hover-background');
-            }
-        }
-
         @include e(inner) {
             > [igxtabheaderlabel] {
                 @include type-style(subtitle-2) {

projects/igniteui-angular/src/lib/tabs/tabs/header/themes/shared/_material.scss

@@ -12,6 +12,7 @@ $_theme: $material;
         min-height: rem(48px);
         transition: all .3s $tabs-animation-function;
         border: rem(1px) solid var-get($_theme, 'border-color');
+        border-radius: var-get($_theme, 'border-radius');
 
         &:hover,
         &:focus {

projects/igniteui-angular/src/lib/tabs/tabs/item/themes/_base.scss

@@ -16,7 +16,6 @@ $theme: $material;
         align-items: center;
         overflow: hidden;
         flex: 0 0 auto;
-        background: var-get($theme, 'item-background');
         z-index: 1;
 
         @include e(content) {

projects/igniteui-angular/src/lib/tabs/tabs/item/themes/shared/_bootstrap.scss

@@ -8,6 +8,7 @@ $_theme: $bootstrap;
 @include themed-block(igx-tabs, bootstrap) {
     @include b(igx-tabs-header) {
         position: relative;
+        background: var-get($_theme, 'item-background');
 
         &::after {
             content: '';

src/app/tabs-showcase/tabs-showcase.sample.html

@@ -32,7 +32,7 @@
             @for (contact of contacts; track contact.id) {
                 <igc-tab [selected]="contact.id === selectedTabId">
                     @if(!properties.hideIcon) {
-                        <igx-icon slot="label">folder</igx-icon>
+                        <igc-icon name="folder" slot="label"></igc-icon>
                     }
                     @if(!properties.hideText) {
                     <span slot="label">{{ contact.text }}</span>

src/app/tabs-showcase/tabs-showcase.sample.ts

@@ -20,13 +20,20 @@ import {
     defineComponents,
     IgcTabsComponent,
     IgcTabComponent,
+    IgcIconComponent,
+    registerIconFromText
 } from 'igniteui-webcomponents';
 import {
     PropertyChangeService,
     Properties,
 } from '../properties-panel/property-change.service';
 
-defineComponents(IgcTabsComponent, IgcTabComponent);
+defineComponents(IgcTabsComponent, IgcTabComponent, IgcIconComponent);
+
+registerIconFromText(
+    'folder',
+    '<svg xmlns="http://www.w3.org/2000/svg" height="24px" viewBox="0 -960 960 960" width="24px"><path d="M160-160q-33 0-56.5-23.5T80-240v-480q0-33 23.5-56.5T160-800h240l80 80h320q33 0 56.5 23.5T880-640v400q0 33-23.5 56.5T800-160H160Z"/></svg>'
+);
 
 @Component({
     selector: 'app-tabs-showcase-sample',