Merge branch 'master' into mvenkov/do-not-move-overlay-element-from-its-position

Author: wnvko

.github/workflows/trigger-licensed-release.yml

@@ -1,10 +1,12 @@
 name: Trigger Licensed Release
 
-permissions: {}
+permissions:
+  id-token: write
+  contents: read
 
 on:
   release:
-    types: [published]
+    types: [created]
   workflow_dispatch:
     inputs:
       release_tag:

projects/igniteui-angular/core/src/services/overlay/position/container-position-strategy.ts

@@ -25,9 +25,9 @@ export class ContainerPositionStrategy extends GlobalPositionStrategy {
         this.io = Util.setupIntersectionObserver(
             outletElement || target as HTMLElement,
             contentElement.ownerDocument,
-            () => this.updatePosition(contentElement, target as HTMLElement)
+            () => this.updatePosition(contentElement, outletElement || target as HTMLElement)
         );
-        this.internalPosition(contentElement, target as HTMLElement);
+        this.internalPosition(contentElement, outletElement || target as HTMLElement);
     }
 
     /**
@@ -42,8 +42,7 @@ export class ContainerPositionStrategy extends GlobalPositionStrategy {
         contentElement.classList.add('igx-overlay__content--relative');
         contentElement.parentElement.classList.add('igx-overlay__wrapper--flex-container');
         this.setPosition(contentElement);
-        const outletElement = contentElement.parentElement?.parentElement;
-        this.updatePosition(contentElement, outletElement ?? targetElement);
+        this.updatePosition(contentElement, targetElement);
     }
 
     private updatePosition(contentElement: HTMLElement, targetElement: HTMLElement): void {

projects/igniteui-angular/grids/grid/src/grid-base.directive.ts

@@ -6209,6 +6209,7 @@ export abstract class IgxGridBaseDirective implements GridType,
      */
     public showSnackbarFor(index: number) {
         this.addRowSnackbar.actionText = index === -1 ? '' : this.resourceStrings.igx_grid_snackbar_addrow_actiontext;
+        this.addRowSnackbar.container = this.tbodyContainer.nativeElement;
         this.lastAddedRowIndex = index;
         this.addRowSnackbar.open();
     }

projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts

@@ -2732,19 +2732,19 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
             fix.detectChanges();
 
             const thead = GridFunctions.getGridHeader(grid).nativeElement;
-            expect(thead.getBoundingClientRect().height).toEqual(grid.defaultRowHeight * 4 + 1);
+            expect(thead.getBoundingClientRect().height).toBeCloseTo(grid.defaultRowHeight * 4 + 1, 0);
 
             setElementSize(grid.nativeElement, ɵSize.Medium);
             fix.detectChanges();
             await wait(100); // needed because the resize observer handler for --ig-size is called inside an angular zone
             fix.detectChanges();
-            expect(thead.getBoundingClientRect().height).toEqual(grid.defaultRowHeight * 4 + 1);
+            expect(thead.getBoundingClientRect().height).toBeCloseTo(grid.defaultRowHeight * 4 + 1, 0);
 
             setElementSize(grid.nativeElement, ɵSize.Small);
             fix.detectChanges();
             await wait(100); // needed because the resize observer handler for --ig-size is called inside an angular zone
             fix.detectChanges();
-            expect(thead.getBoundingClientRect().height).toEqual(grid.defaultRowHeight * 4 + 1);
+            expect(thead.getBoundingClientRect().height).toBeCloseTo(grid.defaultRowHeight * 4 + 1, 0);
 
         });
 

projects/igniteui-angular/grids/grid/src/grid.component.html

@@ -30,7 +30,7 @@
 >
 </igx-grid-header-row>
 
-<div #gridBody igxGridBody (keydown.control.c)="copyHandler($event)" (copy)="copyHandler($event)" class="igx-grid__tbody" role="rowgroup">
+<div igxGridBody (keydown.control.c)="copyHandler($event)" (copy)="copyHandler($event)" class="igx-grid__tbody" role="rowgroup">
     <div class="igx-grid__tbody-content" tabindex="0" [attr.role]="dataView.length ? null : 'row'" (keydown)="navigation.handleNavigation($event)" (focus)="navigation.focusTbody($event)"
         (dragStop)="selectionService.dragMode = $event" (scroll)="preventContainerScroll($event)"
         (dragScroll)="dragScroll($event)" [igxGridDragSelect]="selectionService.dragMode"
@@ -179,7 +179,7 @@
     </div>
 
     <div class="igx-grid__addrow-snackbar">
-        <igx-snackbar #addRowSnackbar [container]="gridBody" [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]="snackbarDisplayTime">{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
+        <igx-snackbar #addRowSnackbar [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]="snackbarDisplayTime">{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
     </div>
 
     <div class="igx-grid__loading-outlet" #igxLoadingOverlayOutlet></div>

projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.component.html

@@ -147,7 +147,7 @@
         <div class="igx-grid__tbody-scrollbar-end" [style.height.px]="!isRowPinningToTop ? pinnedRowHeight : 0"></div>
     </div>
     <div class="igx-grid__addrow-snackbar">
-        <igx-snackbar #addRowSnackbar [target]="gridBody" [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]="snackbarDisplayTime">{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
+        <igx-snackbar #addRowSnackbar [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]="snackbarDisplayTime">{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
     </div>
 </div>
 

projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.html

@@ -81,10 +81,8 @@
     </div>
 
     <div class="igx-grid__addrow-snackbar">
-        <igx-snackbar #addRowSnackbar [container]="igxBodyOverlayOutlet" [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]="snackbarDisplayTime">{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
+        <igx-snackbar #addRowSnackbar [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]="snackbarDisplayTime">{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
     </div>
-
-    <div #igxBodyOverlayOutlet></div>
 </div>
 
 <div class="igx-grid__scroll" [style.height.px]="scrollSize" #scr [hidden]="isHorizontalScrollHidden" (pointerdown)="$event.preventDefault()">

projects/igniteui-angular/grids/tree-grid/src/tree-grid.component.html

@@ -138,7 +138,7 @@
         <div class="igx-grid__tbody-scrollbar-end" [style.height.px]='!isRowPinningToTop ? pinnedRowHeight : 0'></div>
     </div>
     <div class="igx-grid__addrow-snackbar">
-        <igx-snackbar #addRowSnackbar [container]="gridBody" [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]='snackbarDisplayTime'>{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
+        <igx-snackbar #addRowSnackbar [actionText]="resourceStrings.igx_grid_snackbar_addrow_actiontext" [displayTime]='snackbarDisplayTime'>{{resourceStrings.igx_grid_snackbar_addrow_label}}</igx-snackbar>
     </div>
 </div>
 

src/app/drop-down/drop-down.sample.html

@@ -50,9 +50,9 @@
                 [value]="item.selected"
             >
                 @if(!properties.hidePrefix) {
-                <igx-icon slot="prefix">location_city</igx-icon>
+                <igc-icon slot="prefix" name="location_city"></igc-icon>
                 } {{ item.field }} @if(!properties.hideSuffix) {
-                <igx-icon slot="suffix">location_on</igx-icon>
+                <igc-icon slot="suffix" name="location_on"></igc-icon>
                 }
             </igc-dropdown-item>
             } }