Merge pull request #12427 from IgniteUI/vkombov/fix-12391-15.0.x

fix(grid): Add check whether the row editing has already started - 15.0.x

Author: ChronosSF

projects/igniteui-angular/src/lib/grids/common/crud.service.ts

@@ -297,6 +297,7 @@ export class IgxRowCrudState extends IgxCellCrudState {
     public closeRowEditingOverlay = new Subject();
 
     private _rowEditingBlocked = false;
+    private _rowEditingStarted = false;
 
     public get primaryKey(): any {
         return this.grid.primaryKey;
@@ -329,12 +330,17 @@ export class IgxRowCrudState extends IgxCellCrudState {
             if (!this.row) {
                 this.createRow(this.cell);
             }
-            const rowArgs = this.row.createEditEventArgs(false, event);
 
-            this.grid.rowEditEnter.emit(rowArgs);
-            if (rowArgs.cancel) {
-                this.endEditMode();
-                return true;
+            if (!this._rowEditingStarted) {
+                const rowArgs = this.row.createEditEventArgs(false, event);
+
+                this.grid.rowEditEnter.emit(rowArgs);
+                if (rowArgs.cancel) {
+                    this.endEditMode();
+                    return true;
+                }
+
+                this._rowEditingStarted = true;
             }
 
             this.row.transactionState = this.grid.transactions.getAggregatedValue(this.row.id, true);
@@ -435,6 +441,7 @@ export class IgxRowCrudState extends IgxCellCrudState {
     public endRowEdit() {
         this.row = null;
         this.rowEditingBlocked = false;
+        this._rowEditingStarted = false;
     }
 
     /** Clears cell and row editing state and closes row editing template if it is open */

projects/igniteui-angular/src/lib/grids/grid/grid-add-row.spec.ts

@@ -482,6 +482,28 @@ describe('IgxGrid - Row Adding #grid', () => {
             expect(grid.gridAPI.get_row_by_index(1).addRowUI).toBeTrue();
         });
 
+        it(`Should emit 'rowEditEnter' only once while adding a new row`, () => {
+            spyOn(grid.rowEditEnter, 'emit').and.callThrough();
+            const row = grid.gridAPI.get_row_by_index(0);
+            row.beginAddRow();
+            fixture.detectChanges();
+
+            endTransition();
+
+            const newRow = grid.gridAPI.get_row_by_index(1);
+            expect(newRow.addRowUI).toBeTrue();
+
+            let targetCell = grid.gridAPI.get_cell_by_index(1, 'ContactName') as any;
+            UIInteractions.simulateClickAndSelectEvent(targetCell);
+            fixture.detectChanges();
+
+            targetCell = grid.gridAPI.get_cell_by_index(1, 'CompanyName') as any;
+            UIInteractions.simulateClickAndSelectEvent(targetCell);
+            fixture.detectChanges();
+
+            expect(grid.rowEditEnter.emit).toHaveBeenCalledTimes(1);
+        });
+
         it('Should scroll and start adding a row as the first one when using the public API method', async () => {
             await wait(DEBOUNCETIME);
             fixture.detectChanges();