Skip to content

Commit 5e8714e

Browse files
authored
Merge branch 'master' into slider-ticks-refactoring
2 parents 030ce2c + 1759bd5 commit 5e8714e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ export class IgxColumnComponent implements AfterContentInit {
584584
/* No grid/width available at initialization. `initPinning` in the grid
585585
will re-init the group (if present)
586586
*/
587-
this._unpinnedIndex = this.grid.columns.filter(x => !x.pinned).indexOf(this);
587+
this._unpinnedIndex = this.grid ? this.grid.columns.filter(x => !x.pinned).indexOf(this) : 0;
588588
this._pinned = value;
589589
this.pinnedChange.emit(this._pinned);
590590
}

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-advanced.spec.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -542,10 +542,12 @@ describe('IgxGrid - Advanced Filtering', () => {
542542
fix.detectChanges();
543543

544544
// Verify the filter results.
545-
expect(grid.filteredData.length).toEqual(6);
546-
expect(grid.rowList.length).toBe(6);
547-
expect(GridFunctions.getCurrentCellFromGrid(grid, 0, 1).value).toBe('Ignite UI for JavaScript');
548-
expect(GridFunctions.getCurrentCellFromGrid(grid, 1, 1).value).toBe('NetAdvantage');
545+
const expectedData = fix.componentInstance.data.filter(r =>
546+
r.ReleaseDate && r.ReleaseDate.getFullYear() === (new Date()).getFullYear());
547+
expect(grid.filteredData.length).toEqual(expectedData.length);
548+
expect(grid.rowList.length).toBe(expectedData.length);
549+
expect(GridFunctions.getCurrentCellFromGrid(grid, 0, 1).value).toBe(expectedData[0].ProductName);
550+
expect(GridFunctions.getCurrentCellFromGrid(grid, 1, 1).value).toBe(expectedData[1].ProductName);
549551
}));
550552

551553
it('Should correctly filter by a \'date\' column through UI with value from calendar.', fakeAsync(() => {

0 commit comments

Comments
 (0)