chore(dropdown): Addressing comments and removing unnecessary code and imports

Author: IvanKitanov17

projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts

@@ -34,18 +34,6 @@ const CSS_CLASS_TABS = '.igx-tabs__header-item';
 describe('IgxDropDown ', () => {
     let fixture;
     let dropdown: IgxDropDownComponent;
-
-    const defaultOverlaySettings: OverlaySettings = {
-        closeOnOutsideClick: true,
-        modal: false,
-        positionStrategy: new ConnectedPositioningStrategy({
-            horizontalStartPoint: HorizontalAlignment.Left,
-            verticalStartPoint: VerticalAlignment.Bottom,
-            horizontalDirection: HorizontalAlignment.Right,
-            verticalDirection: VerticalAlignment.Bottom
-        })
-    };
-
     describe('Unit tests', () => {
         const data = [
             { value: 'Item0', index: 0 } as IgxDropDownItemComponent,
@@ -258,8 +246,8 @@ describe('IgxDropDown ', () => {
                 expect(toggle.open).toHaveBeenCalledTimes(1);
 
                 const appliedSettings = (toggle.open as jasmine.Spy).calls.mostRecent().args[0];
-                expect(appliedSettings.closeOnOutsideClick).toBe(defaultOverlaySettings.closeOnOutsideClick);
-                expect(appliedSettings.modal).toBe(defaultOverlaySettings.modal);
+                expect(appliedSettings.closeOnOutsideClick).toBe(true);
+                expect(appliedSettings.modal).toBe(false);
                 expect(appliedSettings.positionStrategy instanceof ConnectedPositioningStrategy).toBe(true);
 
                 const positionStrategy = appliedSettings.positionStrategy as ConnectedPositioningStrategy;

projects/igniteui-angular/src/lib/drop-down/drop-down.component.ts

@@ -29,7 +29,7 @@ import { Subject } from 'rxjs';
 import { IgxDropDownItemBaseDirective } from './drop-down-item.base';
 import { IgxForOfToken } from '../directives/for-of/for_of.directive';
 import { take } from 'rxjs/operators';
-import { HorizontalAlignment, OverlaySettings, VerticalAlignment } from '../services/overlay/utilities';
+import { OverlaySettings } from '../services/overlay/utilities';
 import { DOCUMENT, NgIf } from '@angular/common';
 import { ConnectedPositioningStrategy } from '../services/overlay/position';
 
@@ -50,17 +50,6 @@ import { ConnectedPositioningStrategy } from '../services/overlay/position';
  * ```
  */
 
-const defaultOverlaySettings: OverlaySettings = {
-    closeOnOutsideClick: true,
-    modal: false,
-    positionStrategy: new ConnectedPositioningStrategy({
-        horizontalStartPoint: HorizontalAlignment.Left,
-        verticalStartPoint: VerticalAlignment.Bottom,
-        horizontalDirection: HorizontalAlignment.Right,
-        verticalDirection: VerticalAlignment.Bottom
-    })
-};
-
 @Component({
     selector: 'igx-drop-down',
     templateUrl: './drop-down.component.html',
@@ -255,11 +244,22 @@ export class IgxDropDownComponent extends IgxDropDownBaseDirective implements ID
      * ```
      */
     public open(overlaySettings?: OverlaySettings) {
-        const settings = overlaySettings || { ...defaultOverlaySettings };
+        const settings = overlaySettings || this.getDefaultOverlaySettings();
         this.toggleDirective.open(settings);
         this.updateScrollPosition();
     }
 
+    /**
+   * @hidden @internal
+   */
+    public getDefaultOverlaySettings(): OverlaySettings {
+        return {
+            closeOnOutsideClick: true,
+            modal: false,
+            positionStrategy: new ConnectedPositioningStrategy()
+        };
+    }
+
     /**
      * Closes the dropdown
      *