feat(summary): refactor summary calculation to simplify and improve row height

Author: georgianastasov

projects/igniteui-angular/src/lib/grids/summaries/grid-summary.service.ts

@@ -10,7 +10,7 @@ export class IgxGridSummaryService {
     public grid: GridType;
     public rootSummaryID = 'igxGridRootSummary';
     public summaryHeight = 0;
-    public maxSummariesLenght = 0;
+    public maxSummariesLength = 0;
     public groupingExpressions = [];
     public retriggerRootPipe = 0;
     public deleteOperation = false;
@@ -98,14 +98,16 @@ export class IgxGridSummaryService {
         }
         let maxSummaryLength = 0;
         this.grid.columns.filter((col) => col.hasSummary && !col.hidden).forEach((column) => {
-            const getCurrentSummaryColumn = column.summaries.operate([], [], column.field).length;
-            if (getCurrentSummaryColumn) {
-                if (maxSummaryLength < getCurrentSummaryColumn) {
-                    maxSummaryLength = getCurrentSummaryColumn;
-                }
+            const getCurrentSummary = column.summaries.operate([], [], column.field);
+            const getCurrentSummaryColumn = column.disabledSummaries.length > 0
+                ? getCurrentSummary.filter(s => !column.disabledSummaries.includes(s.key)).length
+                : getCurrentSummary.length;
+
+            if (maxSummaryLength < getCurrentSummaryColumn) {
+                maxSummaryLength = getCurrentSummaryColumn;
             }
         });
-        this.maxSummariesLenght = maxSummaryLength;
+        this.maxSummariesLength = maxSummaryLength;
         this.summaryHeight = maxSummaryLength * this.grid.defaultSummaryHeight;
         return this.summaryHeight;
     }
@@ -123,27 +125,19 @@ export class IgxGridSummaryService {
 
         this.grid.columns.filter(col => col.hasSummary).forEach((column) => {
             if (!rowSummaries.get(column.field)) {
-                let summaryResult = column.disabledSummaries.length
-                    ? this.getCachedSummary(column.field, column.disabledSummaries) || null
-                    : null;
+                let summaryResult = column.summaries.operate(
+                    data.map(r => resolveNestedPath(r, column.field)),
+                    data,
+                    column.field,
+                    groupRecord,
+                    this.grid.locale,
+                    column.pipeArgs
+                );
 
-                if (!summaryResult) {
-                    summaryResult = column.summaries.operate(
-                        data.map(r => resolveNestedPath(r, column.field)),
-                        data,
-                        column.field,
-                        groupRecord,
-                        this.grid.locale,
-                        column.pipeArgs
-                    );
+                summaryResult = column.disabledSummaries.length > 0
+                    ? summaryResult.filter(s => !column.disabledSummaries.includes(s.key))
+                    : summaryResult;
 
-                    if (column.disabledSummaries.length) {
-                        summaryResult = summaryResult.filter(
-                            result => !column.disabledSummaries.includes(result.key)
-                        );
-                        this.cacheSummary(column.field, summaryResult, column.disabledSummaries);
-                    }
-                }
                 rowSummaries.set(column.field, summaryResult);
             }
         });
@@ -266,17 +260,4 @@ export class IgxGridSummaryService {
             });
         }
     }
-
-    private cacheSummary(field: string, summaryResult: IgxSummaryResult[], disabledSummaries: string[] = []) {
-        if (!this.summaryCacheMap.has(field)) {
-            this.summaryCacheMap.set(field, new Map<string, IgxSummaryResult[]>());
-        }
-        const cacheKey = JSON.stringify(disabledSummaries);
-        this.summaryCacheMap.get(field).set(cacheKey, summaryResult);
-    }
-
-    private getCachedSummary(field: string, disabledSummaries: string[] = []): IgxSummaryResult[] | undefined {
-        const cacheKey = JSON.stringify(disabledSummaries);
-        return this.summaryCacheMap.get(field)?.get(cacheKey);
-    }
 }