Skip to content

Commit 5f7dbbd

Browse files
authored
Merge pull request #7512 from IgniteUI/ddincheva/clearCellFocus
Remove cell focus leftovers
2 parents 8ba098f + b54e758 commit 5f7dbbd

File tree

3 files changed

+1
-33
lines changed

3 files changed

+1
-33
lines changed

projects/igniteui-angular/src/lib/grids/api.service.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -588,12 +588,6 @@ export class GridBaseAPIService <T extends IgxGridBaseDirective & GridType> {
588588
if (grid.rowEditable) {
589589
grid.endEdit(true);
590590
}
591-
const eventKey = event && (event as any).key ? (event as any).key.toLowerCase() : null;
592-
if (eventKey && this.isToggleKey(eventKey)) {
593-
(this.grid as any).zone.onStable.pipe(debounceTime(30)).pipe(first()).subscribe(() => {
594-
this.focusActiveCell(rowID);
595-
});
596-
}
597591
}
598592

599593
public get_rec_by_id(rowID) {
@@ -608,16 +602,4 @@ export class GridBaseAPIService <T extends IgxGridBaseDirective & GridType> {
608602
return ROW_COLLAPSE_KEYS.has(key) || ROW_EXPAND_KEYS.has(key);
609603
}
610604

611-
private focusActiveCell(rowID) {
612-
// persist focused cell
613-
const isVirtualized = !this.grid.verticalScrollContainer.dc.instance.notVirtual;
614-
const el = this.grid.selectionService.activeElement;
615-
if (isVirtualized && el) {
616-
const cell = this.get_cell_by_key(rowID, this.grid.visibleColumns[el.column].field);
617-
if (cell) {
618-
cell.nativeElement.focus();
619-
}
620-
}
621-
}
622-
623605
}

projects/igniteui-angular/src/lib/grids/grid/expandable-cell.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ export class IgxGridExpandableCellComponent extends IgxGridCellComponent impleme
6868
*/
6969
public onIndicatorFocus() {
7070
this.gridAPI.submit_value();
71-
this.nativeElement.focus();
7271
}
7372

7473
/**

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import {
33
Component,
44
HostBinding,
55
Input,
6-
Output,
7-
EventEmitter,
86
forwardRef,
97
OnInit,
108
TemplateRef,
@@ -18,7 +16,7 @@ import { IgxTreeGridAPIService } from './tree-grid-api.service';
1816
import { IgxGridBaseDirective } from '../grid-base.directive';
1917
import { GridBaseAPIService } from '../api.service';
2018
import { ITreeGridRecord } from './tree-grid.interfaces';
21-
import { IRowToggleEventArgs, IPinRowEventArgs } from '../common/events';
19+
import { IRowToggleEventArgs } from '../common/events';
2220
import { HierarchicalTransaction, HierarchicalState, TransactionType } from '../../services/transaction/transaction';
2321
import { IgxHierarchicalTransactionService } from '../../services/index';
2422
import { IgxFilteringService } from '../filtering/grid-filtering.service';
@@ -28,7 +26,6 @@ import { mergeObjects } from '../../core/utils';
2826
import { first, takeUntil } from 'rxjs/operators';
2927
import { IgxRowLoadingIndicatorTemplateDirective } from './tree-grid.directives';
3028
import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives/for-of/for_of.sync.service';
31-
import { IgxDragIndicatorIconDirective } from '../row-drag.directive';
3229
import { IgxGridNavigationService } from '../grid-navigation.service';
3330
import { GridType } from '../common/grid.interface';
3431
import { IgxColumnComponent } from '../columns/column.component';
@@ -375,16 +372,6 @@ export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridTy
375372
this.loadingRows.delete(parentID);
376373
this.addChildRows(children, parentID);
377374
this.notifyChanges();
378-
379-
requestAnimationFrame(() => {
380-
const cellID = this.selectionService.activeElement;
381-
if (cellID) {
382-
const cell = this._gridAPI.get_cell_by_index(cellID.row, cellID.column);
383-
if (cell) {
384-
cell.nativeElement.focus();
385-
}
386-
}
387-
});
388375
});
389376
}
390377
}

0 commit comments

Comments
 (0)