Skip to content

Commit 62135bb

Browse files
committed
feat(overlay): do not move overlay element
1 parent 4296934 commit 62135bb

File tree

29 files changed

+986
-671
lines changed

29 files changed

+986
-671
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,15 @@
22

33
All notable changes for each version of this project will be documented in this file.
44

5+
## 21.1.1
6+
7+
### New Features
8+
9+
- `IgxOverlayService`
10+
- The overlay service now always renders content in place using the HTML Popover API, eliminating the need for outlet containers.
11+
12+
- **Deprecation** - The `outlet` property in `OverlaySettings`, `IgxOverlayOutletDirective`, and `igxToggleOutlet` input on `IgxToggleActionDirective` are all deprecated. The overlay service now always renders content in place using the HTML Popover API. These will be removed in a future version.
13+
514
## 21.1.0
615

716
### New Features

projects/igniteui-angular/calendar/src/calendar/calendar-multi-view.component.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1045,7 +1045,7 @@ describe('Multi-View Calendar - ', () => {
10451045
tick(400);
10461046
fixture.detectChanges();
10471047

1048-
let overlay = document.querySelector(HelperTestFunctions.OVERLAY_CSSCLASS);
1048+
let overlay = document.querySelector(HelperTestFunctions.CALENDAR_WRAPPER_CLASS);
10491049
HelperTestFunctions.verifyMonthsViewNumber(overlay, 3);
10501050
HelperTestFunctions.verifyCalendarSubHeaders(overlay, [ymd('2019-09-16'), ymd('2019-10-16'), ymd('2019-11-16')]);
10511051

@@ -1064,7 +1064,7 @@ describe('Multi-View Calendar - ', () => {
10641064
tick(400);
10651065
fixture.detectChanges();
10661066

1067-
overlay = document.querySelector(HelperTestFunctions.OVERLAY_CSSCLASS);
1067+
overlay = document.querySelector(HelperTestFunctions.CALENDAR_WRAPPER_CLASS);
10681068
HelperTestFunctions.verifyMonthsViewNumber(overlay, 2);
10691069
HelperTestFunctions.verifyCalendarSubHeaders(overlay, [ymd('2019-09-16'), ymd('2019-10-16')]);
10701070

@@ -1079,7 +1079,7 @@ describe('Multi-View Calendar - ', () => {
10791079
fixture.detectChanges();
10801080

10811081
expect(datePicker.hideOutsideDays).toBe(true);
1082-
let overlay = document.querySelector(HelperTestFunctions.OVERLAY_CSSCLASS);
1082+
let overlay = document.querySelector(HelperTestFunctions.CALENDAR_WRAPPER_CLASS);
10831083
expect(HelperTestFunctions.getHiddenDays(overlay, 0).length).toBe(HelperTestFunctions.getInactiveDays(overlay, 0).length);
10841084
expect(HelperTestFunctions.getHiddenDays(overlay, 1).length).toBe(HelperTestFunctions.getInactiveDays(overlay, 1).length);
10851085
expect(HelperTestFunctions.getHiddenDays(overlay, 2).length).toBe(HelperTestFunctions.getInactiveDays(overlay, 2).length);
@@ -1098,7 +1098,7 @@ describe('Multi-View Calendar - ', () => {
10981098
fixture.detectChanges();
10991099

11001100
expect(datePicker.hideOutsideDays).toBe(false);
1101-
overlay = document.querySelector(HelperTestFunctions.OVERLAY_CSSCLASS);
1101+
overlay = document.querySelector(HelperTestFunctions.CALENDAR_WRAPPER_CLASS);
11021102
expect(HelperTestFunctions.getHiddenDays(overlay, 0).length).toBe(12);
11031103
expect(HelperTestFunctions.getHiddenDays(overlay, 1).length).toBe(11);
11041104
expect(HelperTestFunctions.getHiddenDays(overlay, 2).length).toBe(5);

projects/igniteui-angular/core/src/services/overlay/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ this.overlay.show(component, overlaySettings);
7878
| scrollStrategy | IScrollStrategy | Scroll strategy to use with this settings |
7979
| modal | boolean | Set if the overlay should be in modal mode |
8080
| closeOnOutsideClick | boolean | Set if the overlay should closed on outside click |
81-
| outlet | IgxOverlayOutletDirective or ElementRef | Set the outlet container to attach the overlay to |
81+
| outlet | IgxOverlayOutletDirective or ElementRef | **Deprecated.** No longer has any effect. The overlay service now always renders content in place using the HTML Popover API. This property will be removed in a future version. |
8282

8383
###### PositionSettings
8484

@@ -135,7 +135,7 @@ this.overlay.show(component, overlaySettings);
135135
| Name | Description | Parameters |
136136
|-----------------|---------------------------------------------------------------------------------|------------|
137137
|getPointFromPositionsSettings| Calculates the point from which the overlay should start showing |settings |
138-
|createAbsoluteOverlaySettings| Creates overlay settings with global or container position strategy based on a preset position settings |position?, outlet?|
138+
|createAbsoluteOverlaySettings| Creates overlay settings with global or container position strategy based on a preset position settings. **Note:** The `outlet` parameter is deprecated and no longer has any effect. The overlay service now always renders content in place. |position?, outlet?|
139139
|createRelativeOverlaySettings| Creates overlay settings with auto, connected or elastic position strategy based on a preset position settings |target, strategy?, position?|
140140

141141

0 commit comments

Comments
 (0)